From 6aabb3839fed28bad9f1bc49417e4578957c163d Mon Sep 17 00:00:00 2001 From: James Kasten Date: Mon, 17 Aug 2015 13:27:15 -0700 Subject: [PATCH] address comments --- letsencrypt-apache/letsencrypt_apache/tests/dvsni_test.py | 1 - letsencrypt-apache/letsencrypt_apache/tests/util.py | 3 --- letsencrypt/reverter.py | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/letsencrypt-apache/letsencrypt_apache/tests/dvsni_test.py b/letsencrypt-apache/letsencrypt_apache/tests/dvsni_test.py index 884ec9e62..c362d4115 100644 --- a/letsencrypt-apache/letsencrypt_apache/tests/dvsni_test.py +++ b/letsencrypt-apache/letsencrypt_apache/tests/dvsni_test.py @@ -22,7 +22,6 @@ class DvsniPerformTest(util.ApacheTest): config = util.get_apache_configurator( self.config_path, self.config_dir, self.work_dir) config.config.dvsni_port = 443 - config.config.func.__name__ = "auth" from letsencrypt_apache import dvsni self.sni = dvsni.ApacheDvsni(config) diff --git a/letsencrypt-apache/letsencrypt_apache/tests/util.py b/letsencrypt-apache/letsencrypt_apache/tests/util.py index 0782bef25..b544e06ee 100644 --- a/letsencrypt-apache/letsencrypt_apache/tests/util.py +++ b/letsencrypt-apache/letsencrypt_apache/tests/util.py @@ -92,9 +92,6 @@ def get_apache_configurator( config.prepare() - # Simulate a 'run' by default - config.config.func.__name__ = "run" - return config diff --git a/letsencrypt/reverter.py b/letsencrypt/reverter.py index f2281ff5e..8eed59156 100644 --- a/letsencrypt/reverter.py +++ b/letsencrypt/reverter.py @@ -75,7 +75,7 @@ class Reverter(object): backups = os.listdir(self.config.backup_dir) backups.sort() - if len(backups) == 0: + if not backups: logger.warning( "Let's Encrypt hasn't modified your configuration, so rollback " "isn't available.")