From 442dd25cb3ebe06afa5fe0652a32a3a81a56832a Mon Sep 17 00:00:00 2001 From: Erica Portnoy Date: Tue, 11 May 2021 15:10:21 -0700 Subject: [PATCH] Decrease logging level to info for idempotent operation where enhancement is already set --- certbot/certbot/_internal/client.py | 4 ++-- certbot/tests/client_test.py | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/certbot/certbot/_internal/client.py b/certbot/certbot/_internal/client.py index d8e94610c..a5b92999d 100644 --- a/certbot/certbot/_internal/client.py +++ b/certbot/certbot/_internal/client.py @@ -621,10 +621,10 @@ class Client: self.installer.enhance(dom, enhancement, options) except errors.PluginEnhancementAlreadyPresent: if enhancement == "ensure-http-header": - logger.warning("Enhancement %s was already set.", + logger.info("Enhancement %s was already set.", options) else: - logger.warning("Enhancement %s was already set.", + logger.info("Enhancement %s was already set.", enhancement) except errors.PluginError: logger.warning("Unable to set enhancement %s for %s", diff --git a/certbot/tests/client_test.py b/certbot/tests/client_test.py index a49f1c9ac..b789770f4 100644 --- a/certbot/tests/client_test.py +++ b/certbot/tests/client_test.py @@ -611,16 +611,16 @@ class EnhanceConfigTest(ClientTestCommon): def test_already_exists_header(self, mock_log): self.config.hsts = True self._test_with_already_existing() - self.assertIs(mock_log.warning.called, True) - self.assertEqual(mock_log.warning.call_args[0][1], + self.assertIs(mock_log.info.called, True) + self.assertEqual(mock_log.info.call_args[0][1], 'Strict-Transport-Security') @mock.patch("certbot._internal.client.logger") def test_already_exists_redirect(self, mock_log): self.config.redirect = True self._test_with_already_existing() - self.assertIs(mock_log.warning.called, True) - self.assertEqual(mock_log.warning.call_args[0][1], + self.assertIs(mock_log.info.called, True) + self.assertEqual(mock_log.info.call_args[0][1], 'redirect') @mock.patch("certbot._internal.client.logger")