upstream/certbot
1
0
Fork 0
mirror of https://github.com/certbot/certbot.git synced 2026-05-28 04:34:11 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

mention that the deploy hook will use the active cert not the test one

Browse source
This commit is contained in:
Erica Portnoy 2022-11-29 17:08:22 -08:00
parent 16365e95e2
commit 4336547979
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
certbot/certbot/_internal/cli/__init__.py
View file

@ -170,8 +170,9 @@ def prepare_and_parse_args(plugins: plugins_disco.PluginsRegistry, args: List[st
" deploy hooks. This includes hooks set on the command line, saved in the"
" certificate's renewal configuration file, or present in the renewal-hooks directory."
" To exclude direcory hooks, use --no-directory-hooks. The hook(s) will only"
" be run if the dry run succeeds. This flag is recommended when modifying the deploy"
" hook using `reconfigure`.")
" be run if the dry run succeeds, and will use the current active certificate, not"
" the temporary test certificate acquired during the dry run. This flag is recommended"
" when modifying the deploy hook using `reconfigure`.")
helpful.add(
["register", "automation"], "--register-unsafely-without-email", action="store_true",
default=flag_default("register_unsafely_without_email"),

8
certbot/certbot/_internal/main.py
View file

@ -1736,9 +1736,11 @@ def reconfigure(config: configuration.NamespaceConfig,
# figure this out before we modify config
if config.deploy_hook and not config.run_deploy_hook:
msg = ("You are attempting to set a new --deploy-hook. Would you like Certbot to run the new "
"hook when it performs a dry run with the new settings? This will run all relevant "
"deploy hooks, including directory hooks, unless --no-directory-hooks is set.")
msg = ("You are attempting to set a new --deploy-hook. Would you like Certbot to run the "
"new hook when it performs a dry run with the new settings? This will run all "
"relevant deploy hooks, including directory hooks, unless --no-directory-hooks "
"is set. This will use the current active certificate, and not the temporary test "
"certificate acquired during the dry run.")
config.run_deploy_hook = display_util.yesno(msg,"Run deploy hook",
"Do not run deploy hook", default=False)