diff --git a/docs/contributing.rst b/docs/contributing.rst index e634d8761..07583d8e0 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -127,7 +127,6 @@ Boulder: .. code-block:: shell - export SERVER=http://10.77.77.77:4000/directory source tests/integration/_common.sh Run the integration tests using: diff --git a/tests/integration/_common.sh b/tests/integration/_common.sh index b9281940c..cc04bd6b3 100755 --- a/tests/integration/_common.sh +++ b/tests/integration/_common.sh @@ -16,9 +16,11 @@ certbot_test () { "$@" } +export BOULDER_IP=${BOULDER_IP:10.77.77.77} +export SERVER=${SERVER:-http://$BOULDER_IP:4000/directory} # Use local ACMEv2 endpoint if requested and SERVER isn't already set. if [ "${BOULDER_INTEGRATION:-v1}" = "v2" -a -z "${SERVER:+x}" ]; then - SERVER="http://10.77.77.77:4001/directory" + SERVER="http://$BOULDER_IP:4001/directory" fi certbot_test_no_force_renew () { @@ -30,7 +32,7 @@ certbot_test_no_force_renew () { --source $sources \ --omit $omit_patterns \ $(command -v certbot) \ - --server "${SERVER:-http://10.77.77.77:4000/directory}" \ + --server "${SERVER}" \ --no-verify-ssl \ --tls-sni-01-port $tls_sni_01_port \ --http-01-port $http_01_port \ diff --git a/tests/manual-dns-auth.sh b/tests/manual-dns-auth.sh index febecf455..121b21ac0 100755 --- a/tests/manual-dns-auth.sh +++ b/tests/manual-dns-auth.sh @@ -2,7 +2,7 @@ # If domain begins with fail, fail the challenge by not completing it. if [[ "$CERTBOT_DOMAIN" != fail* ]]; then - curl -X POST 'http://localhost:8055/set-txt' -d \ + curl -X POST 'http://$BOULDER_IP:8055/set-txt' -d \ "{\"host\": \"_acme-challenge.$CERTBOT_DOMAIN.\", \ \"value\": \"$CERTBOT_VALIDATION\"}" fi diff --git a/tests/manual-dns-cleanup.sh b/tests/manual-dns-cleanup.sh index 1c09e892c..8fa2ebbc4 100755 --- a/tests/manual-dns-cleanup.sh +++ b/tests/manual-dns-cleanup.sh @@ -3,6 +3,6 @@ # If domain begins with fail, we didn't complete the challenge so there is # nothing to clean up. if [[ "$CERTBOT_DOMAIN" != fail* ]]; then - curl -X POST 'http://localhost:8055/clear-txt' -d \ + curl -X POST 'http://$BOULDER_IP:8055/clear-txt' -d \ "{\"host\": \"_acme-challenge.$CERTBOT_DOMAIN.\"}" fi diff --git a/tools/deactivate.py b/tools/deactivate.py index 2f8b2e6e3..d43b84552 100644 --- a/tools/deactivate.py +++ b/tools/deactivate.py @@ -24,7 +24,7 @@ from acme import client as acme_client from acme import errors as acme_errors from acme import messages -DIRECTORY = os.getenv('DIRECTORY', 'http://10.77.77.77:4000/directory') +DIRECTORY = os.getenv('DIRECTORY', 'http://localhost:4000/directory') if len(sys.argv) != 2: print("Usage: python deactivate.py private_key.pem")