From 325f51aba5e9608fde3c4740d5f0154045c253b9 Mon Sep 17 00:00:00 2001
From: Brad Warren <bmw@eff.org>
Date: Wed, 12 Aug 2020 16:38:55 -0700
Subject: [PATCH] Error if TAG_BASE is empty.

---
 tools/docker/build.sh  | 4 ++++
 tools/docker/deploy.sh | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/tools/docker/build.sh b/tools/docker/build.sh
index 79617ca84..9996e6440 100755
--- a/tools/docker/build.sh
+++ b/tools/docker/build.sh
@@ -51,6 +51,10 @@ Build() {
 }
 
 TAG_BASE="$1"
+if [ -z "$TAG_BASE" ]; then
+    echo "We cannot tag Docker images with an empty string!" >&2
+    exit 1
+fi
 
 # Step 1: Certbot core Docker
 Build "$DOCKER_HUB_ORG/certbot" "$TAG_BASE" "$REPO_ROOT" "$WORK_DIR/core"
diff --git a/tools/docker/deploy.sh b/tools/docker/deploy.sh
index 89802f264..6b85ac0b6 100755
--- a/tools/docker/deploy.sh
+++ b/tools/docker/deploy.sh
@@ -24,6 +24,10 @@ Deploy() {
 }
 
 TAG_BASE="$1"  # Eg. v0.35.0 or nightly
+if [ -z "$TAG_BASE" ]; then
+    echo "We cannot tag Docker images with an empty string!" >&2
+    exit 1
+fi
 source "$WORK_DIR/lib/common"
 
 # Step 1: Certbot core Docker