From 2dbb121e354c1dc3af6492f71db4dea5a2c2237e Mon Sep 17 00:00:00 2001
From: Adrien Ferrand <ferrand.ad@gmail.com>
Date: Thu, 13 Feb 2020 17:02:38 +0100
Subject: [PATCH] Finish integration tests

---
 .../test_main.py                              | 108 ++++++++++--------
 windows-installer/auto-update.ps1             |   4 +-
 windows-installer/tasks-up.ps1                |   2 +-
 windows-installer/template-nsi.patch          | Bin 0 -> 9628 bytes
 windows-installer/template.nsi                |  89 +++------------
 5 files changed, 79 insertions(+), 124 deletions(-)
 create mode 100644 windows-installer/template-nsi.patch

diff --git a/certbot-ci/windows_installer_integration_tests/test_main.py b/certbot-ci/windows_installer_integration_tests/test_main.py
index ab08d07f8..d2258b027 100644
--- a/certbot-ci/windows_installer_integration_tests/test_main.py
+++ b/certbot-ci/windows_installer_integration_tests/test_main.py
@@ -55,8 +55,8 @@ def github_mock(installer):
             pass
 
         class GitHubMock(BaseHTTPRequestHandler):
-            # def log_message(self, log_format, *args):
-            #     pass
+            def log_message(self, log_format, *args):
+                pass
 
             def do_GET(self):
                 if re.match(r'^.*/releases/latest$', self.path):
@@ -95,8 +95,8 @@ def github_mock(installer):
             server.server_close()
 
 
-@pytest.fixture(autouse=True)
-def registry_config(signing_cert, github_mock):
+@pytest.fixture
+def upgrade_env(signing_cert, github_mock):
     try:
         _ps('New-Item -Path HKLM:\\Software -Name Certbot -ErrorAction SilentlyContinue | Out-Null; exit 0')
         _ps('New-ItemProperty -Path HKLM:\\Software\\Certbot -Name CertbotUpgradeApiURL -Value {} '
@@ -105,62 +105,76 @@ def registry_config(signing_cert, github_mock):
             '([Convert]::ToBase64String((Get-PfxCertificate -FilePath {0}).GetPublicKey())) '
             '| Out-Null'.format(signing_cert))
 
-        yield
+        yield True
     finally:
         _ps('Remove-ItemProperty -Path HKLM:\\Software\\Certbot -Name CertbotUpgradeApiURL')
         _ps('Remove-ItemProperty -Path HKLM:\\Software\\Certbot -Name CertbotSigningPubKey')
 
 
 @unittest.skipIf(os.name != 'nt', reason='Windows installer tests must be run on Windows.')
-def test_it(installer):
+def test_base(installer):
+    _assert_certbot_is_broken()
+
+    # Install certbot
+    subprocess.check_output([installer, '/S'])
+
+    # Assert certbot is installed and runnable
+    output = subprocess.check_output('certbot --version', shell=True, universal_newlines=True)
+    assert re.match(r'^certbot \d+\.\d+\.\d+.*$', output), 'Flag --version does not output a version.'
+
+    # Assert the renew + auto-upgrade task is installed and ready
+    output = _ps('(Get-ScheduledTask -TaskName "{}").State'.format(SCHEDULED_TASK_NAME), capture_stdout=True)
+    assert output.strip() == 'Ready'
+
+    # Trigger the renew + auto-upgrade task, expecting Certbot to check for certificate renewals.
+    now = time.time()
+    _ps('Start-ScheduledTask -TaskName "{}"'.format(SCHEDULED_TASK_NAME))
+    _wait_for_task_completion()
+
+    log_path = os.path.join('C:\\', 'Certbot', 'log', 'letsencrypt.log')
+
+    modification_time = os.path.getmtime(log_path)
+    assert now < modification_time, 'Certbot log file has not been modified by the renew task.'
+
+    with open(log_path) as file_h:
+        data = file_h.read()
+    assert 'no renewal failures' in data, 'Renew task did not execute properly.'
+
+
+# NB: This test must sit after test_base, because it needs to have
+# a working installation of Certbot, and test_base does that.
+@unittest.skipIf(os.name != 'nt', reason='Windows installer tests must be run on Windows.')
+def test_upgrade(upgrade_env):
+    assert upgrade_env
+    subprocess.check_output(['certbot', '--version'])
+
+    # Break on purpose certbot
+    _ps('Remove-Item "${env:ProgramFiles(x86)}\\Certbot\\bin\\certbot.exe" -Confirm:$false')
+    _assert_certbot_is_broken()
+
+    # Trigger the renew + auto-upgrade task, expecting Certbot to be reinstalled and functional again.
+    now = time.time()
+    _ps('Start-ScheduledTask -TaskName "{}"'.format(SCHEDULED_TASK_NAME))
+    _wait_for_task_completion()
+
+    subprocess.check_output(['certbot', '--version'])
+
+
+def _assert_certbot_is_broken():
     try:
-        subprocess.check_call('certbot --version', shell=True)
+        subprocess.check_output(['certbot', '--version'])
     except (subprocess.CalledProcessError, OSError):
         pass
     else:
         raise AssertionError('Expect certbot to not be available in the PATH.')
 
-    try:
-        # Install certbot
-        subprocess.check_call([installer, '/S'])
 
-        # Assert certbot is installed and runnable
-        output = subprocess.check_output('certbot --version', shell=True, universal_newlines=True)
-        assert re.match(r'^certbot \d+\.\d+\.\d+.*$', output), 'Flag --version does not output a version.'
-
-        # Assert renew task is installed and ready
-        output = _ps('(Get-ScheduledTask -TaskName "{}").State'.format(SCHEDULED_TASK_NAME), capture_stdout=True)
-        assert output.strip() == 'Ready'
-
-        # Assert renew task is working
-        now = time.time()
-        _ps('Start-ScheduledTask -TaskName "{}"'.format(SCHEDULED_TASK_NAME))
-
-        status = 'Running'
-        while status != 'Ready':
-            status = _ps('(Get-ScheduledTask -TaskName "{}").State'
-                         .format(SCHEDULED_TASK_NAME), capture_stdout=True).strip()
-            time.sleep(1)
-
-        log_path = os.path.join('C:\\', 'Certbot', 'log', 'letsencrypt.log')
-
-        modification_time = os.path.getmtime(log_path)
-        assert now < modification_time, 'Certbot log file has not been modified by the renew task.'
-
-        with open(log_path) as file_h:
-            data = file_h.read()
-        assert 'no renewal failures' in data, 'Renew task did not execute properly.'
-
-    finally:
-        # Sadly this command cannot work in non interactive mode: uninstaller will ask explicitly permission in an UAC prompt
-        # print('Uninstalling Certbot ...')
-        # uninstall_path = _ps('(gci "HKLM:\\SOFTWARE\\Wow6432Node\\Microsoft\\Windows\\CurrentVersion\\Uninstall"'
-        #                      ' | foreach { gp $_.PSPath }'
-        #                      ' | ? { $_ -match "Certbot" }'
-        #                      ' | select UninstallString)'
-        #                      '.UninstallString', capture_stdout=True)
-        # subprocess.check_call([uninstall_path, '/S'])
-        pass
+def _wait_for_task_completion():
+    status = 'Running'
+    while status != 'Ready':
+        status = _ps('(Get-ScheduledTask -TaskName "{}").State'
+                     .format(SCHEDULED_TASK_NAME), capture_stdout=True).strip()
+        time.sleep(1)
 
 
 def _ps(powershell_str, capture_stdout=False):
diff --git a/windows-installer/auto-update.ps1 b/windows-installer/auto-update.ps1
index a47f8b13b..4df728cb0 100644
--- a/windows-installer/auto-update.ps1
+++ b/windows-installer/auto-update.ps1
@@ -112,11 +112,11 @@ Aborting auto-upgrade process.
             if (Test-Path $installDir\uninstall.exe) {
                 # Uninstall old Certbot first
                 Write-Message "Running the uninstaller for old version (install dir: $installDir) ..."
-                Start-Process -FilePath $installDir\uninstall.exe -ArgumentList "/S _?=$installDir"
+                Start-Process -FilePath $installDir\uninstall.exe -ArgumentList "/S" -Wait
             }
             # Install new version of Certbot
             Write-Message "Running the installer for new version (install dir: $installDir) ..."
-            Start-Process -FilePath $installerPath -ArgumentList "/S /D=$installDir"
+            Start-Process -FilePath $installerPath -ArgumentList "/S /D=$installDir" -Wait
 
             Write-Message "Certbot $latestVersion is installed."
         } catch {
diff --git a/windows-installer/tasks-up.ps1 b/windows-installer/tasks-up.ps1
index b669a7cc1..2d1ad54f5 100644
--- a/windows-installer/tasks-up.ps1
+++ b/windows-installer/tasks-up.ps1
@@ -11,7 +11,7 @@ $down = Join-Path (Get-ScriptDirectory) 'tasks-down.ps1'
 $taskName = "Certbot Renew & Auto-Update Task"
 $taskDescription = "Execute twice a day the 'certbot renew' command, to renew managed certificates if needed, and upgrade Certbot is a new version is available."
 
-$actionRenew = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument '-NoProfile -WindowStyle Hidden -Command "certbot renew"'
+$actionRenew = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument "-NoProfile -WindowStyle Hidden -Command ""& '$InstallDir\bin\certbot.exe' renew"""
 $actionUpgrade = New-ScheduledTaskAction -Execute 'Powershell.exe' -Argument "-NoProfile -WindowStyle Hidden -File ""$InstallDir\auto-update.ps1"""
 
 $delay = New-TimeSpan -Hours 12
diff --git a/windows-installer/template-nsi.patch b/windows-installer/template-nsi.patch
new file mode 100644
index 0000000000000000000000000000000000000000..fbff996512d338c97682d3ae49c0d625852c445b
GIT binary patch
literal 9628
zcmds-d2buX8OG<|7RYzl3Q3*DqGZ{!>!=7CMTad^7bMw95CsIS8<Hhe6eFiazIxl|
zH_wh|cezwZCjr`GL2{3o_r90^{#Pe(6k#UphwJcT=;`}fSC^q5&cg4)<M1ecI`Ov?
z=E4)Lp3|`q=EF06b3UWHkHT}^nbT^{A8FM?eb2@7kHYVD#bHdh;V8Tno(tjQd^~(l
z1s{A*wf=LR|2b0jWCXr1!<WJa#nX}Ihw<#W?(xJF{Y6)M;Z&UVb+#FH!<s%tq^U|@
zQLcC+di$dHP;0IvBUYa3x(IK=Kx-~^-O(>kc+L}FAzRC|uQi1zpAiQ$6*|_!vF<n5
znX-ZIpM)D>KaAL?wGzyJ+LUG?+4h7Fs-S?~hoz*U{48REx&wXsI(mZ5`hm`&_eAH3
zGuGYddK8CM9<~JMOuK>6lQarpLMl*kpgYLLG#yJm16@N861>r8A)em~^R?($2(vnX
z1tkORn-PpF@iwbFy>KqL15y1$+&$Zn+^p7LX!RSdwybA`4epS?SJ!PlTg0+f9Y+~u
z>Mdy?!UqzEa?aW<x>I7C5nZf05D&({cM-6>9YOiKcsPsPXNe;{s6>Lu?nY}5g*nNt
z`5a2_N;yH(p=87wtO<Smpbv0P^yx<`GH&kNhL!M6&kjV(t=3|>>$*m==rBXfwD0N}
zykn2YS~1W{uIseHx#2+zSEpL@sW4b;P={rrD{LflF&mb{7rJw-Cp}UAr$~49X}tQe
z4x-GQ;?T4rLiX$;{Gp@_dVstrX)lGBp(}r13@>zNDtxB{%SSg|(FUIHbxf5qYQk8H
z5rX~eI#vX+t2>KfL+1(JS+vu-6wqK-bo8W`qkA!I3+9$Me<fP?v}aAfTf&i{;{lfy
z7@bIKC)(3S<mOyBu$XMSx6yX6S?np>8U8m+sh``j@x2GK5NyEF!LaMQvX-%r&XDY1
zDW+OlbqRJQIrQ?k__Pqe#2-tmj-eYP+Kqgkr?$eP{Iw-6iAN$fafFC=6=iS{{t<V2
zM>};JlJ>f!y{6wp=SuiSG%e{4_t60Qeyz{C<nU5bJCV)UcgBZW=YAt<dPQ6>3+}2U
zVLG}I?~dfMBD{O=sTv;-9Icgh(X`<<Zb#9D?QKLIZHmTq!Q2#0<I^z;Zo0oLh&z&}
zJ<*=ym^|z&9r@}fTI<~9wdBgK{0%F`%h7wGs6pI#rtDg1$M?Siy{nSvX7otg0=W$P
z!qyIiyBqE9N;c7b?{$u|iRvTKcUaP1r3ouPkWUU`v??TP$I&xkv?sVSa_+FN7o{Ye
z-wxyx<ol}#;YRStCz*3+nvKfyB3ef?QroY|1q1OwC4!!bqfHv8L?!k`RwYlJmhm#h
z=6O|o)2hvg%ulpxTDqu4=Bgeq1f3cLI7b!fRp~bcmd0)L<^xHdY-l>VVOzfQLYCQ$
zHo6r322Vy(-$}adIEeJ-(G=aMqfywKaU)ZbY}~mb`Fd5RqhPLyj||5?LM+;oH|~UQ
zYkC<EMxtd^S|g6_egF*iZtAnE=m!^B+s`Z7{=7Wr>A1YEOM9Er->XuK#Df)C#7Wd#
zwy$LO*3-Dw4;3B3ckTuD$KjunZ#~bZEdG;hrtLYAe@DFA|9>hi{^3M$KUJinX6mVy
znFLEAy;GO1%8p$nnTMp+wrV6%Scv9R`O2LrcTKrm(f}-?CGzFDwN=&ZGx_keYAe@R
zPu1NuJ-N{SOx0}6xKoOS=h9tY{p4qg5TBK@VlC7l0rRshNw^+_pTv#rJyl@V9y_U*
zN7Xm<5>!0bf_@`yrz)Zu<1(~eVZM=1Q8A#4wz!)l<|;fz&_cTg+Dq)e6qFRFi?ZW=
z5+zAT?IX!&D^f>I{&8G6%=3P<yj+7MiCDk&S_%D9EoY9vmT)aew^uQu8e4spb&%FB
ziU(vtM#aj=qV|%6-x`^mx|h=Fa;$AOOFE&$QgOts`Y>50_dL}+TFnLQ#uDnf$+d3k
zZdhj=$u{UyfDfKruTE<neKox(mcY~M9lE@BT2lOD`Y|8<gnHwlx)5Sub;@9l`L6oj
zc9c05gtV;_Q%CP@YTWJ8%TqmcVmx#=Lr+BYPUnKn_vL9E$!`))WSV-r1$ETvd`}#&
z>jSO_F-v;#fIre-6tTl#da@!2?e@?W4OCoAa@@alMd2`ARB2c%xwsumn=eq+U25Nh
zN@U7j^;`MxqU3xiZTu*{Qhf52XDoG3Ldsa9chNUdm5{sllqIoB$0hpe95HeqH4N>y
z)mK0AWlpGB9e<fnSVO(YeeS~A^<LLZ)(O&hA&#-FBoq9nF3md6KPT^nMuZzz;*Qx_
z(y1Cxe!=g5gRCc$u%$IDQ%i~2s*iDOvRy(M#{Y_R%<<?7e)#!)S*IRxiF~PBGaRfp
zNB;R3>*;QoK|PKY67%jNu3@creH~*xe#gY`M0w!rSj#W#IrTKP{Wm%%4_ql~+$ys(
zmpW1nwV^oZeutR`&-S&O*vLfiPH}3#QIWjXJ~D#mZu_cGno}O<^3gRg(R#m(yXN5M
zzNb_PUq$YSD$Fy1F;|J*wk#|&<serZWCYitaCxRHGNL0XcaCC|VuD9*;+KB$Mptiy
zk+rVGJfr@juE{{`rw+_>Z}yX~&Ld5xX7YUeVVL`6o<0;sRPfAe6E)7*rsqDNBjfc1
z=UjUqh%a<+JtGy*_59}HI`Z$_L+yZ!F16m30~x(J>)qB<cgeg1z($!TV6VH<$VuD@
z&7JoZW_#R9JoQW2lUe$*0&JnvsM(mYQ?n1}{*?0{RxA*^S&I6%1Uv;o0`PXE!!jlF
zU=P>^9AqC{lkdP;da@d873v@S75TL9!}2$@&u>YXpns*c@8aFBR2zOPdG5;kw{&Mp
znZJ&oiW2JvcAoTST95S{@1zUM7S6p~3+HNeMr)RZy->cUV)eW{?QQaIuI|ELqx|j9
zId-|9qk47p;>{i1-n_0^Wyw*OGU0M8p({TupR_$k0>ja!YT=XlKT^XIc~_97^Gp4o
zn%}X6I+wlxpTyefhI15h&G7%{na&%R>K2lBy2j2iG0S7vJNG3i$5Fg|7#4Q%A&`jG
znW9Ocw8#4<EZZyI>|TplaH5I+nSOb@Np~`Os+?zq83L0PN8Z<x2-5^&EOzux-{c{p
zGI(7h6M<6KO$_#%$Wh%DQ>aO10Yow8tr_3=l-B!`Is|g${q`^!rPhPLp|B3WIS1NT
zlxtQmGf~1vWgHrY(Pp!4Grja~EzQbOY<#RJ_*Aiwe?A~ne$#&la%2QAN9Kg9Y8_gw
zGl^oJN~JfSywR#=m3pnY8u@OEyy<;ka|LgqvA?w_FK0g6-Tm|P<^-Fm&zkB{TR{^`
z&H$t7Kx4lSExdJ^lpbr~L*EiL`JLoV5Bev+?Ui-vTj`K@;%BAisdlKxnAwowsoto!
zh@n`*rRqB3#<|X@?uZ~%D^#;7W3d|Ej^l1mAelHY!Seq@-fAsX1wLEtdZCP(@FHeB
zXi3uv-jsEOiMMFr<o`de26N@Xe2F=9^{st1C)X<$Qwa{kWJYu=2(~HY^h@S9i=yu0
z{oED5Nq(B)S8*`iU=CWJXS(uq5A;HnA#d^X`w?W~E@_hYrF9G`u241O6YbtyjTpAt
H)N%d?prp!n

literal 0
HcmV?d00001

diff --git a/windows-installer/template.nsi b/windows-installer/template.nsi
index 024346f71..822e3282a 100644
--- a/windows-installer/template.nsi
+++ b/windows-installer/template.nsi
@@ -1,7 +1,12 @@
-; This NSIS template is based on the built-in one in pynsist 2.3.
-; Added lines are enclosed within "CERTBOT CUSTOM BEGIN/END" comments.
-; If pynsist is upgraded, this template must be updated if necessary using the new built-in one.
+; This NSIS template is based on the built-in one in pynsist 2.4.
+; If pynsist is upgraded, this template may be updated if necessary using the new built-in one.
 ; Original file can be found here: https://github.com/takluyver/pynsist/blob/2.4/nsist/pyapp.nsi
+; Diff file is located at .\template-nsi.patch
+
+; Require the installer do be installed with admin privileges
+RequestExecutionLevel admin
+; Set default installation path (overridable with /D= flag)
+InstallDir "$PROGRAMFILES\Certbot"
 
 !define PRODUCT_NAME "[[ib.appname]]"
 !define PRODUCT_VERSION "[[ib.version]]"
@@ -11,31 +16,9 @@
 !define ARCH_TAG "[[arch_tag]]"
 !define INSTALLER_NAME "[[ib.installer_name]]"
 !define PRODUCT_ICON "[[icon]]"
-
-; Marker file to tell the uninstaller that it's a user installation
-!define USER_INSTALL_MARKER _user_install_marker
  
 SetCompressor lzma
 
-; CERTBOT CUSTOM BEGIN
-; Administrator privileges are required to insert a new task in Windows Scheduler.
-; Also comment out some options to disable ability to choose AllUsers/CurrentUser install mode.
-; As a result, installer run always with admin privileges (because of MULTIUSER_EXECUTIONLEVEL),
-; using the AllUsers installation mode by default (because of MULTIUSER_INSTALLMODE_DEFAULT_CURRENTUSER
-; not set), and this default behavior cannot be overridden (because of MULTIUSER_MUI not set).
-; See https://nsis.sourceforge.io/Docs/MultiUser/Readme.html
-!define MULTIUSER_EXECUTIONLEVEL Admin
-;!define MULTIUSER_EXECUTIONLEVEL Highest
-;!define MULTIUSER_INSTALLMODE_DEFAULT_CURRENTUSER
-;!define MULTIUSER_MUI
-;!define MULTIUSER_INSTALLMODE_COMMANDLINE
-; CERTBOT CUSTOM END
-!define MULTIUSER_INSTALLMODE_INSTDIR "[[ib.appname]]"
-[% if ib.py_bitness == 64 %]
-!define MULTIUSER_INSTALLMODE_FUNCTION correct_prog_files
-[% endif %]
-!include MultiUser.nsh
-
 [% block modernui %]
 ; Modern UI installer stuff 
 !include "MUI2.nsh"
@@ -49,10 +32,6 @@ SetCompressor lzma
 [% if license_file %]
 !insertmacro MUI_PAGE_LICENSE [[license_file]]
 [% endif %]
-; CERTBOT CUSTOM BEGIN
-; Disable the installation mode page (AllUsers/CurrentUser)
-;!insertmacro MULTIUSER_PAGE_INSTALLMODE
-; CERTBOT CUSTOM END
 !insertmacro MUI_PAGE_DIRECTORY
 !insertmacro MUI_PAGE_INSTFILES
 !insertmacro MUI_PAGE_FINISH
@@ -60,10 +39,7 @@ SetCompressor lzma
 !insertmacro MUI_LANGUAGE "English"
 [% endblock modernui %]
 
-; CERTBOT CUSTOM BEGIN
 Name "${PRODUCT_NAME} (beta) ${PRODUCT_VERSION}"
-;Name "${PRODUCT_NAME} ${PRODUCT_VERSION}"
-; CERTBOT CUSTOM END
 OutFile "${INSTALLER_NAME}"
 ShowInstDetails show
 
@@ -76,18 +52,13 @@ SectionEnd
 
 Section "!${PRODUCT_NAME}" sec_app
   SetRegView [[ib.py_bitness]]
+  SetShellVarContext all
   SectionIn RO
   File ${PRODUCT_ICON}
   SetOutPath "$INSTDIR\pkgs"
   File /r "pkgs\*.*"
   SetOutPath "$INSTDIR"
 
-  ; Marker file for per-user install
-  StrCmp $MultiUser.InstallMode CurrentUser 0 +3
-    FileOpen $0 "$INSTDIR\${USER_INSTALL_MARKER}" w
-    FileClose $0
-    SetFileAttributes "$INSTDIR\${USER_INSTALL_MARKER}" HIDDEN
-
   [% block install_files %]
   ; Install files
   [% for destination, group in grouped_files %]
@@ -129,14 +100,8 @@ Section "!${PRODUCT_NAME}" sec_app
     DetailPrint "Setting up command-line launchers..."
     nsExec::ExecToLog '[[ python ]] -Es "$INSTDIR\_assemble_launchers.py" [[ python ]] "$INSTDIR\bin"'
 
-    StrCmp $MultiUser.InstallMode CurrentUser 0 AddSysPathSystem
-      ; Add to PATH for current user
-      nsExec::ExecToLog '[[ python ]] -Es "$INSTDIR\_system_path.py" add_user "$INSTDIR\bin"'
-      GoTo AddedSysPath
-    AddSysPathSystem:
-      ; Add to PATH for all users
-      nsExec::ExecToLog '[[ python ]] -Es "$INSTDIR\_system_path.py" add "$INSTDIR\bin"'
-    AddedSysPath:
+    ; Add to PATH for all users
+    nsExec::ExecToLog '[[ python ]] -Es "$INSTDIR\_system_path.py" add "$INSTDIR\bin"'
   [% endif %]
   [% endblock install_commands %]
   
@@ -164,11 +129,9 @@ Section "!${PRODUCT_NAME}" sec_app
   WriteRegDWORD SHCTX "Software\Microsoft\Windows\CurrentVersion\Uninstall\${PRODUCT_NAME}" \
                    "NoRepair" 1
 
-  ; CERTBOT CUSTOM BEGIN
   ; Execute ps script to create the certbot renew & auto-update task
   DetailPrint "Setting up certbot renew & auto-update scheduled task"
   nsExec::ExecToStack 'powershell -inputformat none -ExecutionPolicy RemoteSigned -File "$INSTDIR\tasks-up.ps1" -InstallDir "$INSTDIR"'
-  ; CERTBOT CUSTOM END
 
   ; Check if we need to reboot
   IfRebootFlag 0 noreboot
@@ -179,21 +142,16 @@ Section "!${PRODUCT_NAME}" sec_app
 SectionEnd
 
 Section "Uninstall"
-  ; CERTBOT CUSTOM BEGIN
+  SetRegView [[ib.py_bitness]]
+  SetShellVarContext all
+
   ; Execute ps script to remove the certbot renew & auto-update task, then delete scripts
   nsExec::ExecToStack 'powershell -inputformat none -ExecutionPolicy RemoteSigned -File "$INSTDIR\tasks-down.ps1"'
   Delete "$INSTDIR\tasks-down.ps1"
   Delete "$INSTDIR\tasks-up.ps1"
   Delete "$INSTDIR\auto-update.ps1"
-  ; CERTBOT CUSTOM END
 
-  SetRegView [[ib.py_bitness]]
-  SetShellVarContext all
-  IfFileExists "$INSTDIR\${USER_INSTALL_MARKER}" 0 +3
-    SetShellVarContext current
-    Delete "$INSTDIR\${USER_INSTALL_MARKER}"
-
-  Delete $INSTDIR\uninstall.exe
+  Delete "$INSTDIR\uninstall.exe"
   Delete "$INSTDIR\${PRODUCT_ICON}"
   RMDir /r "$INSTDIR\pkgs"
 
@@ -244,20 +202,3 @@ Function .onMouseOverSection
     
     [% endblock mouseover_messages %]
 FunctionEnd
-
-Function .onInit
-  !insertmacro MULTIUSER_INIT
-FunctionEnd
-
-Function un.onInit
-  !insertmacro MULTIUSER_UNINIT
-FunctionEnd
-
-[% if ib.py_bitness == 64 %]
-Function correct_prog_files
-  ; The multiuser machinery doesn't know about the different Program files
-  ; folder for 64-bit applications. Override the install dir it set.
-  StrCmp $MultiUser.InstallMode AllUsers 0 +2
-    StrCpy $INSTDIR "$PROGRAMFILES64\${MULTIUSER_INSTALLMODE_INSTDIR}"
-FunctionEnd
-[% endif %]
\ No newline at end of file