From 20271105128ad59b73ada9878babfb9b0d99bb01 Mon Sep 17 00:00:00 2001 From: Seth Schoen Date: Mon, 1 Jun 2015 11:34:12 -0700 Subject: [PATCH] Add a single performance-related TODO comment --- letsencrypt/renewer.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/letsencrypt/renewer.py b/letsencrypt/renewer.py index d95fb7d95..6e61fd893 100644 --- a/letsencrypt/renewer.py +++ b/letsencrypt/renewer.py @@ -117,6 +117,14 @@ def main(config=None): rc_config = configobj.ConfigObj( os.path.join(config["renewal_configs_dir"], i)) try: + # TODO: Before trying to initialize the RenewableCert object, + # we could check here whether the combination of the config + # and the rc_config together disables all autorenewal and + # autodeployment applicable to this cert. In that case, we + # can simply continue and don't need to instantiate a + # RenewableCert object for this cert at all, which could + # dramatically improve performance for large deployments + # where autorenewal is widely turned off. cert = storage.RenewableCert(rc_config) except ValueError: # This indicates an invalid renewal configuration file, such