Address review comments:

- make --user-agent a general CLI option
 - get_os_info return type
This commit is contained in:
Peter Eckersley 2015-11-12 17:31:32 -08:00
parent 2a820a391f
commit 1bfd44ea34
2 changed files with 4 additions and 2 deletions

View file

@ -893,7 +893,7 @@ def _create_subparsers(helpful):
helpful.add_group("rollback", description="Options for reverting config changes")
helpful.add_group("plugins", description="Plugin options")
helpful.add(
"certonly", "--user-agent", type=str, default=None,
None, "--user-agent", type=str, default=None,
help="Set a custom user agent string for the client. User agent strings allow "
"the CA to collect high level statistics about success rates by OS and "
"plugin. If you wish to hide your server OS version from the Let's "

View file

@ -206,7 +206,9 @@ def safely_remove(path):
def get_os_info():
"""
Get Operating System type/distribution and major version
:returns: (`str` os_name, `str` os_version)
:returns: (os_name, os_version)
:rtype: `tuple` of `str`
"""
info = platform.system_alias(
platform.system(),