From 15904d24c0ed1b738b0103e7e45195269682a464 Mon Sep 17 00:00:00 2001 From: Scott Armitage Date: Sat, 7 Jul 2018 12:16:25 -0700 Subject: [PATCH] Fix detect defaults when nargs present If a plugin adds a command line argument with the `nargs` parameter, e.g. `nargs='+'`, this parameter gets filtered from the `HelpfulArgumentParser` created/used in default detection. As a result, this parser does not parse the command line in the expected way, instead using the default value for `nargs`. Leaving `nargs` in place resolves this issue. --- certbot/cli.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/certbot/cli.py b/certbot/cli.py index 5c4313ea4..2a4dda360 100644 --- a/certbot/cli.py +++ b/certbot/cli.py @@ -120,7 +120,7 @@ More detailed help: # These argparse parameters should be removed when detecting defaults. -ARGPARSE_PARAMS_TO_REMOVE = ("const", "nargs", "type",) +ARGPARSE_PARAMS_TO_REMOVE = ("const", "type",) # These sets are used when to help detect options set by the user.