certbot/certbot-compatibility-test/Dockerfile

FROM docker.io/python:3.8-buster
LABEL maintainer="Brad Warren <bmw@eff.org>"

# This does not include the dependencies needed to build cryptography. See
# https://cryptography.io/en/latest/installation/#building-cryptography-on-linux
RUN apt-get update && \
    apt install python3-venv libaugeas0 -y

WORKDIR /opt/certbot/src

# We copy all contents of the build directory to allow us to easily use
# things like tools/venv.py which expects all of our packages to be available.
COPY . .

RUN tools/venv.py
ENV PATH /opt/certbot/src/venv/bin:$PATH

# install in editable mode (-e) to save space: it's not possible to
# "rm -rf /opt/certbot/src" (it's stays in the underlying image);
# this might also help in debugging: you can "docker run --entrypoint
# bash" and investigate, apply patches, etc.

WORKDIR /opt/certbot/src/certbot-compatibility-test/certbot_compatibility_test/testdata
Drop Python 3.7 support (#9792) * Drop Python 3.7 support * Fix lint and test * Check for venv generation * Update requirements * Update oldest constaints and compatibility tests runtime 2023-10-13 09:57:42 -04:00			`FROM docker.io/python:3.8-buster`
			`LABEL maintainer="Brad Warren <bmw@eff.org>"`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00
Add some missing type libraries for mypy (#9657) * add some missing types * install pkg-config * install pkg-config for docker too * add pkg-config to plugins * pkg-config when cryptography may need to be built * deps cleanup * more comments * more tweaks 2023-04-08 21:49:08 -04:00			`# This does not include the dependencies needed to build cryptography. See`
			`# https://cryptography.io/en/latest/installation/#building-cryptography-on-linux`
Move compatibility tests off of certbot-auto and Python 2 (#8248) Fixes https://github.com/certbot/certbot/issues/8162. I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Dockerfiles work. The most complicated changes here are in `testdata`. You can find a diff of the changes to `nginx.tar.gz` at https://gist.github.com/c7727db0cecf3f15f02439f085c73848. The first problem was that there were some complaints from the new Apache/nginx/OpenSSL version about the 1024 bit RSA key so I updated `empty_cert.pem` both inside and outside of the tarball as well as the corresponding private key in the tarball to use a 2048 bit key. The 2nd problem is trickier to understand. If you look at the output from nginx after loading the config from `lots/` you'll see it complaining about conflicting `server_name` directives for the directives I deleted. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2578&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e&t=9baa2014-9673-5e78-8f4f-7a463caf2bfa&l=1516. After switching the tests to Python 3, tests on that domain started failing. What I believe to be happening is we were just lucky these tests were passing to begin with. In both the Apache and Nginx plugin, if there are conflicting virtual hosts like this, we just arbitrarily pick one. The relevant code here for nginx is https://github.com/certbot/certbot/blob/575092d6030330ed8379babaa4cbbfe43e7bf721/certbot-nginx/certbot_nginx/_internal/configurator.py#L455 I played around with a debugger and confirmed that before I removed the conflicting server names, there were two exact matches for the domain we were searching for here. I think all that's going on is with the switch to Python 3, the vhost we happen to choose changes and "breaks" the test. I suspect this to be due to something like getting values out of a dict somewhere where the order of items in a dict while iterating over it is different between Python 2 and 3. I didn't track where this difference happens down, but I personally don't think it's a good use of time since I think the real problem here is that the nginx config being tested was invalid with conflicting `server` blocks. I removed all references to the `server_name` causing conflicts in that nginx configuration because both server blocks had other domains that are being tested, but I could add either back if you prefer. You can see the `nginx_compat` test passing with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=2587&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e. * update Dockerfile * Fix apache_compat on py3. * Update empty_cert.pem. The command used here was `openssl req -key certbot/certbot/tests/testdata/rsa2048_key.pem -new -subj '/CN=example.com' -x509 > certbot-compatibility-test/certbot_compatibility_test/testdata/empty_cert.pem`. * update nginx.tar.gz * Remove conflicting server_names 2020-09-09 18:16:52 -04:00			`RUN apt-get update && \`
Add some missing type libraries for mypy (#9657) * add some missing types * install pkg-config * install pkg-config for docker too * add pkg-config to plugins * pkg-config when cryptography may need to be built * deps cleanup * more comments * more tweaks 2023-04-08 21:49:08 -04:00			`apt install python3-venv libaugeas0 -y`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00
Move compatibility tests off of certbot-auto and Python 2 (#8248) Fixes https://github.com/certbot/certbot/issues/8162. I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Dockerfiles work. The most complicated changes here are in `testdata`. You can find a diff of the changes to `nginx.tar.gz` at https://gist.github.com/c7727db0cecf3f15f02439f085c73848. The first problem was that there were some complaints from the new Apache/nginx/OpenSSL version about the 1024 bit RSA key so I updated `empty_cert.pem` both inside and outside of the tarball as well as the corresponding private key in the tarball to use a 2048 bit key. The 2nd problem is trickier to understand. If you look at the output from nginx after loading the config from `lots/` you'll see it complaining about conflicting `server_name` directives for the directives I deleted. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2578&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e&t=9baa2014-9673-5e78-8f4f-7a463caf2bfa&l=1516. After switching the tests to Python 3, tests on that domain started failing. What I believe to be happening is we were just lucky these tests were passing to begin with. In both the Apache and Nginx plugin, if there are conflicting virtual hosts like this, we just arbitrarily pick one. The relevant code here for nginx is https://github.com/certbot/certbot/blob/575092d6030330ed8379babaa4cbbfe43e7bf721/certbot-nginx/certbot_nginx/_internal/configurator.py#L455 I played around with a debugger and confirmed that before I removed the conflicting server names, there were two exact matches for the domain we were searching for here. I think all that's going on is with the switch to Python 3, the vhost we happen to choose changes and "breaks" the test. I suspect this to be due to something like getting values out of a dict somewhere where the order of items in a dict while iterating over it is different between Python 2 and 3. I didn't track where this difference happens down, but I personally don't think it's a good use of time since I think the real problem here is that the nginx config being tested was invalid with conflicting `server` blocks. I removed all references to the `server_name` causing conflicts in that nginx configuration because both server blocks had other domains that are being tested, but I could add either back if you prefer. You can see the `nginx_compat` test passing with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=2587&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e. * update Dockerfile * Fix apache_compat on py3. * Update empty_cert.pem. The command used here was `openssl req -key certbot/certbot/tests/testdata/rsa2048_key.pem -new -subj '/CN=example.com' -x509 > certbot-compatibility-test/certbot_compatibility_test/testdata/empty_cert.pem`. * update nginx.tar.gz * Remove conflicting server_names 2020-09-09 18:16:52 -04:00			`WORKDIR /opt/certbot/src`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00
Move compatibility tests off of certbot-auto and Python 2 (#8248) Fixes https://github.com/certbot/certbot/issues/8162. I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Dockerfiles work. The most complicated changes here are in `testdata`. You can find a diff of the changes to `nginx.tar.gz` at https://gist.github.com/c7727db0cecf3f15f02439f085c73848. The first problem was that there were some complaints from the new Apache/nginx/OpenSSL version about the 1024 bit RSA key so I updated `empty_cert.pem` both inside and outside of the tarball as well as the corresponding private key in the tarball to use a 2048 bit key. The 2nd problem is trickier to understand. If you look at the output from nginx after loading the config from `lots/` you'll see it complaining about conflicting `server_name` directives for the directives I deleted. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2578&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e&t=9baa2014-9673-5e78-8f4f-7a463caf2bfa&l=1516. After switching the tests to Python 3, tests on that domain started failing. What I believe to be happening is we were just lucky these tests were passing to begin with. In both the Apache and Nginx plugin, if there are conflicting virtual hosts like this, we just arbitrarily pick one. The relevant code here for nginx is https://github.com/certbot/certbot/blob/575092d6030330ed8379babaa4cbbfe43e7bf721/certbot-nginx/certbot_nginx/_internal/configurator.py#L455 I played around with a debugger and confirmed that before I removed the conflicting server names, there were two exact matches for the domain we were searching for here. I think all that's going on is with the switch to Python 3, the vhost we happen to choose changes and "breaks" the test. I suspect this to be due to something like getting values out of a dict somewhere where the order of items in a dict while iterating over it is different between Python 2 and 3. I didn't track where this difference happens down, but I personally don't think it's a good use of time since I think the real problem here is that the nginx config being tested was invalid with conflicting `server` blocks. I removed all references to the `server_name` causing conflicts in that nginx configuration because both server blocks had other domains that are being tested, but I could add either back if you prefer. You can see the `nginx_compat` test passing with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=2587&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e. * update Dockerfile * Fix apache_compat on py3. * Update empty_cert.pem. The command used here was `openssl req -key certbot/certbot/tests/testdata/rsa2048_key.pem -new -subj '/CN=example.com' -x509 > certbot-compatibility-test/certbot_compatibility_test/testdata/empty_cert.pem`. * update nginx.tar.gz * Remove conflicting server_names 2020-09-09 18:16:52 -04:00			`# We copy all contents of the build directory to allow us to easily use`
Cleanup venv scripts (#8629) Fixes https://github.com/certbot/certbot/issues/8387. * update _venv_common.py * delete venv.py scripts * rename venv script * update relevant venv3 references * remove set_python_envvars 2021-02-03 15:03:09 -05:00			`# things like tools/venv.py which expects all of our packages to be available.`
Move compatibility tests off of certbot-auto and Python 2 (#8248) Fixes https://github.com/certbot/certbot/issues/8162. I had to update the base of the Dockerfile to get a new enough version of Python 3. I also simplified things a lot and removed a lot of the comments that were essentially just describing how Dockerfiles work. The most complicated changes here are in `testdata`. You can find a diff of the changes to `nginx.tar.gz` at https://gist.github.com/c7727db0cecf3f15f02439f085c73848. The first problem was that there were some complaints from the new Apache/nginx/OpenSSL version about the 1024 bit RSA key so I updated `empty_cert.pem` both inside and outside of the tarball as well as the corresponding private key in the tarball to use a 2048 bit key. The 2nd problem is trickier to understand. If you look at the output from nginx after loading the config from `lots/` you'll see it complaining about conflicting `server_name` directives for the directives I deleted. See https://dev.azure.com/certbot/certbot/_build/results?buildId=2578&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e&t=9baa2014-9673-5e78-8f4f-7a463caf2bfa&l=1516. After switching the tests to Python 3, tests on that domain started failing. What I believe to be happening is we were just lucky these tests were passing to begin with. In both the Apache and Nginx plugin, if there are conflicting virtual hosts like this, we just arbitrarily pick one. The relevant code here for nginx is https://github.com/certbot/certbot/blob/575092d6030330ed8379babaa4cbbfe43e7bf721/certbot-nginx/certbot_nginx/_internal/configurator.py#L455 I played around with a debugger and confirmed that before I removed the conflicting server names, there were two exact matches for the domain we were searching for here. I think all that's going on is with the switch to Python 3, the vhost we happen to choose changes and "breaks" the test. I suspect this to be due to something like getting values out of a dict somewhere where the order of items in a dict while iterating over it is different between Python 2 and 3. I didn't track where this difference happens down, but I personally don't think it's a good use of time since I think the real problem here is that the nginx config being tested was invalid with conflicting `server` blocks. I removed all references to the `server_name` causing conflicts in that nginx configuration because both server blocks had other domains that are being tested, but I could add either back if you prefer. You can see the `nginx_compat` test passing with these changes at https://dev.azure.com/certbot/certbot/_build/results?buildId=2587&view=logs&j=250aa146-b243-5f8f-bf86-17a529c9fb7e. * update Dockerfile * Fix apache_compat on py3. * Update empty_cert.pem. The command used here was `openssl req -key certbot/certbot/tests/testdata/rsa2048_key.pem -new -subj '/CN=example.com' -x509 > certbot-compatibility-test/certbot_compatibility_test/testdata/empty_cert.pem`. * update nginx.tar.gz * Remove conflicting server_names 2020-09-09 18:16:52 -04:00			`COPY . .`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00
Cleanup venv scripts (#8629) Fixes https://github.com/certbot/certbot/issues/8387. * update _venv_common.py * delete venv.py scripts * rename venv script * update relevant venv3 references * remove set_python_envvars 2021-02-03 15:03:09 -05:00			`RUN tools/venv.py`
			`ENV PATH /opt/certbot/src/venv/bin:$PATH`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00
			`# install in editable mode (-e) to save space: it's not possible to`
Fix some typos (found by codespell) (#9017) * Fix some typos (found by codespell) Signed-off-by: Stefan Weil <sw@weilnetz.de> * Remove typo fixes for some files which should not be modified Signed-off-by: Stefan Weil <sw@weilnetz.de> 2021-09-02 16:43:13 -04:00			`# "rm -rf /opt/certbot/src" (it's stays in the underlying image);`
Add certbot-compatibility-test Dockerfiles 2016-08-10 19:08:30 -04:00			`# this might also help in debugging: you can "docker run --entrypoint`
			`# bash" and investigate, apply patches, etc.`

Make testdata the CWD of compatibility test dockerfiles 2016-08-10 19:32:38 -04:00			`WORKDIR /opt/certbot/src/certbot-compatibility-test/certbot_compatibility_test/testdata`