Commit graph

1235 commits

Author SHA1 Message Date
Thomas Waldmann
c4ffbd2a17 prepare to support multiple chunkers 2019-02-13 04:24:14 +01:00
Thomas Waldmann
12a18b955e re-add the code that checks if we run under fakeroot, fixes #4291
code taken from 1.1-maint.

running as a user, with or without fakeroot does not have the test
fails in test_extract_capabilities any more.
2019-02-12 05:08:06 +01:00
TW
9041a315ba
Merge pull request #4349 from donnyward/master
Update bundled lz4 code to 1.8.3, fixes #4209
2019-02-12 02:43:12 +01:00
Thomas Waldmann
e878ca5189 test_mount_hardlinks: get rid of fakeroot-caused test fails, fixes #3389 2019-02-11 17:47:34 +01:00
Thomas Waldmann
672c2c99a7 security fix: configure FUSE with "default_permissions", fixes #3903
"default_permissions" is now enforced by borg by default to let the
kernel check uid/gid/mode based permissions.

"ignore_permissions" can be given to not enforce "default_permissions".

note: man mount.fuse explicitly tells about the security issue:

    default_permissions
	By  default FUSE doesn't check file access permissions, ...
	This option enables permission checking, restricting access
	based on file mode.
	This option is usually useful together with the allow_other
	mount option.

We consider this a pitfall waiting for someone to fall into and this is
why we chose to change the default behaviour for borg.
2019-02-11 13:01:24 +01:00
Donny Ward
af449cdd1f Update bundled lz4 code to 1.8.3, fixes #4209 2019-02-10 20:36:29 -08:00
Thomas Waldmann
a9d562de17 work around some Microsoft WSL issues
see there:

https://github.com/borgbackup/borg/issues/1961

and especially there (not implemented sync_file_range):

https://github.com/Microsoft/WSL/issues/645
2019-02-05 15:15:50 +01:00
Thomas Waldmann
4fc23f532e work around the backslash issue, see #4280
thanks to AJ Jordan @strugee for finding this.

while using \\ gives a single backslash when using "borg help pattern"
on the shell, our rendered html docs did not show the single backslash
at all.

i was lazy do dig into that issue, so i just used the word "backslash".

:-)
2019-02-05 15:08:11 +01:00
TW
9a3fbdd751
Merge pull request #4316 from ThomasWaldmann/init-make-parentdirs
borg init --make-parent-dirs parent1/parent2/repo_dir, fixes #4235
2019-02-05 04:49:22 +01:00
Thomas Waldmann
f479850652 add comment about msgpack >= 0.6.1 features for later 2019-02-05 03:08:19 +01:00
Thomas Waldmann
940e107add cleanup msgpack requirements
we do not expect 0.5.x with x > 6 any more.

also remove outdated comments from setup.py.
2019-02-05 02:37:22 +01:00
Thomas Waldmann
0ebfaa5b61 allow msgpack 0.6.1, fixes #4308 2019-02-05 02:32:36 +01:00
Thomas Waldmann
600e798201 borg init --make-parent-dirs parent1/parent2/repo_dir, fixes #4235 2019-02-04 17:12:11 +01:00
TW
b204201fb5
Merge pull request #4302 from ThomasWaldmann/repair-output
add archive name to check --repair output, fixes #3447
2019-02-04 03:29:58 +01:00
TW
c3f40de606
cache_sync: compute size/count stats, borg info: consider part files (#4286)
cache_sync: compute size/count stats, borg info: consider part files

fixes #3522
2019-02-04 03:26:45 +01:00
TW
50666c3e44
Merge pull request #4315 from ThomasWaldmann/check-msgpack-master
check msgpack version, terminate for unsupported versions
2019-02-03 04:34:51 +01:00
TW
de288cd6b2
Merge pull request #4314 from ThomasWaldmann/fix-tests-master
fix duplicate test method name, fixes #4311
2019-02-03 04:10:15 +01:00
Thomas Waldmann
18c9feb7e3 check msgpack version, terminate for unsupported versions 2019-02-03 03:54:41 +01:00
Thomas Waldmann
f4e1ba5995 fix duplicate test method name, fixes #4311
thanks to Anthony Sottile for finding this!
2019-02-03 02:37:49 +01:00
TW
422d9cf170
Merge pull request #4275 from ThomasWaldmann/fix-empty-segment-crash-master
recover_segment: handle too small segment files correctly, see #4272
2019-02-02 00:06:44 +01:00
Thomas Waldmann
18b62f63a6 add archive name to check --repair output, fixes #3447
so it does not look like duplicated and also informs the user about
affected archives.
2019-02-01 23:30:45 +01:00
TW
266fb02b9d
Merge pull request #4276 from ThomasWaldmann/fix-short-hostname
make "hostname" short, even on misconfigured systems, fixes #4262
2019-02-01 11:10:03 +01:00
Manuel Riel
9ab0a095ab Add --rsh command line option to complement BORG_RSH env var. Fixes #… (#4290)
Add --rsh command line option to complement BORG_RSH env var. Fixes #1701
2019-01-31 13:54:17 +01:00
Manu
c3a882b509 Use f_frsize instead of f_bsize to calculate free space. Fixes #4289 2019-01-31 14:26:21 +08:00
Manu
e155822474 Quit with error message when no config key is provided. Fixes #4223 2019-01-30 11:31:53 +08:00
Thomas Waldmann
111c34f92e make "hostname" short, even on misconfigured systems, fixes #4262 2019-01-29 19:51:51 +01:00
Thomas Waldmann
2c94d5ba58 recover_segment: handle too small segment files correctly, see #4272
nothing left to recover there, but at least we must not crash in mmap().
2019-01-29 19:21:51 +01:00
TW
2bcff382cb
Merge pull request #4247 from ThomasWaldmann/memoryview-cm
correctly release memoryview
2019-01-29 15:53:47 +01:00
Thomas Waldmann
b4c68de128 avoid diaper pattern in configparser by opening files, fixes #4263
this will fail early with correct error msg / exception traceback
if a config file is not readable.
2019-01-27 03:28:11 +01:00
Thomas Waldmann
78361744ea keep "data" as is, use "d" for slices
so that the data.release() call is on the original memoryview and
also we can delete the last reference to a slice of it first.
2019-01-25 02:09:00 +01:00
Thomas Waldmann
2910d13055 use try/finally to ensure correct memoryview release
see #4243.
2019-01-25 02:09:00 +01:00
Thomas Waldmann
02f3daebbe use a contextmanager to ensure correct memoryview release
see #4243.
2019-01-25 02:09:00 +01:00
Thomas Waldmann
2a981ba8eb avoid breakage with msgpack 0.6.0+, keep old limits, fixes #4220
for the Unpacker class, our msgpack wrapper already enforced own
defaults (identical to msgpack < 0.6.0 defaults) - no problem there.

for the unpack and unpackb functions, this changeset enforces the
same defaults in the wrapper, overriding the msgpack 0.6.0+ new
defaults (which caused breakage as seen in #4220).
2019-01-05 22:54:35 +01:00
cornop
1dad7a39fd Clarify the necessity to separately backup key in repokey mode (#4237)
clarify the necessity to separately backup key in repokey mode
2019-01-05 14:46:24 +01:00
Thomas Waldmann
ca6a7d1500 on linux, symlinks can't have ACLs, see #4044
(cherry picked from commit ca1928c925)
2018-12-15 21:32:27 +01:00
Thomas Waldmann
2fe88c0efb remove deprecated option: --no-files-cache
replaced by: --files-cache=disabled
2018-12-11 23:55:29 +01:00
Thomas Waldmann
d6a82acbc1 remove deprecated option: --ignore-inode
replaced by: --files-cache (without "inode")
2018-12-11 22:55:33 +01:00
Thomas Waldmann
c87393cab7 remove deprecated option: --list-format
replaced by: --format
2018-12-11 22:42:48 +01:00
Thomas Waldmann
933e82a49c remove deprecated option: --keep-tag-files
replaced by: --keep-exclude-tags
2018-12-11 22:41:23 +01:00
Thomas Waldmann
7cd1b8151e remove deprecated command: borg change-passphrase
replaced by: borg key change-passphrase
2018-12-11 22:36:39 +01:00
Thomas Waldmann
2be5446098 Revert "drop support for python 3.5, fixes #3919"
This reverts commit 55314f807e.
2018-12-11 00:53:43 +01:00
Thomas Waldmann
65d8091245 invalid locations: give err msg containing parsed location, fixes #4179 2018-11-28 01:04:28 +01:00
Thomas Waldmann
e9ac9beef0 list repo: add placeholders for hostname and username, fixes #4130
also: use a more generic get_meta() access method to avoid duplication.
2018-11-27 23:56:07 +01:00
Thomas Waldmann
3d05a4b114 xattrs: linux does not allow user.* xattrs on symlinks 2018-11-16 23:15:04 +01:00
Thomas Waldmann
53971e8e79 xattr key names must start with user. on linux
... or the call will just error with "operation not supported"
2018-11-16 23:15:04 +01:00
Thomas Waldmann
d0a01c532e pytest4 complains if we directly call the fixture function, fixes #4172
just added a normal function with the code, call it from fixture and
also from unittest test method.
2018-11-16 01:30:31 +01:00
ashmodei
f5bb776e77 Fixed wrong an archive's name pattern in CRUD benchmark help. 2018-11-12 17:01:47 +03:00
TW
b18122d596
Merge pull request #4164 from motwok/platform-refactor
remove posix issues and add fixups for unsupported methods. (ex. #4154)
2018-11-11 14:25:30 +01:00
Emmo Emminghaus
e5c22eac0d remove accidental change 2018-11-10 23:39:28 +01:00
Emmo Emminghaus
733a2bfa30 Introduce borg.platformflags.is_<os> 2018-11-10 23:34:43 +01:00