From ed1e5e9c13228ee71cea1e0f4417527902068e30 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sun, 31 May 2015 21:23:36 +0200 Subject: [PATCH] "create" micro optimization: do not check for sockets early they are rare, so it's pointless to check for them first. seen the stat..S_ISSOCK in profiling results with high call count. was no big issue, that call is cheap, but also no big issue to just fix the order. --- borg/archiver.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/borg/archiver.py b/borg/archiver.py index 4b13e47fd..438418abb 100644 --- a/borg/archiver.py +++ b/borg/archiver.py @@ -168,9 +168,6 @@ Type "Yes I am sure" if you understand this and want to continue.\n""") # Entering a new filesystem? if restrict_dev and st.st_dev != restrict_dev: return - # Ignore unix sockets - if stat.S_ISSOCK(st.st_mode): - return status = None if stat.S_ISREG(st.st_mode): try: @@ -196,6 +193,9 @@ Type "Yes I am sure" if you understand this and want to continue.\n""") status = archive.process_fifo(path, st) elif stat.S_ISCHR(st.st_mode) or stat.S_ISBLK(st.st_mode): status = archive.process_dev(path, st) + elif stat.S_ISSOCK(st.st_mode): + # Ignore unix sockets + return else: self.print_error('Unknown file type: %s', path) return