From a257edbe3a9480d09e1d27423d8f1ceac5897192 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Sat, 12 Feb 2022 20:36:57 +0100 Subject: [PATCH] compact: not "freeable", but "maybe freeable" e.g. if there is a ton of DELs in a segment, they all are maybe freeable, but only if we also got rid of the respective PUTs (see also #6289). --- src/borg/repository.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/borg/repository.py b/src/borg/repository.py index 45e321c0f..9797ab91b 100644 --- a/src/borg/repository.py +++ b/src/borg/repository.py @@ -756,13 +756,15 @@ class Repository: pi.show() continue segment_size = self.io.segment_size(segment) + freeable_ratio = 1.0 * freeable_space / segment_size if segment_size > 0.2 * self.max_segment_size and freeable_space < 0.15 * segment_size: - logger.debug('not compacting segment %d (only %d bytes are sparse)', segment, freeable_space) + logger.debug('not compacting segment %d (maybe freeable: %2.2f%% [%d bytes])', + segment, freeable_ratio * 100.0, freeable_space) pi.show() continue segments.setdefault(segment, 0) - logger.debug('compacting segment %d with usage count %d and %d freeable bytes', - segment, segments[segment], freeable_space) + logger.debug('compacting segment %d with usage count %d (maybe freeable: %2.2f%% [%d bytes])', + segment, segments[segment], freeable_ratio * 100.0, freeable_space) for tag, key, offset, data in self.io.iter_objects(segment, include_data=True): if tag == TAG_COMMIT: continue