From aba21ee185285cb9649243972829cec523d344a7 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Thu, 17 Apr 2025 15:41:31 +0200 Subject: [PATCH] freebsd: fix nfs4 acl processing, fixes #8756 This only happened when: - using borg extract --numeric-ids - processing NFS4 ACLs It didn't affect POSIX ACL processing. This is rather old code, so it looks like nobody used that code or the bug was not reported. The bug was discovered by PyCharm's "Junie" AI. \o/ --- src/borg/platform/freebsd.pyx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/borg/platform/freebsd.pyx b/src/borg/platform/freebsd.pyx index 430b5b6bb..f663eb2f2 100644 --- a/src/borg/platform/freebsd.pyx +++ b/src/borg/platform/freebsd.pyx @@ -199,7 +199,7 @@ cdef _nfs4_use_stored_uid_gid(acl): if entry: if entry.startswith('user:') or entry.startswith('group:'): fields = entry.split(':') - entries.append(':'.join(fields[0], fields[5], *fields[2:-1])) + entries.append(':'.join([fields[0], fields[5]] + fields[2:-1])) else: entries.append(entry) return safe_encode('\n'.join(entries))