From 8ddfd94f0904449175151faed67f9640710b6454 Mon Sep 17 00:00:00 2001 From: Thomas Waldmann Date: Fri, 4 Nov 2022 20:28:09 +0100 Subject: [PATCH] Fix test_size_on_disk_accurate on Windows Pass the python file object / fd instead of the file path. On Windows, a tempfile cannot be opened again, unlike on Unix systems. See https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile --- src/borg/testsuite/hashindex.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/borg/testsuite/hashindex.py b/src/borg/testsuite/hashindex.py index 89a793a97..fef6c5dd4 100644 --- a/src/borg/testsuite/hashindex.py +++ b/src/borg/testsuite/hashindex.py @@ -197,8 +197,8 @@ class HashIndexSizeTestCase(BaseTestCase): for i in range(1234): idx[H(i)] = i, i**2, i**3 with tempfile.NamedTemporaryFile() as file: - idx.write(file.name) - size = os.path.getsize(file.name) + idx.write(file) + size = os.path.getsize(file.fileno()) assert idx.size() == size