mirror of
https://github.com/isc-projects/bind9.git
synced 2026-05-23 02:28:55 -04:00
ed0ecb62e4
In the current statistics counter implementation, the statistics are backed by an array of counters, which are updated via atomic operations. This leads to contention, especially on high core count machines. This commit introduces a new isc_statsmulti_t counter that keeps a separate array per thread. These counters are then aggregated only when statistics are queried, shifting work off the critical path. These changes lead to a ~2% improvement in perflab.
77 lines
1.9 KiB
C
77 lines
1.9 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
/*! \file */
|
|
|
|
#include <isc/mem.h>
|
|
#include <isc/stats.h>
|
|
#include <isc/statsmulti.h>
|
|
#include <isc/util.h>
|
|
|
|
#include <ns/stats.h>
|
|
|
|
void
|
|
ns_stats_create(isc_mem_t *mctx, isc_statsmulti_t **statsp,
|
|
isc_stats_t **hwstatsp) {
|
|
REQUIRE(statsp != NULL && *statsp == NULL);
|
|
REQUIRE(hwstatsp != NULL && *hwstatsp == NULL);
|
|
|
|
isc_statsmulti_create(mctx, statsp, ns_statscounter_max);
|
|
isc_stats_create(mctx, hwstatsp, ns_highwater_max);
|
|
}
|
|
|
|
/*%
|
|
* Increment/Decrement methods
|
|
*/
|
|
void
|
|
ns_stats_increment(isc_statsmulti_t *stats, isc_statscounter_t counter) {
|
|
REQUIRE(stats != NULL);
|
|
|
|
isc_statsmulti_increment(stats, counter);
|
|
}
|
|
|
|
void
|
|
ns_stats_decrement(isc_statsmulti_t *stats, isc_statscounter_t counter) {
|
|
REQUIRE(stats != NULL);
|
|
|
|
isc_statsmulti_decrement(stats, counter);
|
|
}
|
|
|
|
void
|
|
ns_stats_update_if_greater(isc_stats_t *hwstats, isc_statscounter_t counter,
|
|
isc_statscounter_t value) {
|
|
REQUIRE(hwstats != NULL);
|
|
|
|
isc_stats_update_if_greater(hwstats, counter, value);
|
|
}
|
|
|
|
isc_statscounter_t
|
|
ns_stats_get_counter(isc_statsmulti_t *stats, isc_statscounter_t counter) {
|
|
REQUIRE(stats != NULL);
|
|
|
|
return isc_statsmulti_get_counter(stats, counter);
|
|
}
|
|
|
|
isc_statscounter_t
|
|
ns_stats_get_highwater(isc_stats_t *hwstats, isc_statscounter_t counter) {
|
|
REQUIRE(hwstats != NULL);
|
|
|
|
return isc_stats_get_counter(hwstats, counter);
|
|
}
|
|
|
|
void
|
|
ns_stats_reset_highwater(isc_stats_t *hwstats, isc_statscounter_t counter) {
|
|
REQUIRE(hwstats != NULL);
|
|
|
|
isc_stats_set(hwstats, 0, counter);
|
|
}
|