mirror of
https://github.com/isc-projects/bind9.git
synced 2026-07-14 04:30:48 -04:00
cd348cf255
Offloaded work used two different mechanisms: a per-loop isc_helper
thread for CPU-bound crypto (DNSSEC validation, message signature
checks) and the process-global libuv thread pool for blocking I/O (zone
load and dump, inbound transfer apply). Neither could cancel a queued
task, and the two disagreed about exclusive mode — the helper paused
with its loop under isc_loopmgr_pause() but the libuv pool did not, so
blocking offloaded work kept running while a loop held the exclusive
lock.
Unify both behind isc_work: each loop gets its own worker thread per
lane — FAST for short, bounded tasks and SLOW for long, blocking ones —
fed by a private queue. Separate lanes keep a short crypto task off the
path of a multi-second zone dump once both run on per-loop workers;
every lane parks with isc_loopmgr_pause() so exclusive mode now quiesces
offloaded work too; and a still-queued task can be canceled before it
starts (isc_work_cancel). isc_helper is removed and its callers select a
lane.
(cherry picked from commit a5f13b3410)
76 lines
1.7 KiB
C
76 lines
1.7 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
#include <inttypes.h>
|
|
#include <sched.h> /* IWYU pragma: keep */
|
|
#include <setjmp.h>
|
|
#include <stdarg.h>
|
|
#include <stddef.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#define UNIT_TESTING
|
|
#include <cmocka.h>
|
|
|
|
#include <isc/atomic.h>
|
|
#include <isc/loop.h>
|
|
#include <isc/os.h>
|
|
#include <isc/result.h>
|
|
#include <isc/tid.h>
|
|
#include <isc/util.h>
|
|
#include <isc/work.h>
|
|
|
|
#include "work.c"
|
|
|
|
#include <tests/isc.h>
|
|
|
|
static atomic_uint scheduled = 0;
|
|
|
|
static void
|
|
work_cb(void *arg) {
|
|
UNUSED(arg);
|
|
|
|
atomic_fetch_add(&scheduled, 1);
|
|
|
|
assert_int_equal(isc_tid(), UINT32_MAX);
|
|
}
|
|
|
|
static void
|
|
after_work_cb(void *arg ISC_ATTR_UNUSED, isc_result_t result ISC_ATTR_UNUSED) {
|
|
assert_int_equal(atomic_load(&scheduled), 1);
|
|
isc_loopmgr_shutdown(loopmgr);
|
|
}
|
|
|
|
static void
|
|
work_enqueue_cb(void *arg ISC_ATTR_UNUSED) {
|
|
isc_work_enqueue(isc_loop(), ISC_WORKLANE_FAST, work_cb, after_work_cb,
|
|
NULL);
|
|
}
|
|
|
|
ISC_RUN_TEST_IMPL(isc_work_enqueue) {
|
|
atomic_init(&scheduled, 0);
|
|
|
|
isc_loop_setup(isc_loop_main(loopmgr), work_enqueue_cb, loopmgr);
|
|
|
|
isc_loopmgr_run(loopmgr);
|
|
|
|
assert_int_equal(atomic_load(&scheduled), 1);
|
|
}
|
|
|
|
ISC_TEST_LIST_START
|
|
ISC_TEST_ENTRY_CUSTOM(isc_work_enqueue, setup_loopmgr, teardown_loopmgr)
|
|
ISC_TEST_LIST_END
|
|
|
|
ISC_TEST_MAIN
|