bind9/tests/dns/qpdb_test.c
Ondřej Surý 6fb070acc3
Add unit test for stale CNAME and other fresh data
Regression test for the find loop accepting a stale CNAME as a final
answer and stopping early even though a fresh record of the requested
type exists at the same node.

(cherry picked from commit b7144fb9cf)
2026-06-24 07:04:22 +02:00

370 lines
12 KiB
C

/*
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
*
* SPDX-License-Identifier: MPL-2.0
*
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
*
* See the COPYRIGHT file distributed with this work for additional
* information regarding copyright ownership.
*/
#include <inttypes.h>
#include <sched.h> /* IWYU pragma: keep */
#include <setjmp.h>
#include <stdarg.h>
#include <stddef.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#define UNIT_TESTING
#include <cmocka.h>
#include <isc/util.h>
#include <dns/rbt.h>
#include <dns/rdatalist.h>
#include <dns/rdataset.h>
#include <dns/rdatastruct.h>
#define KEEP_BEFORE
/* Include the main file */
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshadow"
#include "qpcache.c"
#pragma GCC diagnostic pop
#include <tests/dns.h>
/* Set to true (or use -v option) for verbose output */
static bool verbose = false;
/*
* Add to a cache DB 'db' an rdataset of type 'rtype' at a name
* <idx>.example.com. The rdataset would contain one data, and rdata_len is
* its length. 'rtype' is supposed to be some private type whose data can be
* arbitrary (and it doesn't matter in this test).
*/
static void
overmempurge_addrdataset(dns_db_t *db, isc_stdtime_t now, int idx,
dns_rdatatype_t rtype, size_t rdata_len,
bool longname) {
isc_result_t result;
dns_rdata_t rdata;
dns_dbnode_t *node = NULL;
dns_rdatalist_t rdatalist;
dns_rdataset_t rdataset;
dns_fixedname_t fname;
dns_name_t *name;
char namebuf[DNS_NAME_FORMATSIZE];
unsigned char rdatabuf[65535] = { 0 }; /* large enough for any valid
RDATA */
REQUIRE(rdata_len <= sizeof(rdatabuf));
if (longname) {
/*
* Build a longest possible name (in wire format) that would
* result in a new rbt node with the long name data.
*/
snprintf(namebuf, sizeof(namebuf),
"%010d.%010dabcdef%010dabcdef%010dabcdef%010dabcde."
"%010dabcdef%010dabcdef%010dabcdef%010dabcde."
"%010dabcdef%010dabcdef%010dabcdef%010dabcde."
"%010dabcdef%010dabcdef%010dabcdef01.",
idx, idx, idx, idx, idx, idx, idx, idx, idx, idx, idx,
idx, idx, idx, idx, idx);
} else {
snprintf(namebuf, sizeof(namebuf), "%d.example.com.", idx);
}
dns_test_namefromstring(namebuf, &fname);
name = dns_fixedname_name(&fname);
result = dns_db_findnode(db, name, true, &node);
assert_int_equal(result, ISC_R_SUCCESS);
assert_non_null(node);
dns_rdata_init(&rdata);
rdata.length = rdata_len;
rdata.data = rdatabuf;
rdata.rdclass = dns_rdataclass_in;
rdata.type = rtype;
dns_rdatalist_init(&rdatalist);
rdatalist.rdclass = dns_rdataclass_in;
rdatalist.type = rtype;
rdatalist.ttl = 3600;
ISC_LIST_APPEND(rdatalist.rdata, &rdata, link);
dns_rdataset_init(&rdataset);
dns_rdatalist_tordataset(&rdatalist, &rdataset);
result = dns_db_addrdataset(db, node, NULL, now, &rdataset, 0, NULL);
assert_int_equal(result, ISC_R_SUCCESS);
dns_db_detachnode(db, &node);
}
/*
* Add to cache DB 'db' an rdataset of type 'rtype' at 'name', with the single
* rdata parsed from the text 'rdatastr'. The rdataset is given TTL 'ttl'
* relative to 'now', so passing a 'now' in the past makes the entry expired
* (and, with serve-stale enabled, stale).
*/
static void
servestale_addrdataset(dns_db_t *db, const dns_name_t *name, isc_stdtime_t now,
dns_rdatatype_t rtype, const char *rdatastr,
dns_ttl_t ttl, dns_trust_t trust) {
isc_result_t result;
dns_rdata_t rdata;
dns_dbnode_t *node = NULL;
dns_rdatalist_t rdatalist;
dns_rdataset_t rdataset;
unsigned char rdatabuf[1024];
dns_rdata_init(&rdata);
result = dns_test_rdatafromstring(&rdata, dns_rdataclass_in, rtype,
rdatabuf, sizeof(rdatabuf), rdatastr,
false);
assert_int_equal(result, ISC_R_SUCCESS);
dns_rdatalist_init(&rdatalist);
rdatalist.rdclass = dns_rdataclass_in;
rdatalist.type = rtype;
rdatalist.ttl = ttl;
ISC_LIST_APPEND(rdatalist.rdata, &rdata, link);
dns_rdataset_init(&rdataset);
dns_rdatalist_tordataset(&rdatalist, &rdataset);
rdataset.trust = trust;
result = dns_db_findnode(db, name, true, &node);
assert_true(result == ISC_R_SUCCESS || result == DNS_R_CNAME);
assert_non_null(node);
result = dns_db_addrdataset(db, node, NULL, now, &rdataset, 0, NULL);
assert_int_equal(result, ISC_R_SUCCESS);
dns_db_detachnode(db, &node);
}
/*
* Create a cache DB with serve-stale enabled and bind 'name' to a freshly
* initialized name pointing into 'fname'.
*/
static dns_db_t *
servestale_setup(isc_mem_t *dbmctx, dns_fixedname_t *fname,
dns_name_t **namep) {
isc_result_t result;
dns_db_t *db = NULL;
result = dns_db_create(dbmctx, CACHEDB_DEFAULT, dns_rootname,
dns_dbtype_cache, dns_rdataclass_in, 0, NULL,
&db);
assert_int_equal(result, ISC_R_SUCCESS);
/* Keep expired entries for a day as a last-resort fallback. */
dns_db_setservestalettl(db, 86400);
dns_test_namefromstring("example.com.", fname);
*namep = dns_fixedname_name(fname);
return db;
}
/*
* Regression test for the find loop accepting a stale CNAME as a final answer
* and stopping early even though a fresh record of the requested type exists
* at the same node.
*
* A stale CNAME that expired two hours ago (but is still inside the stale
* window) is added first and a fresh non-priority type is (HINFO) added last
* last, so the stale CNAME sits at the head of the node's type list and is
* visited first by the find loop. With serve-stale enabled, the search must
* skip the stale CNAME and return the fresh HINFO rather than the stale CNAME.
*/
ISC_LOOP_TEST_IMPL(servestale_fresh_over_stale_cname) {
isc_result_t result;
dns_db_t *db = NULL;
isc_mem_t *dbmctx = NULL;
isc_stdtime_t now = isc_stdtime_now();
dns_fixedname_t fname, ffound;
dns_name_t *name = NULL, *foundname = NULL;
dns_rdataset_t rdataset;
isc_mem_create(&dbmctx);
db = servestale_setup(dbmctx, &fname, &name);
servestale_addrdataset(db, name, now - 7200, dns_rdatatype_cname,
"target.example.com.", 3600, dns_trust_answer);
servestale_addrdataset(db, name, now, dns_rdatatype_hinfo,
"CRAY-1 NEXUS", 3600, dns_trust_answer);
foundname = dns_fixedname_initname(&ffound);
dns_rdataset_init(&rdataset);
result = dns_db_find(db, name, NULL, dns_rdatatype_hinfo,
DNS_DBFIND_STALEOK, now, NULL, foundname,
&rdataset, NULL);
assert_int_equal(result, ISC_R_SUCCESS);
assert_int_equal(rdataset.type, dns_rdatatype_hinfo);
assert_int_equal(rdataset.attributes & DNS_RDATASETATTR_STALE, 0);
dns_rdataset_disassociate(&rdataset);
dns_db_detach(&db);
isc_mem_detach(&dbmctx);
isc_loopmgr_shutdown(loopmgr);
}
/*
* Same regression, but for a stale record of the requested type masking a
* fresh CNAME. A fresh CNAME is added first and a stale A is added last; the
* stale A is visited first and must not short-circuit the search. The fresh
* CNAME has to win, returning DNS_R_CNAME instead of the stale A.
*/
ISC_LOOP_TEST_IMPL(servestale_fresh_cname_over_stale_type) {
isc_result_t result;
dns_db_t *db = NULL;
isc_mem_t *dbmctx = NULL;
isc_stdtime_t now = isc_stdtime_now();
dns_fixedname_t fname, ffound;
dns_name_t *name = NULL, *foundname = NULL;
dns_rdataset_t rdataset;
isc_mem_create(&dbmctx);
db = servestale_setup(dbmctx, &fname, &name);
servestale_addrdataset(db, name, now, dns_rdatatype_cname,
"target.example.com.", 3600, dns_trust_answer);
servestale_addrdataset(db, name, now - 7200, dns_rdatatype_a,
"10.53.0.1", 3600, dns_trust_answer);
foundname = dns_fixedname_initname(&ffound);
dns_rdataset_init(&rdataset);
result = dns_db_find(db, name, NULL, dns_rdatatype_a,
DNS_DBFIND_STALEOK, now, NULL, foundname,
&rdataset, NULL);
assert_int_equal(result, DNS_R_CNAME);
assert_int_equal(rdataset.type, dns_rdatatype_cname);
assert_int_equal(rdataset.attributes & DNS_RDATASETATTR_STALE, 0);
dns_rdataset_disassociate(&rdataset);
dns_db_detach(&db);
isc_mem_detach(&dbmctx);
isc_loopmgr_shutdown(loopmgr);
}
ISC_LOOP_TEST_IMPL(overmempurge_bigrdata) {
size_t maxcache = 2097152U; /* 2MB - same as DNS_CACHE_MINSIZE */
size_t hiwater = maxcache - (maxcache >> 3); /* borrowed from cache.c */
size_t lowater = maxcache - (maxcache >> 2); /* ditto */
isc_result_t result;
dns_db_t *db = NULL;
isc_mem_t *mctx2 = NULL;
isc_stdtime_t now = isc_stdtime_now();
size_t i;
isc_mem_create(&mctx2);
result = dns_db_create(mctx2, CACHEDB_DEFAULT, dns_rootname,
dns_dbtype_cache, dns_rdataclass_in, 0, NULL,
&db);
assert_int_equal(result, ISC_R_SUCCESS);
isc_mem_setwater(mctx2, hiwater, lowater);
/*
* Add cache entries with minimum size of data until 'overmem'
* condition is triggered.
* This should eventually happen, but we also limit the number of
* iteration to avoid an infinite loop in case something gets wrong.
*/
for (i = 0; !isc_mem_isovermem(mctx2) && i < (maxcache / 10); i++) {
overmempurge_addrdataset(db, now, i, 50053, 0, false);
}
/*
* Then try to add the same number of entries, each has very large data.
* 'overmem purge' should keep the total cache size from exceeding
* the 'hiwater' mark too much. So we should be able to assume the
* cache size doesn't reach the "max".
*/
while (i-- > 0) {
overmempurge_addrdataset(db, now, i, 50054,
DNS_RDATA_MAXLENGTH - 8, false);
if (verbose) {
print_message("# inuse: %zd max: %zd\n",
isc_mem_inuse(mctx2), maxcache);
}
assert_true(isc_mem_inuse(mctx2) < maxcache);
}
dns_db_detach(&db);
isc_mem_destroy(&mctx2);
isc_loopmgr_shutdown(loopmgr);
}
ISC_LOOP_TEST_IMPL(overmempurge_longname) {
size_t maxcache = 2097152U; /* 2MB - same as DNS_CACHE_MINSIZE */
size_t hiwater = maxcache - (maxcache >> 3); /* borrowed from cache.c */
size_t lowater = maxcache - (maxcache >> 2); /* ditto */
isc_result_t result;
dns_db_t *db = NULL;
isc_mem_t *mctx2 = NULL;
isc_stdtime_t now = isc_stdtime_now();
size_t i;
isc_mem_create(&mctx2);
result = dns_db_create(mctx2, CACHEDB_DEFAULT, dns_rootname,
dns_dbtype_cache, dns_rdataclass_in, 0, NULL,
&db);
assert_int_equal(result, ISC_R_SUCCESS);
isc_mem_setwater(mctx2, hiwater, lowater);
/*
* Add cache entries with minimum size of data until 'overmem'
* condition is triggered.
* This should eventually happen, but we also limit the number of
* iteration to avoid an infinite loop in case something gets wrong.
*/
for (i = 0; !isc_mem_isovermem(mctx2) && i < (maxcache / 10); i++) {
overmempurge_addrdataset(db, now, i, 50053, 0, false);
}
/*
* Then try to add the same number of entries, each has very long name.
* 'overmem purge' should keep the total cache size from not exceeding
* the 'hiwater' mark too much. So we should be able to assume the cache
* size doesn't reach the "max".
*/
while (i-- > 0) {
overmempurge_addrdataset(db, now, i, 50054, 0, true);
if (verbose) {
print_message("# inuse: %zd max: %zd\n",
isc_mem_inuse(mctx2), maxcache);
}
assert_true(isc_mem_inuse(mctx2) < maxcache);
}
dns_db_detach(&db);
isc_mem_destroy(&mctx2);
isc_loopmgr_shutdown(loopmgr);
}
ISC_TEST_LIST_START
ISC_TEST_ENTRY_CUSTOM(overmempurge_bigrdata, setup_managers, teardown_managers)
ISC_TEST_ENTRY_CUSTOM(overmempurge_longname, setup_managers, teardown_managers)
ISC_TEST_ENTRY_CUSTOM(servestale_fresh_over_stale_cname, setup_managers,
teardown_managers)
ISC_TEST_ENTRY_CUSTOM(servestale_fresh_cname_over_stale_type, setup_managers,
teardown_managers)
ISC_TEST_LIST_END
ISC_TEST_MAIN