mirror of
https://github.com/isc-projects/bind9.git
synced 2026-03-24 11:25:08 -04:00
bd4576b3ce
Completely remove the TKEY Mode 2 (Diffie-Hellman Exchanged Keying) from
BIND 9 (from named, named.conf and all the tools). The TKEY usage is
fringe at best and in all known cases, GSSAPI is being used as it should.
The draft-eastlake-dnsop-rfc2930bis-tkey specifies that:
4.2 Diffie-Hellman Exchanged Keying (Deprecated)
The use of this mode (#2) is NOT RECOMMENDED for the following two
reasons but the specification is still included in Appendix A in case
an implementation is needed for compatibility with old TKEY
implementations. See Section 4.6 on ECDH Exchanged Keying.
The mixing function used does not meet current cryptographic
standards because it uses MD5 [RFC6151].
RSA keys must be excessively long to achieve levels of security
required by current standards.
We might optionally implement Elliptic Curve Diffie-Hellman (ECDH) key
exchange mode 6 if the draft ever reaches the RFC status. Meanwhile the
insecure DH mode needs to be removed.
99 lines
2.5 KiB
C
99 lines
2.5 KiB
C
/*
|
|
* Copyright (C) Internet Systems Consortium, Inc. ("ISC")
|
|
*
|
|
* SPDX-License-Identifier: MPL-2.0
|
|
*
|
|
* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, you can obtain one at https://mozilla.org/MPL/2.0/.
|
|
*
|
|
* See the COPYRIGHT file distributed with this work for additional
|
|
* information regarding copyright ownership.
|
|
*/
|
|
|
|
/*! \file */
|
|
|
|
#include <inttypes.h>
|
|
|
|
#include <isc/buffer.h>
|
|
#include <isc/mem.h>
|
|
#include <isc/string.h>
|
|
|
|
#include <dns/fixedname.h>
|
|
#include <dns/keyvalues.h>
|
|
#include <dns/name.h>
|
|
#include <dns/tkey.h>
|
|
|
|
#include <dst/gssapi.h>
|
|
|
|
#include <isccfg/cfg.h>
|
|
|
|
#include <named/tkeyconf.h>
|
|
|
|
#define RETERR(x) \
|
|
do { \
|
|
result = (x); \
|
|
if (result != ISC_R_SUCCESS) \
|
|
goto failure; \
|
|
} while (0)
|
|
|
|
#include <named/log.h>
|
|
#define LOG(msg) \
|
|
isc_log_write(named_g_lctx, NAMED_LOGCATEGORY_GENERAL, \
|
|
NAMED_LOGMODULE_SERVER, ISC_LOG_ERROR, "%s", msg)
|
|
|
|
isc_result_t
|
|
named_tkeyctx_fromconfig(const cfg_obj_t *options, isc_mem_t *mctx,
|
|
dns_tkeyctx_t **tctxp) {
|
|
isc_result_t result;
|
|
dns_tkeyctx_t *tctx = NULL;
|
|
const char *s;
|
|
dns_fixedname_t fname;
|
|
dns_name_t *name;
|
|
isc_buffer_t b;
|
|
const cfg_obj_t *obj;
|
|
|
|
result = dns_tkeyctx_create(mctx, &tctx);
|
|
if (result != ISC_R_SUCCESS) {
|
|
return (result);
|
|
}
|
|
|
|
obj = NULL;
|
|
result = cfg_map_get(options, "tkey-domain", &obj);
|
|
if (result == ISC_R_SUCCESS) {
|
|
s = cfg_obj_asstring(obj);
|
|
isc_buffer_constinit(&b, s, strlen(s));
|
|
isc_buffer_add(&b, strlen(s));
|
|
name = dns_fixedname_initname(&fname);
|
|
RETERR(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
|
|
tctx->domain = isc_mem_get(mctx, sizeof(dns_name_t));
|
|
dns_name_init(tctx->domain, NULL);
|
|
dns_name_dup(name, mctx, tctx->domain);
|
|
}
|
|
|
|
obj = NULL;
|
|
result = cfg_map_get(options, "tkey-gssapi-credential", &obj);
|
|
if (result == ISC_R_SUCCESS) {
|
|
s = cfg_obj_asstring(obj);
|
|
|
|
isc_buffer_constinit(&b, s, strlen(s));
|
|
isc_buffer_add(&b, strlen(s));
|
|
name = dns_fixedname_initname(&fname);
|
|
RETERR(dns_name_fromtext(name, &b, dns_rootname, 0, NULL));
|
|
RETERR(dst_gssapi_acquirecred(name, false, &tctx->gsscred));
|
|
}
|
|
|
|
obj = NULL;
|
|
result = cfg_map_get(options, "tkey-gssapi-keytab", &obj);
|
|
if (result == ISC_R_SUCCESS) {
|
|
s = cfg_obj_asstring(obj);
|
|
tctx->gssapi_keytab = isc_mem_strdup(mctx, s);
|
|
}
|
|
|
|
*tctxp = tctx;
|
|
return (ISC_R_SUCCESS);
|
|
|
|
failure:
|
|
dns_tkeyctx_destroy(&tctx);
|
|
return (result);
|
|
}
|