mirror of
https://github.com/isc-projects/bind9.git
synced 2026-07-16 02:12:50 -04:00
72255dfc36
On a submit failure, client_send() nullifies sock->h2->connect.cstream
and frees the stream before returning the error. The error: label in
isc__nm_http_request() reloaded that pointer and dereferenced it
unconditionally, reading through a NULL stream. The function is only
used by the DoH unit tests -- production DoH client send goes through
isc__nm_http_send()/client_httpsend(), whose submit failure is reported
via the NULL-safe send callback -- so this is a latent defect in the
test helper rather than a reachable named crash.
Skip the read callback when the stream has already been detached and
let the caller report the failure from the error result it receives.
Assisted-by: Claude:claude-opus-4-8
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| http.c | ||
| netmgr-int.h | ||
| netmgr.c | ||
| proxystream.c | ||
| proxyudp.c | ||
| socket.c | ||
| streamdns.c | ||
| tcp.c | ||
| timer.c | ||
| tlsstream.c | ||
| udp.c | ||