bind9/lib/dns
Aram Sargsyan ef344cbd5e Fix a 'serverquota' counter calculation bug
The 'all_spilled' local variable in resolver.c:fctx_getaddresses()
is 'true' by default, and only becomes false when there is at least
one successfully found NS address. However, when a 'forward only;'
configuration is used, the code jumps over the part where it looks
for NS addresses and doesn't reset the 'all_spilled' to false, which
results in incorretly increased 'serverquota' statistics variable,
and also in invalid return error code from the function. The result
code error didn't make any differences, because all codes other than
'ISC_R_SUCCESS' or 'DNS_R_WAIT' were treated in the same way, and
the result code was never logged anywhere.

Set the default value of 'all_spilled' to 'false', and only make it
'true' before actually starting to look up NS addresses.

(cherry picked from commit e430ce7039)
2024-09-18 01:25:01 +00:00
..
include Update code formatting 2024-09-11 11:47:10 +02:00
rdata Use clang-format-19 to update formatting 2024-08-22 10:25:22 +02:00
.gitignore 4394. [func] Add rndc command "dnstap-reopen" to close and 2016-06-24 09:37:04 +10:00
acl.c Add isc_rwlock around dns_aclenv .localhost and .localnets member 2022-04-26 14:21:57 +02:00
adb.c Do not update find.result_v4 and find.result_v6 2024-07-31 05:52:18 +00:00
badcache.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
byaddr.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
cache.c Add a limit to the number of RR types for single name 2024-06-10 18:50:06 +02:00
callbacks.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
catz.c Reconfigure catz member zones during named reconfiguration 2024-08-09 08:52:25 +02:00
client.c make "max_restarts" a configurable value 2024-08-07 15:36:15 -07:00
clientinfo.c refactor dns_clientinfo_init(); use separate function to set ECS 2023-02-08 00:13:12 -08:00
compress.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
db.c Add a limit to the number of RR types for single name 2024-06-10 18:50:06 +02:00
dbiterator.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
diff.c Log what change generated a 'not exact' error 2023-12-20 02:47:42 +11:00
dispatch.c fix handling of TCP timeouts 2023-05-26 02:07:02 -07:00
dlz.c Remove use of the inline keyword used as suggestion to compiler 2022-03-25 08:42:18 +01:00
dns64.c Add isc_rwlock around dns_aclenv .localhost and .localnets member 2022-04-26 14:21:57 +02:00
dnsrps.c Add a limit to the number of RR types for single name 2024-06-10 18:50:06 +02:00
dnssec.c Fix CDS/CDNSKEY is published logging 2024-01-17 10:05:20 +01:00
dnstap.c dnstap query_message field was erroneously set with responses 2022-08-31 15:24:00 -07:00
dnstap.proto Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
ds.c Simplify way we tag unreachable code with only ISC_UNREACHABLE() 2022-03-25 08:42:16 +01:00
dst_api.c Optimize selecting the signing key 2024-02-01 21:47:29 +01:00
dst_internal.h Replace isc_fsaccess API with more secure file creation 2023-03-31 16:47:15 +02:00
dst_openssl.h Use autoconf check for BN_GENCB_new() 2022-03-02 10:49:47 +00:00
dst_parse.c Replace isc_fsaccess API with more secure file creation 2023-03-31 16:47:15 +02:00
dst_parse.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
dyndb.c remove isc_bind9 variable 2023-02-09 10:07:39 -08:00
ecs.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
fixedname.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
forward.c Use sizeof(*ptr) for allocating/freeing memory in forward.c 2023-01-11 13:42:09 +00:00
gen.c Use EXIT_SUCCESS and EXIT_FAILURE 2024-08-06 15:19:06 +02:00
geoip2.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
gssapi_link.c Remove a redundant variable-length array 2022-03-18 16:05:56 +00:00
gssapictx.c Remove use of the inline keyword used as suggestion to compiler 2022-03-25 08:42:18 +01:00
hmac_link.c Emit deprecated warning for K* file pairs 2023-06-29 10:52:48 +10:00
ipkeylist.c remove nonfunctional DSCP implementation 2023-01-09 14:23:26 -08:00
iptable.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
journal.c Extend dns_db_allrdatasets to control interation results 2022-12-07 23:59:36 +00:00
kasp.c Add signatures-jitter option 2024-04-18 15:00:07 +00:00
key.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
keydata.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
keymgr.c Fix algorithm rollover bug wrt keytag conflicts 2024-08-22 10:15:02 +00:00
keytable.c Handle dns_rdata_fromstruct failure dns_keytable_deletekey 2023-04-03 17:46:13 +02:00
log.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
lookup.c Remove use of the inline keyword used as suggestion to compiler 2022-03-25 08:42:18 +01:00
Makefile.am Update libdns_la_LIBADD rather than libdns_la_LDFLAGS 2022-07-13 10:46:37 +10:00
master.c Remove infinite loop on ISC_R_NOFILE 2024-05-07 01:06:14 +00:00
masterdump.c Fix yaml output 2024-08-01 03:48:12 +00:00
message.c Remove unnecessary operations 2024-08-02 06:43:03 +00:00
name.c Use hashtable when parsing a message 2024-01-05 11:50:23 +01:00
ncache.c Correctly set the value of covered in dns_ncache_current 2023-09-18 15:51:44 +10:00
nsec.c Extend dns_db_allrdatasets to control interation results 2022-12-07 23:59:36 +00:00
nsec3.c Don't delete the NSEC3PARAM immediately 2023-12-21 22:07:53 +11:00
nta.c Don't use reference counting in isc_timer unit 2023-01-18 22:39:26 +01:00
openssl_link.c Use EXIT_SUCCESS and EXIT_FAILURE 2024-08-06 15:19:06 +02:00
openssl_shim.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
openssl_shim.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
openssldh_link.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
opensslecdsa_link.c Check that buf is large enough 2023-09-01 14:06:27 +10:00
openssleddsa_link.c Fix openssleddsa_isprivate 2024-08-19 23:38:18 +00:00
opensslrsa_link.c Only declare 'engine' if it is used 2023-10-27 10:49:38 +11:00
order.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
peer.c remove nonfunctional DSCP implementation 2023-01-09 14:23:26 -08:00
private.c Update the source code formatting using clang-format-17 2023-10-18 09:02:57 +02:00
rbt.c Reduce lock contention during RBTDB tree pruning 2024-02-29 12:39:26 +01:00
rbtdb.c Return partial match when requested 2024-08-29 21:05:54 +00:00
rbtdb.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
rcode.c Update code formatting 2024-09-11 11:47:10 +02:00
rdata.c Properly reject zero length ALPN in commatxt_fromtext 2024-08-01 01:10:53 +00:00
rdatalist.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
rdatalist_p.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
rdataset.c Define DNS_RDATASET_INIT for static initialisation 2023-02-09 08:58:15 +11:00
rdatasetiter.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
rdataslab.c Add a limit to the number of RRs in RRSets 2024-06-10 18:50:03 +02:00
request.c Prevent passing NULL to dns_dispatch_resume() 2024-05-15 21:24:24 +02:00
resolver.c Fix a 'serverquota' counter calculation bug 2024-09-18 01:25:01 +00:00
result.c Refactor how we map isc_result_t <-> dns_rcode_t 2023-06-15 16:27:17 +02:00
rootns.c Suppress reporting upcoming changes in root hints 2023-11-03 03:43:49 +11:00
rpz.c Run RPZ and catalog zones tasks in exclusive mode 2023-07-06 10:44:03 +00:00
rriterator.c Extend dns_db_allrdatasets to control interation results 2022-12-07 23:59:36 +00:00
rrl.c Update sources to Clang 18 formatting 2024-04-23 12:48:56 +00:00
sdb.c Add a limit to the number of RR types for single name 2024-06-10 18:50:06 +02:00
sdlz.c Add a limit to the number of RR types for single name 2024-06-10 18:50:06 +02:00
soa.c Remove use of the inline keyword used as suggestion to compiler 2022-03-25 08:42:18 +01:00
ssu.c Add missing period to generated IPv4 6to4 name 2024-08-02 00:09:17 +00:00
ssu_external.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
stats.c Ineffective DbC protections 2023-12-06 09:01:05 +11:00
tests Move all the unit tests to /tests/<libname>/ 2022-05-31 12:06:00 +02:00
time.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
tkey.c Return REFUSED if GSSAPI is not configured 2023-07-29 05:46:32 +10:00
transport.c Rename "hostname" to "remote-hostname" within "tls" 2022-05-03 17:42:43 +03:00
tsec.c Simplify way we tag unreachable code with only ISC_UNREACHABLE() 2022-03-25 08:42:16 +01:00
tsig.c Address race in dns_tsigkey_find() 2024-01-05 11:19:58 +01:00
tsig_p.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
ttl.c Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
update.c If kasp is not used, use legacy signature jitter 2024-04-18 15:00:07 +00:00
validator.c apply max-recursion-queries quota to validator queries 2024-08-07 15:36:09 -07:00
view.c make "max_restarts" a configurable value 2024-08-07 15:36:15 -07:00
xfrin.c allow IXFR-to-AXFR fallback on DNS_R_TOOMANYRECORDS 2024-09-10 14:54:57 +02:00
zone.c Log rekey failure as error if too many records 2024-06-10 18:51:28 +02:00
zone_p.h Update the copyright information in all files in the repository 2022-01-11 09:05:02 +01:00
zonekey.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00
zoneverify.c Properly build the NSEC/NSEC3 type bit map 2024-05-16 01:53:39 +00:00
zt.c Update sources to Clang 15 formatting 2022-11-29 09:14:07 +01:00