bind9/cocci/return-void-from-void.spatch at main - upstream/bind9 - Forgejo: Beyond coding. We Forge.

upstream/bind9

mirror of https://github.com/isc-projects/bind9.git synced 2026-02-19 02:28:27 -05:00

Ondřej Surý 9dfa33050b Add semantic patch to find void f() { ... return ((void)g())); ... }

When a function returns void, it can be used as an argument to return in
function returning also void, e.g.:

void in(void) {
  return;
}

void out(void) {
  return (in());
}

while this is legal, it should be rewritten as:

void out(void) {
  in();
  return;
}

The semantic patch just find the occurrences, and they need to be fixed
by hand.

2019-12-06 13:42:18 +01:00

19 lines

145 B

Text

Raw Permalink Blame History

 @ rule1 @
 identifier f1;
 @@
 void f1(...)
 {
 ...
 }
 @ rule2 @
 identifier rule1.f1;
 identifier f2;
 @@
 void f2(...) {
 ...
 * return(f1(...));
 ...
 }