mirror of
https://github.com/isc-projects/bind9.git
synced 2026-05-21 01:15:23 -04:00
754595ea2d
Detection of implicit cast from a boolean into an int, or an isc_result_t into a boolean (either in an assignement or return position). If such pattern is found, a warning comment is added into the code (and the CI will fails) so the error can be spotted and manually fixed.
56 lines
1 KiB
Text
56 lines
1 KiB
Text
@bool_into_int_warning@
|
|
position p;
|
|
int i;
|
|
bool b;
|
|
@@
|
|
i = b@p;
|
|
|
|
@script:python@
|
|
p << bool_into_int_warning.p;
|
|
@@
|
|
report = coccilib.report.build_report(p[0], "WARNING: implicit bool->int cast on assignment")
|
|
sys.stderr.write(report)
|
|
|
|
|
|
|
|
@return_isc_result_t_into_bool_warning@
|
|
position p;
|
|
isc_result_t result;
|
|
identifier fn;
|
|
identifier literalresult =~ "ISC_R_.*|DNS_R_.*|DST_R_.*|ISCCC_R_.*";
|
|
@@
|
|
bool fn(...) {
|
|
<...
|
|
(
|
|
return result@p;
|
|
|
|
|
return literalresult@p;
|
|
)
|
|
...>
|
|
}
|
|
|
|
@script:python@
|
|
p << return_isc_result_t_into_bool_warning.p;
|
|
@@
|
|
report = coccilib.report.build_report(p[0], "WARNING: implicit isc_result_t->bool cast on return value")
|
|
sys.stderr.write(report)
|
|
|
|
|
|
|
|
@isc_result_t_into_bool_warning@
|
|
position p;
|
|
isc_result_t result;
|
|
identifier literalresult =~ "ISC_R_.*|DNS_R_.*|DST_R_.*|ISCCC_R_.*";
|
|
bool b;
|
|
@@
|
|
(
|
|
b = result@p;
|
|
|
|
|
b = literalresult@p;
|
|
)
|
|
|
|
@script:python@
|
|
p << isc_result_t_into_bool_warning.p;
|
|
@@
|
|
report = coccilib.report.build_report(p[0], "WARNING: implicit isc_result_t->bool cast on assignment")
|
|
sys.stderr.write(report)
|