Commit graph

3610 commits

Author SHA1 Message Date
Andreas Gustafsson
f405ffddc8 added missing requirements 2000-07-08 17:27:28 +00:00
James Brister
475c936d4c 314. [func] Inet controls named.conf statement can now have
any non-negative number of keys specified.
2000-07-07 23:11:48 +00:00
James Brister
b4124351ad typo in printing additional-data definition.. 2000-07-07 22:57:53 +00:00
David Lawrence
d20d22616b A socket result of ISC_R_SUCCESS can still possibly be posted even after
isc_socket_cancel() has been called.  resquery_senddone() has been fixed
to account for this (there was a race condition because of the faulty
assumption that only ISC_R_CANCELED would be returned after
isc_socket_cancel()).

The interaction of resquery_response() with the dispatcher now has to be
closely reviewed to make sure it does not have a similar problem with
a canceled query.  If the faulty assumption hadn't been faulty, it was
fine, but now I'm not so sure.
2000-07-07 19:43:14 +00:00
Brian Wellington
0308460880 Some of the lwres functions weren't calling lwres_conf_parse. 2000-07-07 19:43:10 +00:00
Brian Wellington
68aa880dd5 remove unnecessary calls to fcntl(). 2000-07-07 19:10:00 +00:00
Brian Wellington
d8c8722f28 313. [bug] When parsing resolv.conf, don't terminate on an
error.  Instead, parse as much as possible, but
                        still return an error if one was found.
2000-07-07 18:58:46 +00:00
Brian Wellington
03968c0f5e removed dead code 2000-07-07 18:28:58 +00:00
Brian Wellington
4b7167e96a 312. [bug] Increase the number of allowed elements in the
resolv.conf search path from 6 to 8.  If there
                        are more than this, ignore the remainder rather
                        than returning a failure in lwres_conf_parse.
2000-07-07 18:24:11 +00:00
Brian Wellington
a4b496f2ab 311. [bug] lwres_conf_parse failed when the first line of
resolv.conf was empty or a comment.
2000-07-07 18:16:46 +00:00
James Brister
524c8ea0dc typo in print statement. 2000-07-07 14:30:00 +00:00
James Brister
952e9025b0 310. [func] Changes to named.conf "controls" statement (inet
subtype only)

                          - support "keys" clause

                                controls {
                                   inet * port 1024
                                        allow { any; } keys { "foo"; }
                                }

                          - allow "port xxx" to be left out of statement,
                            in which case it defaults to omapi's default port
                            of 953.
2000-07-07 13:56:14 +00:00
Brian Wellington
25496cebad If trying to validate a key set that happens to be a security root, the
validation should only consist of checking that each key in the key set
is also in the list of security root keys.

Strangeness occurs when the key set is signed, since the key set is marked
as secure, but the sig set is not, since it wasn't used in the validation
process.  This means that a query for a key set at a security root will
have the AD bit set if the key set is unsigned and not if the key set is signed.
2000-07-07 00:44:01 +00:00
David Lawrence
3658cf5419 comment cleanup (missing "not", spaces where tabs should have been) 2000-07-07 00:25:47 +00:00
David Lawrence
9fb4b3f08a Do not return an exact match from dns_rbt_findnode() when the exact
match does not have associated data and DNS_RBTFIND_EMPTYDATA is not set.
Return DNS_R_PARTIALMATCH instead if there is a superdomain with
data, or ISC_R_NOTFOUND if no superdomain has data.

Make dns_rbt_findname() honor DNS_RBTFIND_EMPTYDATA, per the rbt.h
documentation that has been saying it will.  It didn't.
2000-07-06 23:54:45 +00:00
Brian Wellington
861df15904 The includes were in the wrong order, causing digital unix to fail. 2000-07-06 22:13:15 +00:00
Brian Wellington
23efeb1a58 Check LWRES_PLATFORM_HAVESALEN, not ISC_PLATFORM_HAVESALEN 2000-07-06 21:42:05 +00:00
Brian Wellington
23ce1c7cca Lots of the comments were wrong. 2000-07-06 20:05:13 +00:00
Brian Wellington
ca93ad9b9e If we're asking for a key and need to call dns_view_findzonecut(), set
the DNS_DB_NOEXACT flag.  This means that the resolver will start look for the
key at or above the parent zone, and will return the key set from the parent
zone if key sets are present in both the parent and child.
2000-07-06 02:33:43 +00:00
Andreas Gustafsson
b7b5dd0d10 treat all responses to AXFR requests as AXFR responses 2000-07-05 20:28:34 +00:00
Michael Graff
8681403c16 Shut up a gcc warning 2000-07-05 20:26:46 +00:00
Mark Andrews
8c1aa8573d 308. [bug] Treat a SOA record not at top of zone as an error
when loading a zone. (RT #154)
2000-07-04 04:28:44 +00:00
Mark Andrews
3cf456d58e zone_get_from_db() now does as much as is possible. 2000-07-04 04:21:38 +00:00
Mark Andrews
84cb41f729 new error code DNS_R_NOTZONETOP 2000-07-04 03:59:54 +00:00
David Lawrence
24675e8e13 In dns_dispatch_createtcp(), REQUIRE() that attributes not include
DNS_DISPATCHATTR_UDP, and document that requirement as well as the
existing requirement for needing DNS_DISPATCHATTR_TCP.

No need to pull up.
2000-07-04 01:48:13 +00:00
Brian Wellington
9e37579870 Check that zone->view is not NULL before checking that zone->view->adb is not
NULL.  It appears that zone maintenance can occur when the zone is shutting
down and the view pointer is NULL.  We don't want to do zone maintenance in
this case.
2000-07-04 01:32:40 +00:00
David Lawrence
c7c2522a32 query-replace-o in error message; no need to pull up since no code in 9.0.0
will use the function in which the error appears
2000-07-04 01:29:48 +00:00
David Lawrence
96ab25294b 307. [bug] When canceling a query, the resolver didn't check for
isc_socket_sendto() calls that did not yet have their
			completion events posted, so it could (rarely) end up
			destroying the query context and then want to use
			it again when the send event posted, triggering an
			assertion as it tried to cancel an already-canceled
			query.  (RT #77)

... so now the resolver counts the number of outstanding isc_socket_sendto()s
and only destroys the query context when there are no more.
2000-07-04 01:19:20 +00:00
Brian Wellington
e68de4a7db 306. [bug] Reading HMAC-MD5 private key files didn't work. 2000-07-03 23:27:45 +00:00
Andreas Gustafsson
b3e4ce3059 alternative fix to 303. [RT #157] 2000-07-03 22:42:36 +00:00
Andreas Gustafsson
d8560fb7ff [RT #155]
305. [bug]             When reloading the server with a config file
                        containing a syntax error, it could catch an
                        assertion failure trying to perform zone
                        maintenance on tentatively created zones whose
                        views were never fully configured and lacked
                        an address database.
2000-07-03 20:21:53 +00:00
Brian Wellington
e2894b0e50 304. [bug] If more than LWRES_CONFMAXNAMESERVERS servers
are listed in resolv.conf, silently ignore them
                        instead of returning failure.
2000-07-03 20:13:12 +00:00
Andreas Gustafsson
855bda3de3 new joint ISC/BSDI copyright message as requested by
Paul Borman <prb@bsdi.com>
2000-07-03 17:44:22 +00:00
Mark Andrews
845e0b5f96 303. [bug] add additional sanity checks to differentiate a AXFR
response vs a IXFR response. (RT #157)
2000-07-03 13:33:05 +00:00
David Lawrence
de8e189332 300. [bug] Using both <isc/net.h> and <lwres/net.h> didn't work
on platforms lacking IPv6 because each included their
			own ipv6 header file for the missing definitions.  Now
			each library's ipv6.h defines the wrapper symbol of
			the other (ISC_IPV6_H and LWRES_IPV6_H).
2000-07-01 01:41:54 +00:00
David Lawrence
641689bff4 note in the comment that isc_time_microdiff returns 0 if t1 < t2.
no need to pull up.
2000-06-30 22:40:32 +00:00
Brian Wellington
e405739af2 297. [bug] Specifying a key name that wasn't fully qualified
in certain parts of the config file could cause
                        an assertion.
2000-06-30 15:39:23 +00:00
Andreas Gustafsson
fe8d130967 make install didn't work when using separate build dir 2000-06-30 00:29:29 +00:00
Andreas Gustafsson
428b78e56d RT #153: when invoked with type==CNAME and a message
not constructed by dns_message_parse(), dns_message_findname() failed to
find anything due to checking for attribute bits set only by dns_message_parse().
This caused an infinite loop when constructing the response to an ANY query
at a CNAME in a secure zone.
2000-06-29 19:49:43 +00:00
Andreas Gustafsson
824068b85b cut-and-paste-o: dns_message_findname() tested for
dns_rdatatype_cname twice instead of cname+dname
2000-06-29 18:58:32 +00:00
Andreas Gustafsson
26be84cdfc spelling, grammar, and formatting; no functional change 2000-06-29 16:48:53 +00:00
Mark Andrews
b74e73c5b4 294. [bug] If we run out of space in while processing glue
when reading a master file and commit "current name"
			reverts to "name_current" instead of staying as
			"name_glue".
2000-06-29 15:55:19 +00:00
Michael Graff
2e0e781ba4 use the correct function name in debugging statements 2000-06-29 07:40:58 +00:00
Brian Wellington
089b7bf0a5 a missing #include "assert_p.h" caused a compile failure. 2000-06-28 22:57:42 +00:00
Brian Wellington
09aea877e7 An lwres context was being destroyed while still in use 2000-06-28 21:55:33 +00:00
Brian Wellington
f51647808f Using 0 as an error value tends to conflict with using 0 to represent
success.
2000-06-28 21:43:46 +00:00
Jim Reid
084d809e48 fixed some typos
removed references to ENI_ error codes because they're not
documented in RFC2133 and are defined in getnameinfo.c rather
than some include file anyway
2000-06-28 21:43:41 +00:00
David Lawrence
5eae30a019 in fact, ISC_LANG_BEGINDECLS and ISC_LANG_ENDDECLS are not needed at all since
rdatastructpre.h and rdatastructsuf.h already provide the wrapper.
(no need to pull up.)
2000-06-28 19:07:19 +00:00
David Lawrence
778d24f5ba do not include isc/lang.h; rdatastructpre.h already gets it.
no need to pull these changes up to the 9.0.0 branch.
2000-06-28 19:03:24 +00:00
Michael Graff
0cd1ba32c1 put edns0 restarts back to 3, and fix up a few trace messages to be standard ones -- lower case first letter. 2000-06-28 16:30:29 +00:00