Commit graph

492 commits

Author SHA1 Message Date
Mark Andrews
4b583f0193 only reset first in multi-line mode 2011-03-07 13:42:11 +00:00
Automatic Updater
0e27506ce3 update copyright notice 2011-03-05 23:52:31 +00:00
Evan Hunt
9a859983d7 3062. [func] Made several changes to enhance human readability
of DNSSEC data in dig output and in generated
			zone files:
			 - DNSKEY record comments are more verbose, no
			   longer used in multiline mode only
			 - multiline RRSIG records reformatted
			 - multiline output mode for NSEC3PARAM records
			 - "dig +norrcomments" suppresses DNSKEY comments
			 - "dig +split=X" breaks hex/base64 records into
			   fields of width X; "dig +nosplit" disables this.
			[RT #22820]
2011-03-05 19:39:07 +00:00
Francis Dupont
9fe8cca065 add URI support 2011-03-03 14:10:27 +00:00
Automatic Updater
9cee5bb028 update copyright notice 2011-01-13 04:59:26 +00:00
Mark Andrews
38b84a1fcf 3007. [bug] Named failed to preserve the case of domain names in
rdata which is no compressable when writing master
                        files.  [RT #22863]
2011-01-13 00:55:49 +00:00
Automatic Updater
a094c46640 update copyright notice 2010-12-23 23:47:08 +00:00
Mark Andrews
37dee1ff94 2999. [func] Add GOST support (RFC 5933). [RT #20639] 2010-12-23 04:08:00 +00:00
Automatic Updater
4b6dc226f7 update copyright notice 2009-12-04 22:06:37 +00:00
Mark Andrews
3d17a3ba61 2801. [func] Detect and report records that are different according
to DNSSEC but are sematically equal according to plain
                        DNS.  Apply plain DNS comparisons rather than DNSSEC
                        comparisons when processing UPDATE requests.
                        dnssec-signzone now removes such semantically duplicate
                        records prior to signing the RRset.

                        named-checkzone -r {ignore|warn|fail} (default warn)
                        named-compilezone -r {ignore|warn|fail} (default warn)

                        named.conf: check-dup-records {ignore|warn|fail};
2009-12-04 21:09:34 +00:00
Tatuya JINMEI 神明達哉
790e471f6e 2681. [bug] IPSECKEY RR of gateway type 3 was not correctly
decoded [RT #20269].

BIND 9.7.0, 9.6.2, 9.5.2, 9.4.4
2009-09-18 21:55:21 +00:00
Evan Hunt
e7c38ca963 - define isc_mem_reallocate() in the abstract API for export lib [rt20208]
- define BIND9 in config.h.win32
- fix problems in mem.h caused by the win32 preprocessor failing to
  expand macros used within macros
- silence a win32 compiler warning in hip_55.c
2009-09-02 23:43:54 +00:00
Evan Hunt
cfb1587eb9 2619. [func] Add support for RFC 5011, automatic trust anchor
maintenance.  The new "managed-keys" statement can
			be used in place of "trusted-keys" for zones which
			support this protocol.  (Note: this syntax is
			expected to change prior to 9.7.0 final.) [RT #19248]
2009-06-30 02:53:46 +00:00
Automatic Updater
92e4603c55 update copyright notice 2009-02-26 11:18:56 +00:00
Mark Andrews
e4c6491bbf 2565. [func] Add support for HIP record. Includes new functions
dns_rdata_hip_first(), dns_rdata_hip_next()
                        and dns_rdata_hip_current().  [RT #19384]
2009-02-26 06:09:19 +00:00
Mark Andrews
803bf59371 silence 'Different types treated as unsigned for <=.' warning 2009-02-17 05:53:13 +00:00
Automatic Updater
bf33eb0b52 update copyright notice 2009-02-16 23:48:04 +00:00
Mark Andrews
e502b133d6 2556. [cleanup] PCI compliance:
* new libisc log module file
                        * isc_dir_chroot() now also changes the working
                          directory to "/".
                        * additional INSISTs
                        * additional logging when files can't be removed.
2009-02-16 02:01:16 +00:00
Automatic Updater
83b86f3936 update copyright notice 2009-01-21 23:47:27 +00:00
Mark Andrews
31b7a2fed6 2534. [func] Check NAPTR records regular expressions and
replacement strings to ensure they are syntaxically
                        valid and consistant. [RT #18168]
2009-01-21 05:37:55 +00:00
Automatic Updater
d362465c77 update copyright notice 2009-01-17 23:47:43 +00:00
Francis Dupont
340804cbdb spelling 2009-01-17 13:52:02 +00:00
Francis Dupont
a7e3a86619 spelling 2009-01-17 13:45:25 +00:00
Automatic Updater
3398334b3a update copyright notice 2008-09-25 04:02:39 +00:00
Mark Andrews
6098d364b6 2448. [func] Add NSEC3 support. [RT #15452] 2008-09-24 02:46:23 +00:00
Automatic Updater
b6ba2af51b update copyright notice 2008-07-15 23:47:21 +00:00
Mark Andrews
718106da14 update reference 2008-07-15 05:45:34 +00:00
Mark Andrews
9c89fcb69c remove: not yet 2008-04-04 10:02:21 +00:00
Mark Andrews
77abeb5330 rebase NSEC3 code 2008-04-04 05:34:07 +00:00
Automatic Updater
6475e22cc9 update copyright notice 2008-02-15 23:46:51 +00:00
Mark Andrews
0e30609d7b 2334. [bug] Bad REQUIRES in fromstruct_in_naptr(), off by one
bug in fromstruct_txt(). [RT #17609]
2008-02-15 03:28:49 +00:00
Automatic Updater
f731b5d665 update copyright notice 2008-01-22 23:28:04 +00:00
Mark Andrews
e951a79d90 2319. [bug] Silence Coverity warnings in
lib/dns/rdata/in_1/apl_42.c. [RT #174]
2008-01-22 23:17:31 +00:00
Automatic Updater
70e5a7403f update copyright notice 2007-06-19 23:47:24 +00:00
Automatic Updater
ec5347e2c7 update copyright notice 2007-06-18 23:47:57 +00:00
Automatic Updater
77ab862dca update copyright notice 2007-02-26 23:46:54 +00:00
Mark Andrews
394f4aec21 2145. [bug] Check DS/DLV digest lengths for known digests.
[RT #16622]
2007-02-26 01:20:44 +00:00
Mark Andrews
1814d2108d update copyright notice 2006-12-07 23:57:59 +00:00
Mark Andrews
a7dd5f21e9 2108. [func] DHCID support. [RT #16456] 2006-12-07 03:38:39 +00:00
Mark Andrews
0cfc2b930c update copyright notice 2006-02-19 06:50:48 +00:00
Mark Andrews
f3a8cd3835 1985. [protocol] DLV has now been assigned a official type code of
32769. [RT #15807]
2006-02-17 01:04:14 +00:00
Mark Andrews
141132c272 update copyright notice 2006-01-07 00:23:35 +00:00
Mark Andrews
00b872e4f7 4255: Using DNS to Securely Publish Secure Shell (SSH) Key Fingerprints 2006-01-06 23:16:00 +00:00
Mark Andrews
6f780e4d31 update copyright notice 2005-09-06 07:29:31 +00:00
Mark Andrews
0da29be670 1914. [protocol] DS is required to accept mnemonic algorithms
(RFC 4034).  Still emit numeric algorithms for
                        compatability with RFC 3658. [RT #15354]
2005-09-06 06:50:52 +00:00
Mark Andrews
4ba6b6a7ef silence compiler warnings 2005-08-23 04:05:50 +00:00
Mark Andrews
e39d36b115 update copyright notice 2005-07-16 00:40:43 +00:00
Mark Andrews
aa0f0779d1 1901. [func] Support for SPF rdata type. [RT #15033] 2005-07-14 06:46:44 +00:00
Mark Andrews
0bb7c66ef8 1897. [func] Support for IPSECKEY rdata type. [RT #14967] 2005-07-07 03:12:57 +00:00
Mark Andrews
dc5c59bd1d update copyright 2005-06-05 00:01:55 +00:00
Mark Andrews
ef67e6d8fa 1859. [func] Add support for CH A record. [RT #14695] 2005-06-04 00:18:56 +00:00
Mark Andrews
172d748152 update copyright notice 2005-05-20 01:09:36 +00:00
Mark Andrews
c5223c9cb7 1862. [func] Add additional zone data constancy checks.
named-checkzone has extended checking of NS, MX and
                        SRV record and the hosts they reference.
                        named has extended post zone load checks.
                        New zone options: check-mx and integrity-check.
                        [RT #4940]
2005-05-19 04:59:05 +00:00
Mark Andrews
69fe9aaafd update copyright notice 2005-04-29 00:24:12 +00:00
Rob Austein
ab023a6556 1851. [doc] Doxygen comment markup. [RT #11398] 2005-04-27 04:57:32 +00:00
Mark Andrews
8ff7c9a0bb update copyright notice 2005-03-20 22:32:57 +00:00
Mark Andrews
2da53322f3 silence compiler warnings 2005-03-18 04:31:01 +00:00
Mark Andrews
b7b6b01a0d update copyright 2005-03-16 00:55:19 +00:00
Mark Andrews
b101c1e998 1822. [bug] check-names test for RT was reversed. [RT #13382] 2005-03-14 23:41:29 +00:00
Mark Andrews
ffcbf9ea91 silence compiler warnings 2004-09-16 01:01:27 +00:00
Mark Andrews
e8346a529a 1678. [bug] RRSIG should use TYPEXXXXX for unknown types. 2004-06-24 00:43:15 +00:00
Mark Andrews
1676408640 pullup silence compiler fixes
ifconfig.sh for Solaris 9
README updates
2004-03-18 02:58:08 +00:00
Mark Andrews
1fa26403d7 copyright 2004-03-16 05:22:33 +00:00
Mark Andrews
50105afc55 1589. [func] DNSSEC lookaside validation.
enable-dnssec -> dnssec-enable
2004-03-10 02:19:58 +00:00
Mark Andrews
dafcb997e3 update copyright notice 2004-03-05 05:14:21 +00:00
Mark Andrews
821644d49b 1574. [bug] Don't attempt to open the controls socket(s) when
running tests. [RT #9091]
2004-03-02 02:01:41 +00:00
Mark Andrews
d970376259 checkowner had wrong type and class 2004-03-02 01:40:44 +00:00
Mark Andrews
2047977ce2 1586. [func] "check-names" is now implemented. 2004-02-27 20:41:51 +00:00
Mark Andrews
d6f0e45014 1535. [bug] When parsing APL records it was possible to silently
accept out of range ADDRESSFAMILY values. [RT# 9979]
2004-01-05 06:11:39 +00:00
Mark Andrews
1e59437940 remove test for type 0 being set in from wire. 2003-12-13 04:33:53 +00:00
Mark Andrews
5697061cf7 unused variables 2003-12-13 04:31:37 +00:00
Mark Andrews
185fd22738 1541. [func] NSEC now uses new bitmap format. 2003-12-13 04:20:44 +00:00
Mark Andrews
89639a5e13 1520. [protocol] Add SSHFP (SSH Finger Print) type.
Supplied by Jakob Schlyter jakob@rfc.se.
2003-10-01 10:05:00 +00:00
Mark Andrews
93d6dfaf66 1516. [func] Roll the DNSSEC types to RRSIG, NSEC and DNSKEY. 2003-09-30 06:00:40 +00:00
Mark Andrews
5eb91bd90e silence compiler warnings (HPUX/11i) 2003-07-25 00:01:16 +00:00
Mark Andrews
182a34004c 1463. [bug] dns_rdata_from{wire,struct}() failed to catch bad
NXT bit maps. [RT #5577]
2003-04-17 03:43:35 +00:00
Mark Andrews
12ff7274fe 1409. [bug] DS should have attibute DNS_RDATATYPEATTR_DNSSEC. 2002-12-20 01:19:20 +00:00
Danny Mayer
59d1535572 casts required 2002-08-01 03:31:44 +00:00
Mark Andrews
53f9ddf27c silence pointer mismatch 2002-07-04 04:19:54 +00:00
Mark Andrews
0b09763c35 1328. [func] DS (delegation signer) support. 2002-06-17 04:01:37 +00:00
Mark Andrews
e0fa16fe19 1326. [bug] Badly encoded LOC record when the size, horizontal
precision or vertical precision was 0.1m.
2002-06-14 23:40:14 +00:00
Brian Wellington
a615e9a446 ALP -> APL 2002-03-06 18:33:13 +00:00
Mark Andrews
feb8ae0931 1220. [func] Support for APL rdata type. 2002-03-06 07:41:25 +00:00
Mark Andrews
a7038d1a05 copyrights 2002-02-20 03:35:59 +00:00
Mark Andrews
9ef64d35b7 only issue warning if callbacks is none NULL. 2002-02-12 03:57:59 +00:00
Mark Andrews
9aa1fb4861 1192. [bug] The seconds fields in LOC records were restricted
to three decimal places.  More decimal places should
                        be allowed but warned about.

Paul requested that this be a warned about.
2002-02-10 23:52:26 +00:00
Brian Wellington
9ecd36e0de RFC 2065 -> RFC 2535 2002-01-31 01:50:46 +00:00
Brian Wellington
0062c1ddfe 1192. [bug] The seconds fields in LOC records were restricted
to three decimal places.  More decimal places should
			be allowed and silently truncated.
2002-01-27 20:52:47 +00:00
Mark Andrews
c46f10e4a1 Use as_textregion.base not as_pointer. [RT #2385] 2002-01-21 01:07:32 +00:00
Olafur Gudmundsson
90e303b114 Adding function isc_region_compare and using in instead of compare_region in lib/dns 2002-01-05 07:05:28 +00:00
Andreas Gustafsson
91cd0f93ad sizeof style 2001-11-27 01:56:32 +00:00
Andreas Gustafsson
f1b6872550 Do not put a space before ';' when terminating a statement or in a 'for' statement. 2001-11-27 00:56:32 +00:00
Mark Andrews
f3352b9bec compare: a REQUIRE() was comparing a variable against itself not agaist the
other arguement as it should have been.
2001-09-10 23:47:26 +00:00
Mark Andrews
c38b92000c 947. [bug] dns_rdata_soa_t had a badly name element "mname" which
was really the RNAME field from RFC1035.  To avoid
                        confusion and silent errors that would occur it ther
                        "origin" and "mname" elements were given their correct
                        names "mname" and "rname" respectively, the "mname"
                        element is renamed to "contact".
2001-07-30 01:09:14 +00:00
Andreas Gustafsson
90e289c59f A6 has an RFC now 2001-07-26 21:34:02 +00:00
Mark Andrews
bddfe77128 936. [func] Warn when non dotted decimal quad's are used.
[RT #1084]

 935.   [bug]           inet_pton failed to reject leading zeros.
2001-07-16 03:06:53 +00:00
Mark Andrews
85bdc128fc Relax REQUIRES() in *fromstruct() and unconditionally call
mem_maybedup() in *tostruct().
TXT is one or more (not zero or more) strings.
2001-06-21 04:00:47 +00:00
Andreas Gustafsson
08a44b06ef the length of the NULL record RDATA can be zero;
do not assert the contrary
2001-06-20 17:43:31 +00:00
Andreas Gustafsson
9762fd29cc DNAME now has an RFC 2001-04-27 21:02:01 +00:00
Brian Wellington
caa55a6557 When printing KEY records with COMMENT and MULTILINE, the line would often
be too long.
2001-03-28 02:57:26 +00:00
Brian Wellington
ae114ded82 Fix a bunch of unused variable warnings that only occurred with assertions
turned off.
2001-03-16 22:53:20 +00:00
Mark Andrews
9ac7076eba 769. [func] Improved error reporting when parsing rdata. [RT #740]
Two new error codes.  Also push back the last token, if it makes
sense to do so, so that it gets printed in the error message using
RETTOK macro, rather than straight return or RETERR.
2001-03-06 22:11:18 +00:00
Brian Wellington
cdc50af0bf In the towire_* and additionaldata_* routines, add an offsets table to names
passed into dns_name_toregion().  This is effectively free, and reduces the
number of calls to set_offsets() and dns_name_clone() in name compression.
2001-02-12 03:05:05 +00:00
Brian Wellington
330705066b Wrap inet_ntop() and use that in the _totext() functions. The wrapper calls
inet_ntop() and copies the output (but not the trailing null) into the buffer.
2001-01-25 20:14:42 +00:00
Brian Wellington
2a006fffe4 our NAPTR implementation does conform to RFC 2915. 2001-01-18 22:05:41 +00:00
Brian Wellington
cb2ad98ea4 make prefixlen an isc_uint8_t [RT #658] 2001-01-17 02:54:17 +00:00
Mark Andrews
7dbb39a417 680. [bug] dns_rdata_fromstruct() mis-handles options bigger
than 255 octets.
2001-01-16 06:14:00 +00:00
Brian Wellington
e5fb13fb23 The asserts in fromstruct were too strong - it's possible to have a non-NULL
key and keylen == 0 if the pointer is to a 0 byte allocation.
2001-01-11 03:11:30 +00:00
Brian Wellington
499b34cea0 copyright update 2001-01-09 22:01:04 +00:00
Andreas Gustafsson
63cef8bde8 added UNUSED() macros for arguments that end up unused when assertion checking
is turned off
2000-12-01 01:40:59 +00:00
Andreas Gustafsson
daf99720c9 the existence of a dynamically allocated array for the NXT
bits should not depend on its length
2000-11-14 18:14:44 +00:00
Brian Wellington
add4043305 The identical gettoken() routines in rdata.c, hex.c, and base64.c have
been replaced with isc_lex_getmastertoken().
2000-11-08 01:56:15 +00:00
Brian Wellington
0a6ddf7b82 A typo caused null keys to be printed incorrectly. 2000-10-31 20:12:32 +00:00
Mark Andrews
b589e90689 Remove the rdata->length == 0 checks, UPDATE pseudo rdata are now tagged.
Add sanity checks to rdata types where the length cannot legally be zero.
2000-10-25 05:44:10 +00:00
Brian Wellington
e484f9de4f The nxt structure was basically useless. 2000-10-06 22:41:16 +00:00
Brian Wellington
8c7fa43b3c Make dst_region_computeid() take an algorithm, since it was returning the
wrong id for RSA keys.  Also clean up a few error messages from dst routines.
2000-09-08 14:23:49 +00:00
Brian Wellington
37a8fbab3a 411. [bug] A typo in the HS A code caused an assertion failure. 2000-08-28 17:39:21 +00:00
Andreas Gustafsson
9f139761ca don't use parentheses in the text representation of RRs unless
we are in multiline mode; this ensures that the output can be re-parsed with
dns_rdata_fromtext
2000-08-24 21:41:44 +00:00
Brian Wellington
9ce72fc748 don't print parens at all if in non-multiline mode. 2000-08-22 22:07:13 +00:00
Brian Wellington
2f507825cf _tostruct had a few typos. 2000-08-10 01:59:39 +00:00
Andreas Gustafsson
efadda9a7b added UNUSED() macros to suppress compiler warnings when
compiling with assertion checking turned off
2000-08-08 23:40:46 +00:00
David Lawrence
40f53fa8d9 Trailing whitespace trimmed. Perhaps running "perl util/spacewhack.pl in your
own CVS tree will help minimize CVS conflicts.  Maybe not.
Blame Graff for getting me to trim all trailing whitespace.
2000-08-01 01:33:37 +00:00
David Lawrence
23b251fbf2 needs <dns/name.h> for dns_name_t 2000-07-31 20:57:06 +00:00
Brian Wellington
0e93f65e10 Print the key id when DNS_STYLEFLAG_COMMENT is passed to _totext() 2000-07-31 19:47:21 +00:00
Brian Wellington
2b518b5fb4 fixedname.h is not needed 2000-07-31 19:40:52 +00:00
David Lawrence
15a4474541 word wrap copyright notice at column 70 2000-07-27 09:55:03 +00:00
David Lawrence
5eae30a019 in fact, ISC_LANG_BEGINDECLS and ISC_LANG_ENDDECLS are not needed at all since
rdatastructpre.h and rdatastructsuf.h already provide the wrapper.
(no need to pull up.)
2000-06-28 19:07:19 +00:00
David Lawrence
778d24f5ba do not include isc/lang.h; rdatastructpre.h already gets it.
no need to pull these changes up to the 9.0.0 branch.
2000-06-28 19:03:24 +00:00
David Lawrence
9c3531d72a add RCS id string 2000-06-22 22:00:42 +00:00
David Lawrence
28d9fd5381 update_copyrights 2000-06-21 22:45:24 +00:00
Andreas Gustafsson
12dd8db40b don't indent comments by one space 2000-06-16 21:45:51 +00:00
David Lawrence
003a40178f make DNS_RDATACOMMON_INIT work again. structure elemnts had the same name as
the downcased macro argument names
2000-06-07 00:11:51 +00:00
David Lawrence
fccbca2cdf style lint; macro parameter names are lowercase 2000-06-06 15:23:26 +00:00
Mark Andrews
ba6f0d85b4 Add macro to initalise the common part of a rdata struct. 2000-06-06 02:03:23 +00:00
David Lawrence
6d12fdf966 Megacommit of many files.
Mostly, several functions that take pointers as arguments, almost
always char * pointers, had those pointers qualified with "const".
Those that returned pointers to previously const-qualified arguments
had their return values qualified as const.  Some structure members
were qualified as const to retain that attribute from the variables
from which they were assigned.

The macro DE_CONST is used to deal with a handful of very special
places where something is qualified as const but really needs to have
its const qualifier removed.

rdata.c now defines macros for the prototypes of the basic rdata functions,
and all of the lib/dns/rdata/**/*.c files now use them.

Some minor integer-compatibility issues.  (IE, ~0x03 is a signed int,
so assigning it to an unsigned int should use a cast.  The type of an
enum member is int, so there are some conversion issues there, too.)

A pointers-to-function should not be cast to a pointer-to-object.

Variables should not be named for C reserved identifiers.

One or two set-but-not-used variables removed.

Minor other ISC style cleanups.
2000-06-01 18:26:56 +00:00
Andreas Gustafsson
fd6de7af32 refer to RFC2845, not draft-ietf-dnsext-tsig-00.txt 2000-06-01 16:47:26 +00:00
Brian Wellington
5d83b561ad Added dns_tsigrcode_totext/fromtext 2000-05-25 00:46:32 +00:00
David Lawrence
ed019cabc1 fixed lines > 79 columns wide 2000-05-24 05:10:00 +00:00
Andreas Gustafsson
1ac4b2a1da when printing a SIG record with covers==0, print it as 0,
not RESERVED0
2000-05-22 21:42:47 +00:00
Mark Andrews
373ce67419 Implement dns_rdata_fromstruct() where not already done.
Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
Mark Andrews
389e24909e return ISC_R_SUCCESS from tostruct(). 2000-05-19 13:28:36 +00:00
Mark Andrews
a2b5255212 remove INSIST(ISC_FALSE) from freestruct(). 2000-05-19 13:27:45 +00:00
Mark Andrews
1e2cf7696f tostruct() initalise region from rdata. 2000-05-19 13:05:51 +00:00
Mark Andrews
e7514afccb Convert tostruct() to new API. 2000-05-19 13:04:45 +00:00
Mark Andrews
e6caf43a0b ctype.h is now included in rdata.c 2000-05-19 02:12:56 +00:00
Mark Andrews
251705f683 Lowercase the service string as some getservbyname() are case sensitive
and the database is usually in lowercase.
2000-05-19 02:07:16 +00:00
Mark Andrews
4333126a5c Name structures were not being initialized. 2000-05-19 02:06:00 +00:00
Mark Andrews
1bb227b988 dns_name_dup() -> name_duporclone() in tostruct(). 2000-05-19 02:03:56 +00:00
Mark Andrews
3ef59f5561 Fix bad REQUIRE in tostruct(). 2000-05-19 02:02:11 +00:00
Mark Andrews
2b24b1909f remove REQUIRE(mctx != NULL) from tostruct 2000-05-18 06:27:07 +00:00
Mark Andrews
206c71aae4 handle freestruct(.. mctx = NULL); 2000-05-18 05:46:52 +00:00
Mark Andrews
e7359c3a86 Implement totext(). RFC 2671 does *not* specify a presentation format.
[option length [base64string] ] ...
2000-05-17 03:39:29 +00:00
David Lawrence
34b394b43e DNS_R_RANGE -> ISC_R_RANGE 2000-05-15 21:14:38 +00:00
David Lawrence
71f88e821c Fixed IRIX warnings:
"./rdata/any_255/tsig_250.c", line 74: remark(1506): implicit conversion from
          "unsigned long" to "int":  rounding, sign extension, or loss of
          accuracy may result
"./rdata/any_255/tsig_250.c", line 95: remark(1506): implicit conversion from
          "unsigned long" to "int":  rounding, sign extension, or loss of
          accuracy may result

The values in question were already being checked to be within the range of
a short, so where the warnings were occuring they were just cast to int.
2000-05-13 22:50:49 +00:00
David Lawrence
652c80435a Fixed IRIX warnings:
"./rdata/generic/tkey_249.c", line 89: remark(1506): implicit conversion from
          "unsigned long" to "int":  rounding, sign extension, or loss of
          accuracy may result
"./rdata/generic/tkey_249.c", line 98: remark(1506): implicit conversion from
          "unsigned long" to "int":  rounding, sign extension, or loss of
          accuracy may result

The values in question were already being checked to be within the range of
a short, so where the warnings were occuring they were just cast to int.
2000-05-13 22:46:07 +00:00
David Lawrence
e14969d293 Fixed IRIX warning:
"./rdata/generic/unspec_103.c", line 138: warning(1184): possible use of "="
          where "==" was intended
by changing to ==, which is clearly what was intended.
2000-05-13 22:39:03 +00:00
David Lawrence
17547ed8c9 Fixed IRIX warning:
"./rdata/generic/opt_41.c", line 73: remark(1552): variable "option" was set
          but never used
by removing option, because there was nothing to do with its value.
2000-05-13 22:33:29 +00:00
David Lawrence
7c7d67b5d8 Fixed IRIX warning:
"./rdata/in_1/a6_38.c", line 259: remark(1552): variable "octets" was set but
          never used
by using UNUSED() on this stack variable.  I didn't take it out altogether
because this function is not yet finished, but someone was starting to
do some work on it and I didn't want to undo that.
2000-05-13 22:07:57 +00:00
David Lawrence
873484b40d Fixed IRIX warning:
"./rdata/generic/nxt_30.c", line 66: warning(1042): operand types are
          incompatible ("char *" and "void *")
by casting to char *, as already being done with several other uses of
token.value.as_pointer.
2000-05-13 22:05:39 +00:00
David Lawrence
22520194de Fixed several instances of this IRIX warning:
"./rdata/generic/loc_29.c", line ??: remark(1506): implicit conversion from
          "unsigned long" to "int":  rounding, sign extension, or loss of
          accuracy may result
by making sure that the range was suitable for an int and casting to
int in each case.  (This appeared to be more desirable than changing
all of the variables in question to longs.)
2000-05-13 21:24:37 +00:00
David Lawrence
f1f3bb3aa0 Fixed IRIX warning:
"./rdata/generic/mx_15.c", line 202: warning(1184): possible use of "=" where
          "==" was intended
by changing to == since it was clear that test was desired, not assignment.
2000-05-13 20:52:13 +00:00
David Lawrence
44d74084ff Fixed IRIX warnings:
"./rdata/in_1/a_1.c", line 178: warning(1184): possible use of "=" where "=="
          was intended
"./rdata/in_1/a_1.c", line 179: warning(1184): possible use of "=" where "=="
          was intended

By chaning them to ==, because (a) we don't allow side-effects in REQUIRE()
and (b) it is clear from the rest of the code that it really was a test that
was desired and not an assignment.
2000-05-13 20:50:35 +00:00
Mark Andrews
c661868379 Add missing range checks in fromtext(). 2000-05-12 12:59:35 +00:00
Andreas Gustafsson
fd9f6afdff use the UNUSED() macro 2000-05-11 22:47:00 +00:00
David Lawrence
8abddcd3f2 rdata.c needs to include string.h before memcpy is used.
since rdata.c is including string.h, the individual rdata files do not need to.
2000-05-08 16:12:30 +00:00
David Lawrence
1a69a1a78c Megacommit of dozens of files.
Cleanup of redundant/useless header file inclusion.

ISC style lint, primarily for function declarations and standalone
comments -- ie, those that appear on a line without any code, which
should be written as follows:
   /*
    * This is a comment.
    */
2000-05-08 14:38:29 +00:00
Mark Andrews
5159c42783 153. [func] dns_rdata_tostruct() 'mxtc' is now optional. If 'mctx'
is NULL then you need to preserve the 'rdata' until
                      you have finished using the structure as there may be
                      references to the associated memory.  If 'mctx' is non
                      NULL it is guarenteed that there are no references to
                      to memory addsociated with 'rdata'.

                      dns_rdata_freestruct() must be called if 'mctx' was
                      non NULL and may safely be called if 'mctx' was NULL.

Finish implementing 153 for IN specific types.
naptr_35.h some of the lengths should be 8 bits.
2000-05-05 23:20:10 +00:00
Andreas Gustafsson
5466ce3f27 fromstruct_* functions needlessly used dns_name_towire() to do
a simple name data copy, thereby requiring a non-NULL mctx
2000-05-05 18:15:02 +00:00
Andreas Gustafsson
8d501088b7 tostruct_ns() used the wrong mctx 2000-05-05 17:24:21 +00:00
Mark Andrews
9281e7aa77 Implement / convert to new API for tostuct() and freestruct().
Define dns_rdata_loc_t structure.
x25 length is only 8 bits.
2000-05-05 05:50:14 +00:00
Michael Graff
8e3e48ff56 use isc_uint8_t rather than isc_int8_t for string lengths, and don't call a structure member sa_len 2000-05-04 23:50:56 +00:00
Andreas Gustafsson
94a08e09db Check for edns1 and strict decompression once and for all in
dns_[de]compress_setmethods instead of separately in every caller
2000-05-04 22:19:34 +00:00
Andreas Gustafsson
59a6d9effd omit DNS_RDATATYPEATTR_SINGLETON from RRTYPE_NXT_ATTRIBUTES
so that we can cope with parent/child NXT pairs.  DNSSEC sucks.
2000-05-03 23:52:35 +00:00
David Lawrence
a1f16c81a1 removed unused stack variable "result" from totext_nxt 2000-05-01 18:27:43 +00:00
David Lawrence
4be63b1fd8 144. [cleanup] libdns header files too numerous to name were made
to conform to the same style for multiple inclusion
                        protection.
2000-04-29 02:02:38 +00:00
Andreas Gustafsson
5436ac5553 cope with dns_rdatatype_totext() succeeding for
unknown RR types
2000-04-29 01:51:39 +00:00
David Lawrence
358628c8f4 138. [cleanup] isc_strtouq moved from str.[ch] to string.[ch] and
renamed isc_string_touint64.  isc_strsep moved from
                        strsep.c to string.c and renamed isc_string_separate.
2000-04-28 22:40:10 +00:00
Mark Andrews
b186f1ab91 Add structure definitions so they can be documented.
Support functions to follow soon.
2000-04-28 21:49:03 +00:00
Mark Andrews
b8dd48ecf8 119. [cleanup] structure definitions for generic rdata stuctures do
not have _generic_ in their names.
2000-04-28 02:08:37 +00:00
Andreas Gustafsson
82ca33427b declare arguments as UNUSED() when used in assertions only 2000-04-28 01:24:18 +00:00
Andreas Gustafsson
90f9d00f08 declare arguments as UNUSED() when used in assertions only 2000-04-27 23:57:56 +00:00
David Lawrence
6e49e91bd0 103. [func] libisc buffer API changes for <isc/buffer.h>:
Added:
                                isc_buffer_base(b)          (pointer)
                                isc_buffer_current(b)       (pointer)
                                isc_buffer_active(b)        (pointer)
                                isc_buffer_used(b)          (pointer)
                                isc_buffer_length(b)            (int)
                                isc_buffer_usedlength(b)        (int)
                                isc_buffer_consumedlength(b)    (int)
                                isc_buffer_remaininglength(b)   (int)
                                isc_buffer_activelength(b)      (int)
                                isc_buffer_availablelength(b)   (int)
                        Removed:
                                ISC_BUFFER_USEDCOUNT(b)
                                ISC_BUFFER_AVAILABLECOUNT(b)
                                isc_buffer_type(b)
                        Changed names:
                                isc_buffer_used(b, r) ->
                                        isc_buffer_usedregion(b, r)
                                isc_buffer_available(b, r) ->
                                        isc_buffer_available_region(b, r)
                                isc_buffer_consumed(b, r) ->
                                        isc_buffer_consumedregion(b, r)
                                isc_buffer_active(b, r) ->
                                        isc_buffer_activeregion(b, r)
                                isc_buffer_remaining(b, r) ->
                                        isc_buffer_remainingregion(b, r)

                        Buffer types were removed, so the ISC_BUFFERTYPE_*
                        macros are no more, and the type argument to
                        isc_buffer_init and isc_buffer_allocate were removed.
                        isc_buffer_putstr is now void (instead of isc_result_t)
                        and requires that the caller ensure that there
                        is enough available buffer space for the string.
2000-04-27 00:03:12 +00:00
Mark Andrews
e8c91210aa Add structure definitions. 2000-04-26 18:27:56 +00:00
Mark Andrews
178f9cf89f fromstruct MUST NOT check mctx 2000-04-26 01:41:58 +00:00
Michael Graff
7ec579cd5d Add functions to check that a type is only or is not allowed in a question section 2000-04-14 20:13:49 +00:00
Michael Graff
6324997211 add attributes (line singleton, exlcusive, meta, etc) to rdata C files, and
build a table of them using gen.c.  This means the names are stored twice,
but that will change in the near future.  This will speed up number to text
conversions for rdatatypes, and I plan on speeding up text->number as
well, soon.
2000-04-07 03:54:52 +00:00
Michael Graff
4195904998 s/DNS_R_/ISC_R_/ change for some codes. 2000-04-06 22:03:35 +00:00
Andreas Gustafsson
26dc2e1958 need <dns/types.h> to define dns_rdatatype_t 2000-04-04 23:10:53 +00:00
Andreas Gustafsson
71bd2b06d6 use the UNUSED() macro 2000-03-21 23:48:20 +00:00
Andreas Gustafsson
8e191edd65 don't indent comments by one space 2000-03-20 23:08:50 +00:00
Andreas Gustafsson
a7d3e828eb don't indent comments by one space 2000-03-20 22:57:15 +00:00
Andreas Gustafsson
47830e3a58 don't indent comments by one space 2000-03-20 22:48:59 +00:00
Andreas Gustafsson
41aad56b6c avoid calling variables 'result' if they are not of type isc_result_t 2000-03-20 22:44:36 +00:00
Andreas Gustafsson
2d2bd6a7ae style changes from code review 2000-03-20 19:32:10 +00:00
Andreas Gustafsson
b538f54ad3 totext_in_wks() consumed two bytes for the one-byte
protocol field, causing the port list to be printed incorrectly
2000-03-20 19:29:44 +00:00
Andreas Gustafsson
a3c9e34301 print the 'other data' in multiline mode if nonempty 2000-03-20 18:40:28 +00:00
Andreas Gustafsson
ea5bd6a950 source region was not consumed in fromwire_in_nsap() (RT #73) 2000-03-20 18:03:53 +00:00
James Brister
1774961457 review changes. 2000-03-19 03:15:49 +00:00
David Lawrence
64339caa43 removed unused "result" stack var from digest_afsdb 2000-03-18 01:46:15 +00:00
Michael Graff
f31f0b63cb review code, add UNUSED() where needed, fix a bug made yesterday with RETERR() 2000-03-18 00:19:26 +00:00