Commit graph

3318 commits

Author SHA1 Message Date
Brian Wellington
ae00b82d93 spelling 2001-03-01 17:46:59 +00:00
Brian Wellington
15c5b240a6 dns_peer_setkeybycharp didn't initialize a fixedname. 2001-03-01 02:28:34 +00:00
Brian Wellington
a0b4d6cf8a comment style 2001-02-28 21:19:53 +00:00
Andreas Gustafsson
d1cc210d20 RT #927 fix from Bob:
759.   [bug]           The resolver didn't turn off "avoid fetches" mode
                        when restarting, possibly causing resolution
                        to fail when it should not.  This bug only affected
                        platforms which support both IPv4 and IPv6. [RT #927]

 758.   [bug]           The "avoid fetches" code did not treat negative
                        cache entries correctly, causing fetches that would
                        be useful to be avoided.  This bug only affected
                        platforms which support both IPv4 and IPv6. [RT #927]
2001-02-28 20:51:22 +00:00
Brian Wellington
d752e5c19e removed pointless code (an if statement checking something that had been
INSISTed on the previous line).
2001-02-28 20:20:18 +00:00
Brian Wellington
113dee27af dns_zt_load() was not checking the validity of the zonetable. 2001-02-27 02:54:11 +00:00
Brian Wellington
590f840d34 implement the prototyped but nonexistant function dns_peer_setkeybycharp(). 2001-02-27 01:13:18 +00:00
Brian Wellington
f5ccecd9c3 #include <config.h> 2001-02-26 02:49:19 +00:00
Mark Andrews
a93cf7e83b 756. [bug] dns_zone_load() could "return" success when no master
file was configured.

 755.   [bug]           Fix format bugs in zone.c (non-exploitable).
2001-02-26 01:45:57 +00:00
Brian Wellington
6fd0827482 Remove notify forwarding. 2001-02-24 00:59:00 +00:00
Mark Andrews
903e9d41ef 751. [func] Log successful zone loads / transfers. 2001-02-23 22:32:07 +00:00
Bob Halley
c274e542ad The fixes to return the SIG of a DNAME RR missed one place where
search.zonecut was set, and consequently we were accessing
search.zonecut_sigrdataset without initializing it.
2001-02-23 05:33:36 +00:00
Bob Halley
f4b5a0f434 When a query matched a DNAME in a secure zone, the server did not return the
signature of the DNAME.  [RT #915]

A query should not match a DNAME whose trust level is pending.  [RT #916]
2001-02-23 02:14:14 +00:00
Brian Wellington
542a74fcc4 comment update 2001-02-23 01:52:18 +00:00
Brian Wellington
c5c779df9a add a comment 2001-02-23 01:45:29 +00:00
Brian Wellington
5ca7310c8a msg->tsigkey was not checked for NULL before deferencing [RT #913] 2001-02-23 01:38:07 +00:00
Andreas Gustafsson
25c3ab1a5f cache-file option name was misspelled 2001-02-22 17:30:09 +00:00
Brian Wellington
9a41936e3d current_root was uninitialized at the start of dns_rbt_findnode(). This
has no real effect, but it's still good to fix it.
2001-02-21 23:21:28 +00:00
Brian Wellington
26e5029fd5 Added a cast. [RT #899] 2001-02-21 19:57:38 +00:00
Brian Wellington
6be1dc9d2a Document the 'covers' parameter to dns_message_findname and
dns_message_findtype.
2001-02-21 18:32:27 +00:00
Brian Wellington
36608f2052 When returning from validation, make sure to handle chaiing correctly. 2001-02-21 05:16:44 +00:00
Mark Andrews
fbafe841ef fixed pushing and poping of included files. [RT#904] 2001-02-21 03:53:11 +00:00
Brian Wellington
c5945fe694 Fix a potential bitstring bug. 2001-02-21 02:27:56 +00:00
Brian Wellington
4e8eba14a0 reinstate an INSIST() referenced in [RT #421] 2001-02-21 02:01:15 +00:00
Brian Wellington
a012d6dbfb 746. [bug] The sdb didn't clone rdatasets properly, causing
a crash when the server followed delegations. [RT #905]
2001-02-20 23:20:44 +00:00
Brian Wellington
f70336b8c9 Cleanups to TSIG/SIG(0) parsing. This should have no noticable effect except
rejecting a few more malformed packets (those with the TSIG/SIG(0) not the
last record) and making best-effort parsing handle multiple TSIG/SIG(0)/OPT in
a message.
2001-02-19 20:14:23 +00:00
Mark Andrews
43de493006 745. [func] Report the owner name on when adding a rdataset
to the internal database fails while loading.
2001-02-19 13:24:04 +00:00
Bob Halley
1e50dad10d When returning DNS_R_CNAME or DNS_R_DNAME as the result of an ANY or SIG
query, the resolver failed to setup the return event's rdatasets, causing an
assertion failure in the query code.  [RT #881]

The fix includes the addition of the DNS_NAMEATTR_CHAINING attribute,
and the removal of the DNS_NAMEATTR_CNAME and DNS_NAMEATTR_DNAME attributes,
because they were not used anywhere in the current source.
2001-02-19 08:54:54 +00:00
Brian Wellington
3bd43bb300 ENSURE that a message's memory pools don't have any allocated data at the
end of msgreset().  This should trigger the mpctx->allocated != 0 assertion
when the leak occurs, not at server shutdown.
2001-02-18 23:46:26 +00:00
Brian Wellington
3f07549972 comment fix 2001-02-18 21:19:43 +00:00
Brian Wellington
62adc5ed76 Call free_namelist() rather than freeing the list manually. 2001-02-17 02:22:43 +00:00
Andreas Gustafsson
19eee89387 if dns_message_gettempname() failed, we would try to call
dns_message_putemprdataset() on an uninitialized pointer
2001-02-17 02:16:14 +00:00
Andreas Gustafsson
4e72c83c94 removed unused variable 2001-02-17 00:23:49 +00:00
Brian Wellington
683301a954 fix a potential (but highly unlikely) memory leak. 2001-02-16 21:29:45 +00:00
Brian Wellington
c47ca47629 Remove the old rndc config parser. 2001-02-16 00:47:45 +00:00
Andreas Gustafsson
5e1c2afd10 incorrect indentation 2001-02-15 19:09:55 +00:00
Brian Wellington
507102c95a In dns_compress_invalidate(), cctx->table cannot be NULL, since it's part of
the cctx structure.
2001-02-15 01:14:16 +00:00
Brian Wellington
2cb74c5bc5 741. [port] Support openssl-engine. [RT #709] 2001-02-14 20:57:15 +00:00
Brian Wellington
3d60fe9baf 740. [port] Handle openssl library mismatches slightly better. 2001-02-14 20:26:48 +00:00
Mark Andrews
0c6971b8ea Split the load context in two, one part that is visible across all files
the other part that is include file specific.
2001-02-14 13:14:50 +00:00
Andreas Gustafsson
65a66336a6 redid configuration locking using isc_task_beginexclusive()
and isc_task_endexclusive() instead of a multitude of separate
configuration rwlocks
2001-02-14 03:54:53 +00:00
Andreas Gustafsson
1dd8ee4fd5 fctx_addopt() would leak an rdataset if dns_message_setopt() ever failed;
fixed it by making dns_message_setopt() guarantee to either adopt
or free the rdataset
2001-02-14 02:51:12 +00:00
Brian Wellington
8766351a67 general cleanup 2001-02-14 00:43:10 +00:00
Andreas Gustafsson
d156c10aee removed extra empty line 2001-02-14 00:29:16 +00:00
Andreas Gustafsson
8f17525ebc in some situations, a request could be cancelled twice 2001-02-13 21:06:25 +00:00
Brian Wellington
b2c46df291 A receive could be erroneously cancelled because of missing braces around a
block.
2001-02-13 20:21:52 +00:00
Brian Wellington
f24c135e09 738. [bug] If a non-threadsafe sdb driver supported AXFR and
received an AXFR request, it would deadlock or die
                        with an assertion failure.
(also some other cleanups)
2001-02-13 20:11:15 +00:00
Brian Wellington
100d0d2ec6 Use a refcount instead of an explicit mutex and integer. 2001-02-13 03:57:06 +00:00
Andreas Gustafsson
8126e45e8c do dns_request_t cancel processing through a control event to
ensure that dns_dispatch_removeresponse() is called from the correct task
[RT #844]
2001-02-13 02:49:07 +00:00
Brian Wellington
4ce1248f09 fixed uninitialized variable 2001-02-13 01:29:33 +00:00