Commit graph

1320 commits

Author SHA1 Message Date
Mark Andrews
097dc0a693 add sys/types.h for FreeBSD 2.1 2001-05-18 03:02:45 +00:00
Andreas Gustafsson
d76b6ae2ad isc_print_vsnprintf() could throw an assertion failure when
given a %lld format, causing a deadlock when logging the assertion if invoked
from the logging system.  Since the %qd format does not have the bug, this only
affects platforms where the native quad format is %lld and that lack a native
vsnprintf().  The only known such platform is SunOS 5.5.1. [RT #1312]
2001-05-16 00:52:55 +00:00
Andreas Gustafsson
740ae0808f when returning a socket error, use isc__errno2result() instead
of always returning ISC_R_UNEXPECTED
2001-05-14 23:58:33 +00:00
Andreas Gustafsson
fd5847ef09 828. [bug] The errno value from recvfrom() could be overwritten
by logging code. [RT #1293]
2001-05-14 18:20:03 +00:00
Andreas Gustafsson
c3ebcedbe5 Add isc_file_progname(), with trivial POSIX implementation, and
call it from main().  A separate WIN32 implementation will be needed.
2001-05-08 19:47:55 +00:00
Brian Wellington
d144ea1d1c isc_file_basename should return a (const char *) 2001-05-05 02:47:21 +00:00
Brian Wellington
f2194a8ba9 implement isc_file_basename() 2001-05-03 18:59:30 +00:00
Andreas Gustafsson
1ed0723a1f a pointer argument used to return an "int" value into an "int"
variable is better defined as "int *" than "unsigned int *"
2001-04-28 01:08:07 +00:00
Andreas Gustafsson
5e194abb5b 814. [bug] Socket objects left over from accept() failures
were incorrectly destroyed, causing corruption
                        of socket manager data structures.

 813.   [bug]           File descriptors exceeding FD_SETSIZE were handled
                        badly. [RT #1192]
2001-04-26 23:45:55 +00:00
David Lawrence
2b5f436aeb Make greatest_version() return an isc_result_t, which it should have
been doing all along since there was the possibility isc_dir_open() would
fail and overloading the return value of "0" was bad practice.

If isc_dir_open() fails in greatest_version(), make sure the path separator
is restored to the destination pathname if it was NULified before returning
the error.

The underlying problem of isc_log_open() not having the bad result of
isc_dir_open() reported anywhere will be slightly mediate by a change
to bin/named/logconf.c to test the directory.  lib/isc/log.c can't really
handle it because it has no idea to where such an error should be reported,
and it only shows up during isc_log_open() as part of the isc_log_write()
family of calls, which are all void.
2001-04-25 23:59:44 +00:00
Andreas Gustafsson
0dc1e14537 alphabetized includes 2001-04-24 18:40:07 +00:00
David Lawrence
1bd5b8aac6 use ISC_MAGIC to define magic number 2001-04-17 14:36:45 +00:00
David Lawrence
79ed194592 sigh. always test recompile things even after a minor change. after deciding
to _not_ much with the lock tracing/printing facility for the last change,
i forgot to also add the new result variable back into the stack
declarations, where i had correctly put it the first time.
2001-04-17 13:42:32 +00:00
David Lawrence
8e60ba90e0 unlock the mutex when non-blocking locking is attempted and the lock is busy. 2001-04-17 04:07:38 +00:00
David Lawrence
900d7d9c9b forgot to actually change the macro call that needed the deconst argument 2001-04-14 00:20:07 +00:00
David Lawrence
ddb8f23a09 a different approach to shutting up compilers about an empty file, one that
does not cause all the compilers to complain about a variable being
defined but not used.
2001-04-13 02:26:32 +00:00
David Lawrence
79b19f175c added a single static variable declaration to prevent compilers from
complainig about an effectively empty input file.
2001-04-12 22:26:41 +00:00
David Lawrence
de6fe5ebe2 cleared up a const issue with IN6_IS_ADDR_V4MAPPED on some platforms 2001-04-12 21:23:21 +00:00
David Lawrence
6f053cd485 use ISC_TF() to set an isc_boolean_t 2001-04-12 21:04:14 +00:00
David Lawrence
3507ae5d59 #include <time.h> for the utimes() prototype 2001-04-12 19:46:39 +00:00
Andreas Gustafsson
7900390a52 Previous change turned invalid peer address returns from accept()
into hard errors - they should be soft errors
2001-04-10 21:48:27 +00:00
Andreas Gustafsson
a84cfaa3f2 The bug fix in socket.c 1.189 was less than ideal: if a socket
got wedged in a state where accept() always returns EBADF, the server would loop calling
internal_accept() repeatedly.  Implemented an alternative fix where a hard
error in accept() causes an event with a nonzero result code to be sent, and
the new socket object to be freed
2001-04-10 21:38:33 +00:00
Brian Wellington
f8b3c62794 804. [bug] Attempting to obtain entropy could fail in some
situations.  This would be most common on systems
			with user-space threads. [RT #1131]
2001-04-04 20:57:35 +00:00
Brian Wellington
672056d560 797. [func] Issue a warning if the 'directory' option contains
a relative path. [RT #269]
2001-03-29 02:33:48 +00:00
David Lawrence
2a86ee1f54 simplify the test about whether to roll; one expression was redundant 2001-03-28 05:48:16 +00:00
David Lawrence
9027e1bcf1 796. [func] When a size limit is associated with a log file,
only roll it when the size is reached, not every
			time the log file is opened. [RT #1096]
2001-03-28 04:16:32 +00:00
Brian Wellington
1d92d8a245 792. [cleanup] Replace the OMAPI command channel protocol with a
simpler one.
2001-03-27 00:44:59 +00:00
Brian Wellington
6eccf5bd07 788. [feature] Add the "match-mapped-addresses" options, which
causes IPv6 v4mapped addresses to be treated as
			IPv4 addresses for the purpose of acl matching.
2001-03-26 21:33:07 +00:00
Andreas Gustafsson
9efa0d2ae3 do not capitalize error message strings 2001-03-24 02:18:42 +00:00
Brian Wellington
734ae1f7c6 isc_{base64|hex}_decodestring took an unused mctx. Remove the mctx. 2001-03-22 00:07:07 +00:00
Brian Wellington
48565891e8 784. [bug] nsupdate and other programs would not quit properly
if some signals were blocked by the caller. [RT #1081]
2001-03-20 21:45:20 +00:00
Brian Wellington
dde4382b7f fix comment 2001-03-19 22:44:52 +00:00
Brian Wellington
2f02f32f04 exit(1), not exit(-1) 2001-03-14 06:31:17 +00:00
Bob Halley
c6237585d8 Fix some typos in the non-threaded version of isc_rwlock_trylock() that
were preventing compilation.
2001-03-08 19:52:13 +00:00
David Lawrence
a82fd2c01b added non-blocking locking, isc_rwlock_trylock() 2001-03-08 00:55:15 +00:00
Andreas Gustafsson
d55642259e use a simpler, faster hash function 2001-03-07 23:52:16 +00:00
Brian Wellington
2eb3dafdcf Add the socket flag ISC_R_NORETRY, which makes the socket code treat
a soft error as a hard error on send (that is, not retry it).  It also
modifies the code calling sendmsg() to retry on EINTR.
2001-03-06 01:23:03 +00:00
Danny Mayer
943322a123 Remove LIBISC_EXTERNAL_DATA usage 2001-03-05 18:47:00 +00:00
Danny Mayer
8096fe1df5 put function declaration on new line 2001-03-05 18:20:24 +00:00
David Lawrence
c56c28c3f2 grammatical typo in comment 2001-03-05 12:34:02 +00:00
Brian Wellington
303243b9d4 Add isc/unix/syslog.c with a function to convert strings to syslog facilities. 2001-03-02 19:25:19 +00:00
Brian Wellington
a8dd4ccadb missing space 2001-03-01 22:40:09 +00:00
Andreas Gustafsson
28a3d52904 define ISC_PLATFORM_QUADFORMAT in platform.h so that it can more easily
be overridden on Win32.  This means ISC_PLATFORM_LONGLONGEQUALLONG is no longer
needed. [RT #896]
2001-02-27 02:22:17 +00:00
Andreas Gustafsson
c05eeed3c9 754. [bug] Certain failure returns from sendto() could
cause the server to retry the transmission
                        indefinitely. [RT #902]
2001-02-24 23:51:09 +00:00
Mark Andrews
70ec7dd741 fix tv_usec in isc_time_nowplusinterval() also. 2001-02-24 10:22:20 +00:00
Mark Andrews
0fd53e151b unse not sec 2001-02-24 02:53:38 +00:00
Mark Andrews
df0f58959e 752. [func] Correct bad tv_usec elements returned by gettimeofday(). 2001-02-23 23:12:28 +00:00
Andreas Gustafsson
042285a6a6 localization-wise, an assertion error message saying
(literally) "INSIST(isc_msgcat_get(isc_msgcat, ISC_MSGSET_PRINT, ISC_MSG_USELD,
"use %ld instead of %D") == NULL) failed" is not really any more user-friendly
than one saying just "INSIST("use %ld instead of %D" == NULL) failed
2001-02-22 19:12:57 +00:00
Andreas Gustafsson
9165c95fc2 use isc_int64_t, not long long 2001-02-22 18:03:11 +00:00
Andreas Gustafsson
4115f9d34b revert 'protect long long with ISC_PLATFORM_HAVELONGLONG' change 2001-02-22 18:01:48 +00:00