Commit graph

2441 commits

Author SHA1 Message Date
James Brister
a4ed9791ed code review changes. 2000-03-16 23:51:09 +00:00
Brian Wellington
8732b497cf formatting changes during code review 2000-03-16 23:40:50 +00:00
Brian Wellington
5766ea1011 Avoid calling dst_verify with an empty region 2000-03-16 23:13:25 +00:00
Andreas Gustafsson
691b60f24e return zero-length signature/other data as zero-sized
isc_mem_get() blocks, not NULL pointers
2000-03-16 23:13:02 +00:00
James Brister
c559e42c7e Uninitialized variable fixed. 2000-03-16 22:53:37 +00:00
Bob Halley
d4a4b9ffd6 add dst_key_iszonekey, KEYFLAG and KEYPROTO values 2000-03-16 22:43:54 +00:00
Bob Halley
9dcab19457 add dst_key_iszonekey 2000-03-16 22:43:33 +00:00
Bob Halley
1db2e6b81a rdata code review 2000-03-16 22:42:32 +00:00
Andreas Gustafsson
76e9eb5ba6 document relevant RFC number 2000-03-16 22:42:31 +00:00
Andreas Gustafsson
1c497c6e34 in fromwire_opt, the option field was used as both
option and length; stylistic changes from code review
2000-03-16 22:42:10 +00:00
Bob Halley
6a02971368 don't define ISC_MEMPOOL_NAMES 2000-03-16 22:40:48 +00:00
Bob Halley
2190526544 Allow zero length allocations/deallocations. 2000-03-16 22:39:46 +00:00
Michael Graff
940e4ef72b add reviewed, minor formatting changes 2000-03-16 22:07:28 +00:00
Michael Graff
325f2a0960 add reviewed by, and minor formatting nits 2000-03-16 21:58:58 +00:00
Andreas Gustafsson
954f31569c code review 2000-03-16 21:50:14 +00:00
Brian Wellington
763340ccb3 Rewrote handling of the NULL record to match RFC 1035 2000-03-16 21:49:42 +00:00
Mark Andrews
acb0311b11 dns_message_renderreset should cause the message to forget the render
buffer.
2000-03-16 06:51:04 +00:00
David Lawrence
659c68b446 Reviewed.
use UNUSED() macros.
2000-03-16 02:31:14 +00:00
James Brister
ecd3b66f8c code review changes 2000-03-16 02:23:17 +00:00
Michael Graff
923d996a97 no local, comment NONE or GLOBAL14 2000-03-16 02:20:19 +00:00
Michael Graff
f4b24db598 mostly UNUSED() changes, minor formatting things 2000-03-16 02:18:16 +00:00
Brian Wellington
5fe1a9797c code review 2000-03-16 02:16:16 +00:00
David Lawrence
8cb85014a7 added Reviewed comment 2000-03-16 02:15:52 +00:00
Brian Wellington
c363150ad5 more code review 2000-03-16 02:08:51 +00:00
James Brister
96805adfc9 code review changes 2000-03-16 02:07:06 +00:00
James Brister
ce8b84ce64 more code review changes. 2000-03-16 02:00:37 +00:00
Brian Wellington
c2bb855911 code review 2000-03-16 01:44:08 +00:00
David Lawrence
926234e867 In fromtext_cert:
.	removed strtol which was irrelevant (its results were not checked,
	and dns_cert_fromtext did the real parsing).
      . removed redundant range checking (uint16_tobuffer did the same
	checking.
Use UNUSED() macro.
draft-ietf-dnssec-certs-04.txt -> RFC 2538
2000-03-16 01:43:42 +00:00
James Brister
3b811bd920 code review changes 2000-03-16 01:40:27 +00:00
James Brister
ee7cac1c6e code review changes. 2000-03-16 01:37:14 +00:00
James Brister
4f64d3ae93 code review changes 2000-03-16 01:31:03 +00:00
Brian Wellington
d5c518af63 code review 2000-03-16 01:26:49 +00:00
James Brister
ec04f989ea code review changes 2000-03-16 01:15:36 +00:00
Brian Wellington
d0fe07af9c code review 2000-03-16 00:54:24 +00:00
Michael Graff
f72fbb5d0b formatting changes, and addition of UNUSED() where needed 2000-03-16 00:53:01 +00:00
Michael Graff
5d3cca55eb s/reviewed:/Reviewed:/ 2000-03-16 00:48:08 +00:00
Michael Graff
e1cc8e9a08 changes after code review 2000-03-16 00:18:29 +00:00
Michael Graff
b206fa17b2 allocate space for cmsg more correctly. Grr. 2000-03-15 20:05:06 +00:00
Michael Graff
788354c051 Currently, descriptors with changes are sent to the watcher via a pipe.
Previously, both ends were set to non-blocking I/O.  Now, only the
reader is set non-blocking.  This means the writer will block for a while
if the pipe fills, but since the watcher is in a different thread from
the reader, the pipe will eventually drain, and the writer can continue.

This is really nothing more than a lock, just not a mutex-type lock.
2000-03-15 19:48:11 +00:00
Brian Wellington
c600d821ec The hmac-md5 private key file was being written incorrectly. 2000-03-15 18:52:23 +00:00
James Brister
1cb2280cc3 Build ndc config parser> 2000-03-15 02:13:36 +00:00
James Brister
c0536aa152 ndc config parser and test program 2000-03-15 02:11:57 +00:00
Brian Wellington
948716c24c Certain errors caused failure but didn't set the return value. 2000-03-14 22:05:08 +00:00
David Lawrence
0eebe5cfe3 only call shutdown callback if non-NULL 2000-03-14 20:06:08 +00:00
David Lawrence
3dbebbfe6e use 0 not NULL in dst_key_frombuffer 2000-03-14 20:00:37 +00:00
Bob Halley
4dcfb5fb22 lint 2000-03-14 19:27:55 +00:00
David Lawrence
d8d0c5b1bc explitictly REQUIRE that reqaddr is non-null in dns_acl_match 2000-03-14 04:01:52 +00:00
David Lawrence
06671f242e specify exit callbacks for listener, added omapi_data_strdup 2000-03-14 03:59:14 +00:00
David Lawrence
c662d88c3e auth support 2000-03-14 03:58:30 +00:00
David Lawrence
7194c96d03 use DNS_INCLUDES; compile auth.c 2000-03-14 03:57:55 +00:00