Commit graph

3155 commits

Author SHA1 Message Date
Michael Sawyer
c7868e2262 Modify dns_message_totext, dns_message_sectiontotext,
dns_message_pseudosectiontotext to use bitfields instead of flags
2000-05-24 18:17:53 +00:00
Brian Wellington
19d1b1667d notify and zone soa queries are now tsig signed when appropriate. 2000-05-24 17:30:41 +00:00
David Lawrence
20b20b2394 202. [func] isc_lex_getsourceline() changed from returning int
to returning unsigned long, the type of its underlying
                        counter.
2000-05-24 15:07:59 +00:00
David Lawrence
03a0fca86d define and use LWRES_SOCKADDR_LEN_T for recvfrom() and stop compiler warnings
by casting the sixth parameter of recvfrom() to void *, as with
lib/isc/unix/socket.c.
2000-05-24 05:22:36 +00:00
David Lawrence
ed019cabc1 fixed lines > 79 columns wide 2000-05-24 05:10:00 +00:00
David Lawrence
2fda9d9e1b conform wrapper symbol to ISC style. include isc/result.h for isc_result_t. 2000-05-24 04:59:02 +00:00
David Lawrence
81064d6419 dns/result.h and dns/compress.h removed from t_api.h 2000-05-24 04:56:32 +00:00
David Lawrence
fe56f2116b dns/result.h and dns/compress.h removed from t_api.h 2000-05-24 03:45:00 +00:00
David Lawrence
5e09ded492 cast assignment of confdata->ndots to lwres_uint8_t (its type). it was already
being range checked.
2000-05-24 03:02:16 +00:00
David Lawrence
695c2f9ba1 range check assignment of uint16 "id" in dst_key_parsefilename 2000-05-24 03:00:39 +00:00
David Lawrence
94bd549175 updated comments with regards to chains and parent pointers, and added caveat
about what happens with "name" and "origin" parameters when a chain
points to ".".
2000-05-24 02:56:26 +00:00
David Lawrence
1d198e8a6b removed unused stack variable sigrdataset from authvalidated() 2000-05-24 02:47:15 +00:00
David Lawrence
16996a0488 quiet the irix compiler about uses of the COMPARE()
macro in dns_rdataclass_fromtext by using an intermediate variable
to hold the constant 2nd argument in each use.

added the RESERVED attribute to the reserved0 class in the same function.
2000-05-24 02:45:08 +00:00
David Lawrence
2e4ad2f406 removed unreachable break statements that followed return statements 2000-05-24 02:42:03 +00:00
David Lawrence
cf479fdc6b removed unused static function violate_locking_hierarchy 2000-05-24 02:41:03 +00:00
David Lawrence
604a596b5f added an UNUSED() to shut up the irix compiler. 2000-05-24 02:39:01 +00:00
David Lawrence
77685300d9 cast isc_time_seconds to long when assigning to a timeval.tv_sec, and explain
why this is an ok thing to do.  shuts up the irix compiler.
2000-05-24 02:36:49 +00:00
David Lawrence
389b5c8593 added a sync_channellist call to isc_log_create to ensure the channellist in
the logconfig is properly dimensioned, and only free the channellist
memory in isc_logconfig_destroy if the channellist_count is > 0.
the first addresses a problem that could occur when a successful
isc_log_create was followed immediately by isc_log_[v]write[1] or
isc_log_destroy (with no intervening isc_log_usechannel or
isc_logconfig_use), and the second addresses a problem that could
occur in cleanup if isc_log_create or isc_logconfig_create failed.
2000-05-24 02:33:16 +00:00
Brian Wellington
fc16635d3c remove a memory leak 2000-05-23 23:36:39 +00:00
Brian Wellington
41faaa9b35 If an incoming message contains a SIG(0), store the rdataset owner name
in the message structure, even though it should be the root.  Also,
return this name in dns_message_getsig0().
2000-05-23 23:35:54 +00:00
Brian Wellington
e6d420aea9 In dns_name_totext, if omit_final_dot is true and the name is the root,
override omit_final_dot and print "."
2000-05-23 23:34:40 +00:00
Andreas Gustafsson
875ad7d99d when reloading the server, zone objects reused with a new
view object still referenced their old view
2000-05-23 04:38:22 +00:00
Michael Graff
862d18c79a set ifindex to 0 for outgoing udp ipv6 datagrams. 2000-05-23 02:51:39 +00:00
Michael Graff
5cc49bc70c don't set permanent failure on udp sockets, even on unexpected error 2000-05-23 02:20:23 +00:00
Brian Wellington
81b438273a Commented hard to understand behavior in dns_message_signer 2000-05-23 00:23:42 +00:00
Mark Andrews
00b67c06b9 Add contract notes for dns_requestmgr_{attach,detach}(). 2000-05-23 00:11:45 +00:00
Brian Wellington
c637772ac3 Attempting to delete a SIG set with dynamic update crashed the server. 2000-05-23 00:09:09 +00:00
Brian Wellington
82efeeb703 removed typo 2000-05-22 23:34:24 +00:00
Brian Wellington
7e8dd00fce More tsig rdatastruct problems fixed 2000-05-22 23:17:22 +00:00
Andreas Gustafsson
b291fec7c9 offset.h was not installed by 'make install' 2000-05-22 22:46:53 +00:00
Michael Sawyer
54229947d3 Change strlen to sizeof. 2000-05-22 22:41:24 +00:00
Andreas Gustafsson
1ac4b2a1da when printing a SIG record with covers==0, print it as 0,
not RESERVED0
2000-05-22 21:42:47 +00:00
Michael Sawyer
1ed4ba5a1f Add pseudosection printing, and dns_message_pseudosectiontotext(). 2000-05-22 21:22:06 +00:00
Brian Wellington
feb40fc5f9 keytag collision handling was broken and a memory leak existed in the error
handling code.
2000-05-22 21:17:05 +00:00
Andreas Gustafsson
bac6f7fd14 the comments for isc_ratelimiter_create() said the
events are executed in the context of 'task'; this is no longer true
2000-05-22 19:47:43 +00:00
Andreas Gustafsson
34b26adb24 heap invariant INSIST did the wrong thing in the border case
of a heap item and its parent having identical priority
2000-05-22 19:47:01 +00:00
Andreas Gustafsson
b68f341a48 must include <isc/print.h> to use snprintf 2000-05-22 19:29:09 +00:00
Andreas Gustafsson
cd01c9716f Reintroduced separate internal/external reference counts for zones,
reversing part of the changes made on 2000/05/17.  Doing an explicit
zone shutdown on destruction of the zone table caused the zone to
be shut down prematurely on server reload when the zone table was
destroyed but the zone had already been attached to a new zone table.
An external reference count is needed to correctly handle this situation.
2000-05-22 17:23:15 +00:00
Michael Graff
a330a4b008 only set permanent failure for tcp streams on sending 2000-05-22 16:56:12 +00:00
Mark Andrews
373ce67419 Implement dns_rdata_fromstruct() where not already done.
Add missing REQUIRE tests to existing implementations.
2000-05-22 12:38:12 +00:00
Mark Andrews
0103f42343 Add comment about requiring pointers to memory block to be NULL if the
corresponding length is 0, non-NULL otherwise.
2000-05-22 12:34:16 +00:00
Andreas Gustafsson
e996ff2d5b print isc_time_t fields using %u, not %lu 2000-05-22 03:07:47 +00:00
Andreas Gustafsson
4c94069644 199. [bug] isc_heap_delete() sometimes violated the heap
invariant, causing timer events not to be posted
			when due.

Specifically, isc_heap_delete() moved the last element of the heap to
the vacated position and then attempted to restore the heap invariant
by calling sink_down().  This works when the last element has a lower
priority than the one being deleted, and this is often the case
because the last element tends to have a low priority.  However, it is
not guaranteed to be the lowest.  When deleting an item of a lower
priority than the last item, restoring the invariant requires a call
to float_up(), not sink_down().

isc_heap_delete_now calls either float_up() or sink_down() as needed,
and INSISTs have been added to verify that the heap invariant indeed
holds after the calls.
2000-05-22 02:53:52 +00:00
Andreas Gustafsson
be8d4578da zone_xferdone() assigned the updated zone expiry time to the wrong variable
zone->expire instead of zone->expiretime.  This left zone->expiretime
with a value of zero, causing zone_settimer() to get horribly confused
and set the timer to the inactive state (!).  This in turn caused
notify-driven refreshes (and probably other timer-scheduled events, too)
to never happen.
2000-05-20 21:24:41 +00:00
Brian Wellington
d1eee46938 fixes to dns_message_sectiontotext for the question section 2000-05-20 02:00:29 +00:00
Michael Graff
19591ace46 reload zone housekeeping information on AXFR/IXFR 2000-05-20 01:32:46 +00:00
Michael Graff
341323e0e7 move dns_db_getsoaserial() from journal.c to db.c 2000-05-20 01:32:03 +00:00
Michael Graff
24d3d0ecff fix a slight documentation bug 2000-05-20 01:30:16 +00:00
Michael Sawyer
9dca36b2ab Remove unused no_rdata_or_ttl flag from message_totext and message_sectiontotest routines. 2000-05-20 01:29:58 +00:00
Brian Wellington
fa686a7235 removed more invalid _freestruct calls 2000-05-20 01:27:28 +00:00