upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Remove unnecessary NULL pointer check

Browse source 
3034                next = ISC_LIST_NEXT(query, link);
    3035        } else {
    3036                next = NULL;
    3037        }

    CID 352554 (#1 of 1): Dereference before null check (REVERSE_INULL)
    check_after_deref: Null-checking connectquery suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
    3038        if (connectquery != NULL) {
    3039                query_detach(&connectquery);
    3040        }

(cherry picked from commit 30f3d51368)
This commit is contained in:
Mark Andrews 2022-05-02 12:12:36 +10:00
parent c0282b7d56
commit fde1294d05
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bin/dig/dighost.c
View file

@ -3034,9 +3034,7 @@ failure_tls:
} else {
next = NULL;
}
if (connectquery != NULL) {
query_detach(&connectquery);
}
query_detach(&connectquery);
query_detach(&query);
if (next == NULL) {
clear_current_lookup();