From 9fa4bd1c1bad55b1a2f11801a1b722266daaaf77 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Wed, 11 Dec 2024 13:32:18 +1100 Subject: [PATCH] Fix startup notify rate test The terminating conditions for the startup notify test would occasionally get ~20 records or get +10 seconds of records due to a bad terminating condition. Additionally 20 samples lead to test failures. Fix the terminating condition to use the correct conditional (-eq -> -ge) and increase the minimum number of log entries to average over to 22. (cherry picked from commit 46388d07a2849d8f82d52d334caf09c986daa27c) --- bin/tests/system/notify/tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/tests/system/notify/tests.sh b/bin/tests/system/notify/tests.sh index befa841afc..c83d076308 100644 --- a/bin/tests/system/notify/tests.sh +++ b/bin/tests/system/notify/tests.sh @@ -46,7 +46,7 @@ for i in 1 2 3 4 5 6 7 8 9 10; do grep "status: NOERROR" dig.out.ns3.test$n >/dev/null || ret=1 grep "flags:.* aa[ ;]" dig.out.ns3.test$n >/dev/null || ret=1 nr=$(grep -c 'x[0-9].*sending notify to' ns2/named.run) - [ "$nr" -eq 20 ] || ret=1 + [ "$nr" -ge 22 ] || ret=1 [ $ret = 0 ] && break sleep 1 done @@ -94,7 +94,7 @@ END { print "count:", count; print "average:", average; if (average < 0.180) exit(1); - if (count < 20) exit(1); + if (count < 22) exit(1); }' ns2/named.run >awk.out.ns2.test$n || ret=1 test_end