upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge branch 'ondrej/scan-build-10-fixes-v9_11-v9_14' into 'v9_14'

Browse source 
Fix new warnings reported by scan-build from LLVM/Clang 10 (v9.14)

See merge request isc-projects/bind9!3290
This commit is contained in:
Ondřej Surý 2020-03-25 17:28:28 +00:00
commit fc1bd06eac
4 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
bin/rndc/rndc.c
View file

@ -249,6 +249,8 @@ get_addresses(const char *host, in_port_t port) {
isc_result_t result;
int found = 0, count;
REQUIRE(host != NULL);
if (*host == '/') {
result = isc_sockaddr_frompath(&serveraddrs[nserveraddrs],
host);
@ -990,8 +992,9 @@ main(int argc, char **argv) {
if (strcmp(command, "restart") == 0)
fatal("'%s' is not implemented", command);
if (nserveraddrs == 0)
if (nserveraddrs == 0 && servername != NULL) {
get_addresses(servername, (in_port_t) remoteport);
}
DO("post event", isc_app_onrun(rndc_mctx, task, rndc_start, NULL));

1
bin/tests/optional/byname_test.c
View file

@ -312,6 +312,7 @@ main(int argc, char *argv[]) {
isc_sockaddr_fromin(&sa, &ina, 53);
ISC_LIST_APPEND(sal, &sa, link);
REQUIRE(DNS_VIEW_VALID(view));
RUNTIME_CHECK(dns_fwdtable_add(view->fwdtable, dns_rootname,
&sal, dns_fwdpolicy_only)
== ISC_R_SUCCESS);

4
lib/dns/openssleddsa_link.c
View file

@ -518,7 +518,6 @@ static bool
openssleddsa_isprivate(const dst_key_t *key) {
EVP_PKEY *pkey = key->keydata.pkey;
int len;
unsigned long err;
if (pkey == NULL)
return (false);
@ -527,8 +526,9 @@ openssleddsa_isprivate(const dst_key_t *key) {
if (len > 0)
return (true);
/* can check if first error is EC_R_INVALID_PRIVATE_KEY */
while ((err = ERR_get_error()) != 0)
while (ERR_get_error() != 0) {
/**/;
}
return (false);
}

3
lib/dns/rpz.c
View file

@ -1114,7 +1114,8 @@ trim_zbits(dns_rpz_zbits_t zbits, dns_rpz_zbits_t found) {
x = zbits & found;
x &= (~x + 1);
x = (x << 1) - 1;
return (zbits &= x);
zbits &= x;
return (zbits);
}
/*