From b0164adcfdbe1111aa5c733ee4ec4293343d47f7 Mon Sep 17 00:00:00 2001 From: Andoni Duarte Pintado Date: Mon, 8 Dec 2025 18:16:19 +0100 Subject: [PATCH 1/4] Generate changelog for BIND 9.18.43 --- doc/arm/changelog.rst | 1 + doc/changelog/changelog-9.18.43.rst | 61 +++++++++++++++++++++++++++++ 2 files changed, 62 insertions(+) create mode 100644 doc/changelog/changelog-9.18.43.rst diff --git a/doc/arm/changelog.rst b/doc/arm/changelog.rst index 105fb4dc1d..ad7a7c128a 100644 --- a/doc/arm/changelog.rst +++ b/doc/arm/changelog.rst @@ -18,6 +18,7 @@ Changelog development. Regular users should refer to :ref:`Release Notes ` for changes relevant to them. +.. include:: ../changelog/changelog-9.18.43.rst .. include:: ../changelog/changelog-9.18.42.rst .. include:: ../changelog/changelog-9.18.41.rst .. include:: ../changelog/changelog-9.18.40.rst diff --git a/doc/changelog/changelog-9.18.43.rst b/doc/changelog/changelog-9.18.43.rst new file mode 100644 index 0000000000..08efe7e87f --- /dev/null +++ b/doc/changelog/changelog-9.18.43.rst @@ -0,0 +1,61 @@ +.. Copyright (C) Internet Systems Consortium, Inc. ("ISC") +.. +.. SPDX-License-Identifier: MPL-2.0 +.. +.. This Source Code Form is subject to the terms of the Mozilla Public +.. License, v. 2.0. If a copy of the MPL was not distributed with this +.. file, you can obtain one at https://mozilla.org/MPL/2.0/. +.. +.. See the COPYRIGHT file distributed with this work for additional +.. information regarding copyright ownership. + +BIND 9.18.43 +------------ + +New Features +~~~~~~~~~~~~ + +- Add spatch to detect implicit bool/int/result cast. ``cce6c2dd0c`` + + Detection of implicit cast from a boolean into an int, or an + isc_result_t into a boolean (either in an assignement or return + position). + + If such pattern is found, a warning comment is added into the code + (and the CI will fails) so the error can be spotted and manually + fixed. :gl:`!11238` + +Bug Fixes +~~~~~~~~~ + +- AMTRELAY type 0 presentation format handling was wrong. ``e5025baf93`` + + RFC 8777 specifies a placeholder value of "." for the gateway field + when the gateway type is 0 (no gateway). This was not being checked + for nor emitted when displaying the record. This has been corrected. + + Instances of this record will need the placeholder period added to + them when upgrading. :gl:`#5639` :gl:`!11256` + +- Adding NSEC3 opt-out records could leave invalid records in chain. + ``335be0e079`` + + When creating an NSEC3 opt-out chain, a node in the chain could be + removed too soon, causing the previous NSEC3 being unable to be found, + resulting in invalid NSEC3 records to be left in the zone. This has + been fixed. :gl:`#5671` :gl:`!11341` + +- Standardize CHECK and RETERR macros. ``83163f39d5`` + + previously, there were over 40 separate definitions of CHECK macros, + of which most used "goto cleanup", and the rest "goto failure" or + "goto out". there were another 10 definitions of RETERR, of which most + were identical to CHECK, but some simply returned a result code + instead of jumping to a cleanup label. + + this has now been standardized throughout the code base: RETERR is for + returning an error code in the case of an error, and CHECK is for + jumping to a cleanup tag, which is now always called "cleanup". both + macros are defined in isc/util.h. :gl:`!11080` + + From 57294ba705705a1634c501a255fac30cb2ee10ae Mon Sep 17 00:00:00 2001 From: Andoni Duarte Pintado Date: Tue, 9 Dec 2025 09:46:56 +0100 Subject: [PATCH 2/4] Prepare release notes for BIND 9.18.43 --- doc/arm/notes.rst | 1 + doc/notes/notes-9.18.43.rst | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) create mode 100644 doc/notes/notes-9.18.43.rst diff --git a/doc/arm/notes.rst b/doc/arm/notes.rst index 2b620ed1d2..2f32c5622c 100644 --- a/doc/arm/notes.rst +++ b/doc/arm/notes.rst @@ -45,6 +45,7 @@ The list of known issues affecting the latest version in the 9.18 branch can be found at https://gitlab.isc.org/isc-projects/bind9/-/wikis/Known-Issues-in-BIND-9.18 +.. include:: ../notes/notes-9.18.43.rst .. include:: ../notes/notes-9.18.42.rst .. include:: ../notes/notes-9.18.41.rst .. include:: ../notes/notes-9.18.40.rst diff --git a/doc/notes/notes-9.18.43.rst b/doc/notes/notes-9.18.43.rst new file mode 100644 index 0000000000..21c7c13112 --- /dev/null +++ b/doc/notes/notes-9.18.43.rst @@ -0,0 +1,34 @@ +.. Copyright (C) Internet Systems Consortium, Inc. ("ISC") +.. +.. SPDX-License-Identifier: MPL-2.0 +.. +.. This Source Code Form is subject to the terms of the Mozilla Public +.. License, v. 2.0. If a copy of the MPL was not distributed with this +.. file, you can obtain one at https://mozilla.org/MPL/2.0/. +.. +.. See the COPYRIGHT file distributed with this work for additional +.. information regarding copyright ownership. + +Notes for BIND 9.18.43 +---------------------- + +Bug Fixes +~~~~~~~~~ + +- AMTRELAY type 0 presentation format handling was wrong. + + RFC 8777 specifies a placeholder value of "." for the gateway field + when the gateway type is 0 (no gateway). This was not being checked + for nor emitted when displaying the record. This has been corrected. + + Instances of this record will need the placeholder period added to + them when upgrading. :gl:`#5639` + +- Adding NSEC3 opt-out records could leave invalid records in chain. + + When creating an NSEC3 opt-out chain, a node in the chain could be + removed too soon, causing the previous NSEC3 being unable to be found, + resulting in invalid NSEC3 records to be left in the zone. This has + been fixed. :gl:`#5671` + + From 49ca02f174f06e92e686f23b1ce5e682b44f8a9d Mon Sep 17 00:00:00 2001 From: Andoni Duarte Pintado Date: Tue, 9 Dec 2025 09:47:21 +0100 Subject: [PATCH 3/4] Tweak and reword release notes --- doc/notes/notes-9.18.43.rst | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/doc/notes/notes-9.18.43.rst b/doc/notes/notes-9.18.43.rst index 21c7c13112..1876023035 100644 --- a/doc/notes/notes-9.18.43.rst +++ b/doc/notes/notes-9.18.43.rst @@ -15,20 +15,19 @@ Notes for BIND 9.18.43 Bug Fixes ~~~~~~~~~ -- AMTRELAY type 0 presentation format handling was wrong. +- Adding NSEC3 opt-out records could leave invalid records in chain. - RFC 8777 specifies a placeholder value of "." for the gateway field - when the gateway type is 0 (no gateway). This was not being checked - for nor emitted when displaying the record. This has been corrected. + When creating an NSEC3 opt-out chain, a node in the chain could be + removed too soon. The previous NSEC3 would therefore not be found, + resulting in invalid NSEC3 records being left in the zone. This has + been fixed. :gl:`#5671` + +- ``AMTRELAY`` type 0 presentation format handling was wrong. + + :rfc:`8777` specifies a placeholder value of ``.`` for the gateway field + when the gateway type is 0 (no gateway). This was not being checked + for, nor was it emitted when displaying the record. This has been corrected. Instances of this record will need the placeholder period added to them when upgrading. :gl:`#5639` -- Adding NSEC3 opt-out records could leave invalid records in chain. - - When creating an NSEC3 opt-out chain, a node in the chain could be - removed too soon, causing the previous NSEC3 being unable to be found, - resulting in invalid NSEC3 records to be left in the zone. This has - been fixed. :gl:`#5671` - - From 25bf6c731c442f69c6a4034b36250051fef767fc Mon Sep 17 00:00:00 2001 From: Andoni Duarte Pintado Date: Thu, 11 Dec 2025 10:11:05 +0100 Subject: [PATCH 4/4] Update BIND version for release --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 48fa3241fd..957ed19b43 100644 --- a/configure.ac +++ b/configure.ac @@ -17,7 +17,7 @@ m4_define([bind_VERSION_MAJOR], 9)dnl m4_define([bind_VERSION_MINOR], 18)dnl m4_define([bind_VERSION_PATCH], 43)dnl -m4_define([bind_VERSION_EXTRA], -dev)dnl +m4_define([bind_VERSION_EXTRA], )dnl m4_define([bind_DESCRIPTION], [(Extended Support Version)])dnl m4_define([bind_SRCID], [m4_esyscmd_s([git rev-parse --short HEAD | cut -b1-7])])dnl m4_define([bind_PKG_VERSION], [[bind_VERSION_MAJOR.bind_VERSION_MINOR.bind_VERSION_PATCH]bind_VERSION_EXTRA])dnl