Provide an early escape hatch for ns_client_transport_type

Because some tests don't have a legtimate handle, provide a temporary
return early that should be fixed and removed before squashing. This
short circuiting is still correct until DoQ/DoH3 support is introduced.
This commit is contained in:
Aydın Mercan 2024-02-15 13:30:42 +03:00
parent b5478654a2
commit f30008a71c
No known key found for this signature in database

View file

@ -123,9 +123,19 @@ static void
compute_cookie(ns_client_t *client, uint32_t when, const unsigned char *secret,
isc_buffer_t *buf);
#ifdef HAVE_DNSTAP
static dns_transport_type_t
ns_client_transport_type(const ns_client_t *client) {
REQUIRE(client->handle != NULL);
/*
* Early escape hatch for libtest/ns.c
*
* When DoQ support this had to be removed to get correct DoQ entries.
*/
if (!TCP_CLIENT(client)) {
return DNS_TRANSPORT_UDP;
}
INSIST(client->handle != NULL);
switch (isc_nm_socket_type(client->handle)) {
case isc_nm_udpsocket:
@ -158,6 +168,7 @@ ns_client_transport_type(const ns_client_t *client) {
return DNS_TRANSPORT_UDP;
}
#endif /* HAVE_DNSTAP */
void
ns_client_recursing(ns_client_t *client) {