[v9_10] address valgrind warnings

4059.	[bug]		Addressed valgrind warnings. [RT #38549]
This commit is contained in:
Evan Hunt 2015-02-10 14:03:27 -08:00
parent a7db54206c
commit eb36da19e7
4 changed files with 7 additions and 3 deletions

View file

@ -1,3 +1,5 @@
4059. [bug] Addressed valgrind warnings. [RT #38549]
4058. [bug] UDP dispatches could use the wrong psuedorandom
number generator context. [RT #38578]

View file

@ -1039,7 +1039,7 @@ do_scan(ns_interfacemgr_t *mgr, ns_listenlist_t *ext_listen,
if (le->dscp != -1 && ifp->dscp == -1)
ifp->dscp = le->dscp;
else if (le->dscp != ifp->dscp) {
isc_sockaddr_format(&listen_addr,
isc_sockaddr_format(&listen_sockaddr,
sabuf,
sizeof(sabuf));
isc_log_write(IFMGR_COMMON_LOGARGS,

View file

@ -9339,7 +9339,7 @@ ns_server_signing(ns_server_t *server, char *args, isc_buffer_t *text) {
isc_boolean_t first = ISC_TRUE;
isc_boolean_t list = ISC_FALSE, clear = ISC_FALSE;
isc_boolean_t chain = ISC_FALSE;
char keystr[DNS_SECALG_FORMATSIZE + 7];
char keystr[DNS_SECALG_FORMATSIZE + 7]; /* <5-digit keyid>/<alg> */
unsigned short hash = 0, flags = 0, iter = 0, saltlen = 0;
unsigned char salt[255];
const char *ptr;
@ -9365,7 +9365,7 @@ ns_server_signing(ns_server_t *server, char *args, isc_buffer_t *text) {
ptr = next_token(&args, " \t");
if (ptr == NULL)
return (ISC_R_UNEXPECTEDEND);
memmove(keystr, ptr, sizeof(keystr));
strlcpy(keystr, ptr, sizeof(keystr));
} else if (strcasecmp(ptr, "-nsec3param") == 0) {
const char *hashstr, *flagstr, *iterstr;
char nbuf[512];

View file

@ -519,6 +519,8 @@ cmsgsend(int s, int level, int type, struct addrinfo *res) {
return (ISC_FALSE);
}
memset(&control, 0, sizeof(control));
iovec.iov_base = buf;
iovec.iov_len = sizeof(buf);