upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-02-26 19:41:04 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

silence coverity warnings

Browse source
This commit is contained in:
Mark Andrews 2014-07-02 15:28:02 +10:00
parent 7dbd309799
commit e58154a6ec
3 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
bin/dnssec/dnssec-revoke.c
View file

@ -263,12 +263,10 @@ main(int argc, char **argv) {
dst_key_buildfilename(key, DST_TYPE_PRIVATE, dir, &buf);
if (strcmp(oldname, newname) == 0)
goto cleanup;
if (access(oldname, F_OK) == 0)
unlink(oldname);
(void)unlink(oldname);
isc_buffer_clear(&buf);
dst_key_buildfilename(key, DST_TYPE_PUBLIC, dir, &buf);
if (access(oldname, F_OK) == 0)
unlink(oldname);
(void)unlink(oldname);
}
} else {
dst_key_format(key, keystr, sizeof(keystr));

4
lib/dns/nsec3.c
View file

@ -845,8 +845,8 @@ dns_nsec3_addnsec3(dns_db_t *db, dns_dbversion_t *version,
dns_db_detachnode(db, &newnode);
} while (1);
if (result == ISC_R_NOMORE)
result = ISC_R_SUCCESS;
/* result cannot be ISC_R_NOMORE here */
INSIST(result != ISC_R_NOMORE);
failure:
if (dbit != NULL)

8
lib/dns/time.c
View file

@ -161,6 +161,14 @@ dns_time64_fromtext(const char *source, isc_int64_t *target) {
RANGE(1, 12, month);
RANGE(1, days[month - 1] +
((month == 2 && is_leap(year)) ? 1 : 0), day);
#ifdef __COVERITY__
/*
* Use a simplified range to silence Coverity warning (in
* arithmetic with day below).
*/
RANGE(1, 31, day);
#endif /* __COVERITY__ */
RANGE(0, 23, hour);
RANGE(0, 59, minute);
RANGE(0, 60, second); /* 60 == leap second. */