From d954e152d9f2901118b1fe36d3931ec244317fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Thu, 8 Apr 2021 10:33:44 +0200 Subject: [PATCH 1/2] Free resources when gss_accept_sec_context() fails Even if a call to gss_accept_sec_context() fails, it might still cause a GSS-API response token to be allocated and left for the caller to release. Make sure the token is released before an early return from dst_gssapi_acceptctx(). --- lib/dns/gssapictx.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/dns/gssapictx.c b/lib/dns/gssapictx.c index ee512041fe..6132d863e6 100644 --- a/lib/dns/gssapictx.c +++ b/lib/dns/gssapictx.c @@ -739,6 +739,9 @@ dst_gssapi_acceptctx(dns_gss_cred_id_t cred, const char *gssapi_keytab, default: gss_log(3, "failed gss_accept_sec_context: %s", gss_error_tostring(gret, minor, buf, sizeof(buf))); + if (gouttoken.length > 0U) { + (void)gss_release_buffer(&minor, &gouttoken); + } return (result); } From 7eb87270a4362968f41dfc8febea95c1e2003c8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Thu, 8 Apr 2021 10:33:44 +0200 Subject: [PATCH 2/2] Add CHANGES entry --- CHANGES | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGES b/CHANGES index 29e2029f01..e08ba33579 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +5614. [bug] Ensure all resources are properly cleaned up when a call + to gss_accept_sec_context() fails. [GL #2620] + 5613. [bug] It was possible to write an invalid transaction header in the journal file for a managed-keys database after upgrading. This has been fixed. Invalid headers in