mirror of
https://github.com/isc-projects/bind9.git
synced 2026-05-26 03:12:16 -04:00
Use "git push --force-with-lease" for autorebases
If a merge request is merged to an autorebased branch while it is
getting rebased, the "git push -f" command at the end of the autorebase
job will cause the contents of that merge request to be silently deleted
from Git history even though the merge request will still be (correctly)
shown as "merged" by GitLab.
Use "git push --force-with-lease" instead to prevent force-pushing the
rebased version of the branch if it is pushed to after its pre-rebase
version is fetched by the autorebase job. Report such an event
accordingly. For simplicity, no retries are attempted as the problem is
expected to be resolved by the next autorebase and the chances of this
scenario happening in practice are already low to begin with.
(cherry picked from commit f5a7671107)
This commit is contained in:
parent
d7f9a6d627
commit
da3c195824
1 changed files with 6 additions and 2 deletions
|
|
@ -2462,7 +2462,7 @@ merged-metadata:
|
|||
- *configure
|
||||
- make -j${BUILD_PARALLEL_JOBS:-1} V=1
|
||||
- git range-diff --color=always "${BASE_COMMIT}" "${CI_COMMIT_SHA}" HEAD
|
||||
- git push -f origin "HEAD:${CI_COMMIT_REF_NAME}"
|
||||
- if ! git push --force-with-lease origin "HEAD:${CI_COMMIT_REF_NAME}"; then touch .git-push-failed; exit 1; fi
|
||||
after_script:
|
||||
- if [ "${CI_JOB_STATUS}" = "success" ]; then exit 0; fi
|
||||
- OLDEST_MERGE_COMMIT="$(git log --reverse --merges --pretty=%H "${CI_COMMIT_SHA}..${BASE_COMMIT}" | head -1)"
|
||||
|
|
@ -2477,7 +2477,11 @@ merged-metadata:
|
|||
# Rebase did not fail; most likely, this is a build failure, or the job was canceled
|
||||
CONFLICT_COMMIT="${OLDEST_MERGE_COMMIT}"
|
||||
if [ "${CI_JOB_STATUS}" = "failed" ]; then
|
||||
REASON="build failure after a successful rebase"
|
||||
if [ -f ".git-push-failed" ]; then
|
||||
REASON="branch was updated during rebase"
|
||||
else
|
||||
REASON="build failure after a successful rebase"
|
||||
fi
|
||||
else
|
||||
REASON="job was canceled"
|
||||
fi
|
||||
|
|
|
|||
Loading…
Reference in a new issue