upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 08:50:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

The nodefullname doesn't need a read lock to access .name

Browse source 
The qpznode->name is constant - assigned when the node is created
and it is immutable, so there's no reason to have it locked at all.
This commit is contained in:
Ondřej Surý 2025-07-02 18:19:50 +02:00
parent 3f3993b493
commit d555cb9704
No known key found for this signature in database
GPG key ID: 2820F37E873DEA41
1 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
lib/dns/qpzone.c
View file

@ -5144,18 +5144,12 @@ qpzone_deleterdataset(dns_db_t *db, dns_dbnode_t *dbnode,
static isc_result_t
nodefullname(dns_dbnode_t *node, dns_name_t *name) {
qpznode_t *qpnode = (qpznode_t *)node;
isc_rwlocktype_t nlocktype = isc_rwlocktype_none;
isc_rwlock_t *nlock = NULL;
REQUIRE(node != NULL);
REQUIRE(name != NULL);
nlock = qpzone_get_lock(qpnode);
qpznode_t *qpnode = (qpznode_t *)node;
NODE_RDLOCK(nlock, &nlocktype);
dns_name_copy(&qpnode->name, name);
NODE_UNLOCK(nlock, &nlocktype);
return ISC_R_SUCCESS;
}