upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-10 18:59:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

lib/ns/query.c: Fix invalid order of DbC checks that could cause dereference before NULL check

Browse source
This commit is contained in:
Ondřej Surý 2019-09-27 12:12:14 +02:00
parent 033f3eb580
commit d1f035bbba
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/ns/query.c
View file

@ -10930,15 +10930,19 @@ log_queryerror(ns_client_t *client, isc_result_t result, int line, int level) {
void void
ns_query_start(ns_client_t *client) { ns_query_start(ns_client_t *client) {
isc_result_t result; isc_result_t result;
dns_message_t *message = client->message; dns_message_t *message;
dns_rdataset_t *rdataset; dns_rdataset_t *rdataset;
ns_client_t *qclient; ns_client_t *qclient;
dns_rdatatype_t qtype; dns_rdatatype_t qtype;
unsigned int saved_extflags = client->extflags; unsigned int saved_extflags;
unsigned int saved_flags = client->message->flags; unsigned int saved_flags;
REQUIRE(NS_CLIENT_VALID(client)); REQUIRE(NS_CLIENT_VALID(client));
message = client->message;
saved_extflags = client->extflags;
saved_flags = client->message->flags;
CTRACE(ISC_LOG_DEBUG(3), "ns_query_start"); CTRACE(ISC_LOG_DEBUG(3), "ns_query_start");
/* /*