upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

[9.20] fix: test: unit test tsig_badsig was not being called

Browse source 
Additionally, the test was badly implemented. This has been fixed.

Closes #5712

Backport of MR !11478

Merge branch 'backport-5712-unit-test-tsig_badsig-was-not-being-called-9.20' into 'bind-9.20'

See merge request isc-projects/bind9!11485
This commit is contained in:
Mark Andrews 2026-01-24 09:08:36 +11:00
commit d192c7c33a
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tests/dns/tsig_test.c
View file

@ -438,7 +438,16 @@ tsig_tcp(isc_stdtime_t now, isc_result_t expected_result, bool mangle_sig) {
assert_int_equal(msg->verified_sig, 1);
assert_int_equal(msg->tsigstatus, dns_tsigerror_badtime);
break;
case DNS_R_TSIGVERIFYFAILURE:
assert_int_equal(result, DNS_R_TSIGVERIFYFAILURE);
assert_int_equal(msg->verified_sig, 0);
assert_int_equal(msg->tsigstatus, dns_tsigerror_badsig);
break;
default:
if (debug) {
fprintf(stderr, "# result = %s\n",
isc_result_totext(result));
}
UNREACHABLE();
}
@ -490,7 +499,7 @@ ISC_RUN_TEST_IMPL(tsig_badtime) {
}
ISC_RUN_TEST_IMPL(tsig_badsig) {
tsig_tcp(isc_stdtime_now(), DNS_R_TSIGERRORSET, true);
tsig_tcp(isc_stdtime_now(), DNS_R_TSIGVERIFYFAILURE, true);
}
/* Tests the dns__tsig_algvalid function */
@ -509,9 +518,10 @@ ISC_RUN_TEST_IMPL(algvalid) {
}
ISC_TEST_LIST_START
ISC_TEST_ENTRY_CUSTOM(tsig_tcp, setup_test, teardown_test)
ISC_TEST_ENTRY_CUSTOM(tsig_badtime, setup_test, teardown_test)
ISC_TEST_ENTRY(algvalid)
ISC_TEST_ENTRY_CUSTOM(tsig_badsig, setup_test, teardown_test)
ISC_TEST_ENTRY_CUSTOM(tsig_badtime, setup_test, teardown_test)
ISC_TEST_ENTRY_CUSTOM(tsig_tcp, setup_test, teardown_test)
ISC_TEST_LIST_END
ISC_TEST_MAIN