2073. [bug] Incorrect semantics check for update policy "wildcard".

[RT #16353]
This commit is contained in:
Mark Andrews 2006-08-21 00:11:43 +00:00
parent 71faae1e6f
commit cdb674387c
2 changed files with 11 additions and 8 deletions

View file

@ -1,3 +1,6 @@
2073. [bug] Incorrect semantics check for update policy "wildcard".
[RT #16353]
2072. [bug] We were not generating valid HMAC SHA digests.
[RT #16320]

View file

@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE.
*/
/* $Id: check.c,v 1.75 2006/06/04 23:17:06 marka Exp $ */
/* $Id: check.c,v 1.76 2006/08/21 00:11:43 marka Exp $ */
/*! \file */
@ -816,13 +816,6 @@ check_update_policy(const cfg_obj_t *policy, isc_log_t *logctx) {
"'%s' is not a valid name", str);
result = tresult;
}
if (tresult == ISC_R_SUCCESS &&
strcasecmp(cfg_obj_asstring(matchtype), "wildcard") == 0 &&
!dns_name_iswildcard(dns_fixedname_name(&fixed))) {
cfg_obj_log(identity, logctx, ISC_LOG_ERROR,
"'%s' is not a wildcard", str);
result = ISC_R_FAILURE;
}
dns_fixedname_init(&fixed);
str = cfg_obj_asstring(dname);
@ -835,6 +828,13 @@ check_update_policy(const cfg_obj_t *policy, isc_log_t *logctx) {
"'%s' is not a valid name", str);
result = tresult;
}
if (tresult == ISC_R_SUCCESS &&
strcasecmp(cfg_obj_asstring(matchtype), "wildcard") == 0 &&
!dns_name_iswildcard(dns_fixedname_name(&fixed))) {
cfg_obj_log(identity, logctx, ISC_LOG_ERROR,
"'%s' is not a wildcard", str);
result = ISC_R_FAILURE;
}
for (element2 = cfg_list_first(typelist);
element2 != NULL;