From 343e67ad39228dc80d9ddccb3795bb102f771695 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 30 Nov 2022 10:46:40 +0100 Subject: [PATCH 1/2] Don't log "final reference detached" on INFO level The "final reference detached" message was meant to be DEBUG(1), but was instead kept at INFO level. Move it to the DEBUG(1) logging level, so it's not printed under normal operations. (cherry picked from commit 1816244725c8e41aaa72b7f7f14bf1a1cde61b14) --- lib/dns/zone.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dns/zone.c b/lib/dns/zone.c index e2800db233..1165e8f9c7 100644 --- a/lib/dns/zone.c +++ b/lib/dns/zone.c @@ -5813,7 +5813,8 @@ dns_zone_detach(dns_zone_t **zonep) { * Stop things being restarted after we cancel them below. */ DNS_ZONE_SETFLAG(zone, DNS_ZONEFLG_EXITING); - dns_zone_log(zone, ISC_LOG_INFO, "final reference detached"); + dns_zone_log(zone, ISC_LOG_DEBUG(1), + "final reference detached"); if (zone->task != NULL) { /* * This zone has a task; it can clean From 8675a1ac537e8c97ee32579bbeff1700d83dc696 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 30 Nov 2022 10:56:52 +0100 Subject: [PATCH 2/2] Add CHANGES and release note for [GL #3707] (cherry picked from commit 116d1b94a9404602c55bf92e8c5d84c27d586d7b) --- CHANGES | 4 ++++ doc/notes/notes-current.rst | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/CHANGES b/CHANGES index 320b432c23..1ad9a22c69 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,7 @@ +6031. [bug] Move the "final reference detached" log message + from dns_zone unit to the DEBUG(1) log level. + [GL #3707] + 6027. [bug] Fix assertion failure in isc_http API used by statschannel if the read callback would be called on HTTP request that has been already closed. diff --git a/doc/notes/notes-current.rst b/doc/notes/notes-current.rst index 9b68e65012..d0aaeccf75 100644 --- a/doc/notes/notes-current.rst +++ b/doc/notes/notes-current.rst @@ -54,6 +54,11 @@ Bug Fixes - Fix an assertion failure in the statschannel caused by reading from the HTTP connection closed prematurely (connection error, shutdown). :gl:`#3693` +- The ``zone /: final reference detached`` log message was + moved from the INFO log level to the DEBUG(1) log level to prevent the + :iscman:`named-checkzone` tool from superfluously logging this message + in non-debug mode. :gl:`#3707` + Known Issues ~~~~~~~~~~~~