upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-15 01:10:05 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove unused dns_zone_getnotifyacl() function

Browse source 
CID 638286: Concurrent data access violations (MISSING_LOCK).  This
complains about accessing "zone->notifyctx.notify_acl" without holding
the lock "dns_zone.lock".  Elsewhere, reading this data does have the
lock, so it makes sense that in the getter function this must also be
so.  However, the function is unused so we can just remove it.

CID 638287: Concurrent data access violations (MISSING_LOCK).  This
complains about accessing "zone->locked" without holding the lock
"dns_zone.lock". I think this is a false positive as "dns__zone_lock()"
and "dns__zone_unlock() are wrappers around "LOCK_ZONE()" and
"UNLOCK_ZONE()" and where these macros were used they were only
replaced with the internal zone functions. Moreover, "zone->locked"
is only accessed in these macros (and "TRYLOCK_ZONE()" and
"LOCKED_ZONE()").
This commit is contained in:
Matthijs Mekking 2025-11-03 12:45:39 +01:00
parent 056a32798c
commit c9ecc0bd26
2 changed files with 0 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/dns/include/dns/zone.h
View file

@ -976,19 +976,6 @@ dns_zone_setxfracl(dns_zone_t *zone, dns_acl_t *acl);
*\li 'acl' to be valid acl.
*/
dns_acl_t *
dns_zone_getnotifyacl(dns_zone_t *zone);
/*%<
* Returns the current notify acl or NULL.
*
* Require:
*\li 'zone' to be a valid zone.
*
* Returns:
*\li acl a pointer to the acl.
*\li NULL
*/
dns_acl_t *
dns_zone_getqueryacl(dns_zone_t *zone);
/*%<

7
lib/dns/zone.c
View file

@ -15399,13 +15399,6 @@ dns_zone_setxfracl(dns_zone_t *zone, dns_acl_t *acl) {
UNLOCK_ZONE(zone);
}
dns_acl_t *
dns_zone_getnotifyacl(dns_zone_t *zone) {
REQUIRE(DNS_ZONE_VALID(zone));
return zone->notifyctx.notify_acl;
}
dns_acl_t *
dns_zone_getqueryacl(dns_zone_t *zone) {
REQUIRE(DNS_ZONE_VALID(zone));