From c61539279d4ecc04f9816b2ae62d63ed8a143c19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Thu, 21 May 2026 11:52:56 +0200 Subject: [PATCH] Drop redundant uses of authoritative=True The ans3 custom server instance is created with default_aa=True. Do not pass the authoritative=True keyword argument to the DnsResponseSend constructor in CookieHandler.get_responses() as it is redundant. --- bin/tests/system/resend_loop/ans3/ans.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bin/tests/system/resend_loop/ans3/ans.py b/bin/tests/system/resend_loop/ans3/ans.py index 860a2403ee..69ea0be6c7 100644 --- a/bin/tests/system/resend_loop/ans3/ans.py +++ b/bin/tests/system/resend_loop/ans3/ans.py @@ -80,13 +80,13 @@ class CookieHandler(DomainHandler): # If missing cookie entirely, just return SERVFAIL if cookie is None: qctx.response.set_rcode(dns.rcode.SERVFAIL) - yield DnsResponseSend(qctx.response, authoritative=True) + yield DnsResponseSend(qctx.response) # If there is a client cookie, mock BADCOOKIE to trigger # the resend loop logic. qctx.response.use_edns(options=[cookie]) qctx.response.set_rcode(dns.rcode.BADCOOKIE) - yield DnsResponseSend(qctx.response, authoritative=True) + yield DnsResponseSend(qctx.response) def resend_server() -> AsyncDnsServer: