upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-11 12:40:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

4813. [bug] Address potential read after free errors from

Browse source 
query_synthnodata, query_synthwildcard and
                        query_synthnxdomain. [RT #46547]
This commit is contained in:
Mark Andrews 2017-11-10 13:33:18 +11:00
parent 312c84c73a
commit c0e3e1fe44
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
CHANGES
View file

@ -1,3 +1,7 @@
4813. [bug] Address potential read after free errors from
query_synthnodata, query_synthwildcard and
query_synthnxdomain. [RT #46547]
4812. [bug] Minor improvements to stability and consistency of code
handling managed keys. [RT #46468]

8
lib/ns/query.c
View file

@ -8424,7 +8424,7 @@ query_synthnodata(query_ctx_t *qctx, const dns_name_t *signer,
goto cleanup;
}
dns_name_clone(signer, name);
dns_name_copy(signer, name, NULL);
/*
* Add SOA record. Omit the RRSIG if DNSSEC was not requested.
@ -8489,7 +8489,7 @@ query_synthwildcard(query_ctx_t *qctx, dns_rdataset_t *rdataset,
result = ISC_R_NOMEMORY;
goto cleanup;
}
dns_name_clone(qctx->client->query.qname, name);
dns_name_copy(qctx->client->query.qname, name, NULL);
clone = query_newrdataset(qctx->client);
if (clone == NULL) {
@ -8650,7 +8650,7 @@ query_synthnxdomain(query_ctx_t *qctx,
goto cleanup;
}
dns_name_clone(signer, name);
dns_name_copy(signer, name, NULL);
/*
* Add SOA record. Omit the RRSIG if DNSSEC was not requested.
@ -8681,7 +8681,7 @@ query_synthnxdomain(query_ctx_t *qctx,
goto cleanup;
}
dns_name_clone(nowild, name);
dns_name_copy(nowild, name, NULL);
clone = query_newrdataset(qctx->client);
sigclone = query_newrdataset(qctx->client);