From bf04258ed1670205155cc561d14d8c363a32cd09 Mon Sep 17 00:00:00 2001 From: William King Date: Thu, 28 Oct 1999 03:21:27 +0000 Subject: [PATCH] been having trouble with the FreeeBSD system - wait, waitpid and family act totally broken, but only for programs run from cron. the waitpid loop in t_api.c times out eventually, and the testcases are killed and reaped, but the net effect of the problem is to cause each testcase to take 60 seconds, which is the default timeout. As a result, the tests take forever to run and often don't finish before the report generator is run, causing the report generator to incorrectly reports an overall test status based on an incomplete journal ... so ... I've added some more simplistic journal correctness checking for now so that the FreeBSD test status is correctly reported - if a journal doesn't end with the correct end stanza, a test result of inspect(incomplete journal) is reported. obviously, at some point in the future, a test case count needs added so that the report generator can do more complete correctness checking of the journal. --- bin/tests/b9status.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bin/tests/b9status.pl b/bin/tests/b9status.pl index 1466b47138..ba17dc7eea 100755 --- a/bin/tests/b9status.pl +++ b/bin/tests/b9status.pl @@ -378,7 +378,7 @@ sub testCheck { next; } - if (/^E:(Mon|Tue|Wed|Thu|Fri|Sat|Sun)/) { + if (/^E:[^:]*:(Mon|Tue|Wed|Thu|Fri|Sat|Sun)/) { if ($inresult == 0) { # no reported result $BadTest = 1; @@ -464,6 +464,10 @@ sub testCheck { $BadTest = 1; $BadTestReason = "no tests"; } + if ($intest) { + $BadTest = 1; + $BadTestReason = "incomplete"; + } return(%probs); }