upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-06-10 21:20:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: dev: initialize queryonacl dns_view_t property

Browse source 
A dns_view_t has a queryonacl property, which is supposed to hold the
ACL matching the configuration "allow-query-on". However the code
parsing this configuration ACL was missing (or removed by mistake?),
hence this property was always NULL. The ACL was still built but
individually for each zone (which checks if the property exists in the
zone definition, view definition, and finally options definition).

We now create the ACL instance at the view level, enabling zones to
share the same (identical) ACL instead of having their own copies.

Merge branch 'colin/view-allowqueryon' into 'main'

See merge request isc-projects/bind9!10551
This commit is contained in:
Colin Vidal 2025-06-04 08:24:18 +00:00
commit bb1458460b
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
bin/named/server.c
View file

@ -4885,6 +4885,10 @@ configure_view(dns_view_t *view, dns_viewlist_t *viewlist, cfg_obj_t *config,
CHECK(configure_view_acl(vconfig, config, NULL, "allow-query-cache-on",
NULL, actx, named_g_mctx, &view->cacheonacl));
CHECK(configure_view_acl(vconfig, config, named_g_config,
"allow-query-on", NULL, actx, named_g_mctx,
&view->queryonacl));
CHECK(configure_view_acl(vconfig, config, named_g_config, "allow-proxy",
NULL, actx, named_g_mctx, &view->proxyacl));