From 9c17f4353b11deeb7cc71514a9d7119495e6a22f Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Tue, 21 Feb 2023 13:37:24 +1100 Subject: [PATCH] Cleanup left over 'fctx != NULL' test following refactoring This was causing 'CID 436299: Null pointer dereferences (REVERSE_INULL)' in Coverity. Also removed an 'INSIST(fctx != NULL);' that should no longer be needed. --- lib/dns/resolver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c index f6b6f64d10..e043b9a366 100644 --- a/lib/dns/resolver.c +++ b/lib/dns/resolver.c @@ -10613,11 +10613,10 @@ dns_resolver_createfetch(dns_resolver_t *res, const dns_name_t *name, } /* On success, the fctx is locked in get_attached_fctx() */ - INSIST(!SHUTTINGDOWN(fctx)); /* Is this a duplicate? */ - if (fctx != NULL && client != NULL) { + if (client != NULL) { dns_fetchresponse_t *resp = NULL; for (resp = ISC_LIST_HEAD(fctx->resps); resp != NULL; resp = ISC_LIST_NEXT(resp, link)) @@ -10632,7 +10631,6 @@ dns_resolver_createfetch(dns_resolver_t *res, const dns_name_t *name, } } if (count >= spillatmin && spillatmin != 0) { - INSIST(fctx != NULL); if (count >= spillat) { fctx->spilled = true; }