upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Stop the timer when shuttingdown the fetch context

Browse source 
When canceling the last fetch, we also need to stop the fctx_expired
timer from possibly firing between the fctx_shutdown() call and the
fetch being actually destroyed along with the timer.  As there are
multiple places where fctx_shutdown() is being called without stopping
the timer, move the fctx_stoptimer() to fctx_shutdown() and cleanup the
explicit usage.
This commit is contained in:
Ondřej Surý 2025-01-23 17:04:24 +01:00
parent 8e631afebe
commit b14df7d459
No known key found for this signature in database
GPG key ID: 2820F37E873DEA41
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/dns/resolver.c
View file

@ -1981,7 +1981,6 @@ fctx__done_detach(fetchctx_t **fctxp, isc_result_t result, const char *file,
fctx->qmin_warning = ISC_R_SUCCESS;
fctx_cancelqueries(fctx, no_response, age_untried);
fctx_stoptimer(fctx);
LOCK(&res->buckets[fctx->bucketnum].lock);
FCTX_ATTR_CLR(fctx, FCTX_ATTR_ADDRWAIT);
@ -4688,6 +4687,8 @@ fctx_shutdown(fetchctx_t *fctx) {
* exit.
*/
if (fctx->state != fetchstate_init) {
fctx_stoptimer(fctx);
FCTXTRACE("posting control event");
cevent = &fctx->control_event;
isc_task_sendto(fctx->res->buckets[fctx->bucketnum].task,